Default all `rabbitmq_integration_suite` to flaky in bazel

Most tests that can start rabbitmq nodes have some chance of
flaking. Rather than chase individual flakes for now, this commit
changes the default (though it can still be overriden, as is the case
for config_scheme_SUITE in many places, since I have yet to see that
particular suite flake).
This commit is contained in:
Philip Kuryloski 2021-06-21 16:10:38 +02:00
parent d8c4c0a887
commit 70cb8147b2
23 changed files with 48 additions and 51 deletions

View File

@ -343,7 +343,6 @@ rabbitmq_integration_suite(
},
"cluster_size_3": {
"groups": ["cluster_size_3"],
"flaky": True,
},
},
)
@ -358,7 +357,6 @@ rabbitmq_integration_suite(
PACKAGE,
name = "clustering_management_SUITE",
size = "large",
flaky = True,
matrix = ct_group_matrix([
"unclustered_2_nodes",
"unclustered_3_nodes",
@ -374,6 +372,7 @@ rabbitmq_integration_suite(
data = [
"test/definition_import_SUITE_data/case1.json",
],
flaky = False,
)
rabbitmq_integration_suite(
@ -404,7 +403,6 @@ rabbitmq_integration_suite(
additional_beam = [
":quorum_queue_utils",
],
flaky = True,
)
rabbitmq_integration_suite(
@ -475,7 +473,6 @@ rabbitmq_integration_suite(
additional_beam = [
":sync_detection_SUITE_beam_files",
],
flaky = True,
matrix = ct_group_case_matrix({
"non_parallel_tests": [
"eager_sync",
@ -521,7 +518,6 @@ rabbitmq_integration_suite(
"enabling_in_cluster-enable_feature_flag_when_ff_file_is_unwritable": {
"groups": ["enabling_in_cluster"],
"cases": ["enable_feature_flag_when_ff_file_is_unwritable"],
"flaky": True,
# The enabling_* tests chmod files and then expect writes to be blocked.
# This probably doesn't work because we are root in the remote docker image.
"tags": ["exclusive"],
@ -536,7 +532,6 @@ rabbitmq_integration_suite(
},
"clustering": {
"groups": ["clustering"],
"flaky": True,
},
"activating_plugin": {
"groups": ["activating_plugin"],
@ -630,7 +625,6 @@ rabbitmq_integration_suite(
PACKAGE,
name = "peer_discovery_classic_config_SUITE",
size = "medium",
flaky = True,
matrix = ct_group_case_matrix({
"non_parallel": [
"successful_discovery",
@ -784,11 +778,9 @@ rabbitmq_integration_suite(
},
"clustered-cluster_size_2": {
"groups": ["cluster_size_2"],
"flaky": True,
},
"clustered-cluster_size_3": {
"groups": ["cluster_size_3"],
"flaky": True,
},
"clustered-cluster_size_5": {
"groups": ["cluster_size_5"],
@ -907,24 +899,18 @@ rabbitmq_integration_suite(
additional_beam = [
":quorum_queue_utils",
],
matrix = {
"single_node": {"groups": ["single_node"]},
"single_node_parallel": {"groups": ["single_node_parallel"]},
"cluster_size_2": {"groups": ["cluster_size_2"]},
"cluster_size_2_parallel": {"groups": ["cluster_size_2_parallel"]},
"cluster_size_3": {
"groups": ["cluster_size_3"],
"flaky": True,
},
"cluster_size_3_parallel": {
"groups": ["cluster_size_3_parallel"],
"flaky": True,
},
"unclustered_size_3_1": {"groups": ["unclustered_size_3_1"]},
"unclustered_size_3_2": {"groups": ["unclustered_size_3_2"]},
"unclustered_size_3_3": {"groups": ["unclustered_size_3_3"]},
"cluster_size_3_1": {"groups": ["cluster_size_3_1"]},
},
matrix = ct_group_matrix([
"single_node",
"single_node_parallel",
"cluster_size_2",
"cluster_size_2_parallel",
"cluster_size_3",
"cluster_size_3_parallel",
"unclustered_size_3_1",
"unclustered_size_3_2",
"unclustered_size_3_3",
"cluster_size_3_1",
]),
deps = [
"@proper//:bazel_erlang_lib",
],

View File

@ -86,7 +86,6 @@ rabbitmq_integration_suite(
rabbitmq_integration_suite(
PACKAGE,
name = "system_SUITE",
flaky = True,
matrix = ct_group_matrix([
"dotnet",
"java",

View File

@ -60,6 +60,7 @@ PACKAGE = "deps/rabbitmq_auth_backend_cache"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(

View File

@ -82,6 +82,7 @@ rabbitmq_suite(
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_suite(

View File

@ -84,6 +84,7 @@ PACKAGE = "deps/rabbitmq_auth_backend_ldap"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(

View File

@ -69,6 +69,7 @@ rabbitmq_integration_suite(
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(

View File

@ -39,6 +39,7 @@ PACKAGE = "deps/rabbitmq_event_exchange"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(

View File

@ -101,15 +101,10 @@ rabbitmq_integration_suite(
additional_beam = [
":rabbit_federation_test_util",
],
matrix = {
"classic_queue": {
"groups": ["classic_queue"],
},
"quorum_queue": {
"groups": ["quorum_queue"],
"flaky": True,
},
},
matrix = ct_group_matrix([
"classic_queue",
"quorum_queue",
]),
)
rabbitmq_integration_suite(

View File

@ -120,6 +120,7 @@ rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
size = "small",
flaky = False,
)
rabbitmq_suite(

View File

@ -125,12 +125,12 @@ rabbitmq_integration_suite(
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(
PACKAGE,
name = "java_SUITE",
flaky = True,
)
rabbitmq_suite(

View File

@ -57,6 +57,7 @@ rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
size = "small",
flaky = False,
)
# NOTE: integration_SUITE requires aws credentials and a docker image.

View File

@ -69,4 +69,5 @@ PACKAGE = "deps/rabbitmq_peer_discovery_common"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)

View File

@ -47,6 +47,7 @@ PACKAGE = "deps/rabbitmq_peer_discovery_consul"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_suite(

View File

@ -49,6 +49,7 @@ PACKAGE = "deps/rabbitmq_peer_discovery_etcd"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(

View File

@ -47,6 +47,7 @@ PACKAGE = "deps/rabbitmq_peer_discovery_k8s"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_suite(

View File

@ -55,11 +55,11 @@ PACKAGE = "deps/rabbitmq_prometheus"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(
PACKAGE,
name = "rabbit_prometheus_http_SUITE",
size = "small",
flaky = True,
)

View File

@ -137,7 +137,6 @@ rabbitmq_integration_suite(
additional_beam = [
":shovel_test_utils",
],
flaky = True,
)
rabbitmq_suite(

View File

@ -105,6 +105,7 @@ rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
size = "small",
flaky = False,
)
rabbitmq_integration_suite(

View File

@ -1,3 +1,4 @@
load("@bazel-erlang//:ct.bzl", "ct_group_matrix")
load("@bazel-erlang//:xref.bzl", "xref")
load("@bazel-erlang//:dialyze.bzl", "dialyze")
load(
@ -83,20 +84,16 @@ rabbitmq_integration_suite(
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(
PACKAGE,
name = "rabbit_stream_SUITE",
matrix = {
"single_node": {
"groups": ["single_node"],
},
"cluster": {
"groups": ["cluster"],
"flaky": True,
},
},
matrix = ct_group_matrix([
"single_node",
"cluster",
]),
deps = [
"//deps/rabbitmq_stream_common:bazel_erlang_lib",
],

View File

@ -48,7 +48,10 @@ rabbitmq_lib(
deps = DEPS,
)
xref(tags = ["xref"])
xref(
size = "small",
tags = ["xref"],
)
plt(
name = "base_plt",
@ -57,6 +60,7 @@ plt(
)
dialyze(
size = "small",
dialyzer_opts = RABBITMQ_DIALYZER_OPTS,
plt = ":base_plt",
tags = ["dialyze"],
@ -82,12 +86,13 @@ PACKAGE = "deps/rabbitmq_trust_store"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
size = "small",
flaky = False,
)
rabbitmq_integration_suite(
PACKAGE,
name = "system_SUITE",
flaky = True,
matrix = ct_group_matrix([
"file_provider_tests",
"http_provider_tests",

View File

@ -63,6 +63,7 @@ PACKAGE = "deps/rabbitmq_web_mqtt"
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(

View File

@ -84,6 +84,7 @@ rabbitmq_integration_suite(
rabbitmq_integration_suite(
PACKAGE,
name = "config_schema_SUITE",
flaky = False,
)
rabbitmq_integration_suite(

View File

@ -113,6 +113,7 @@ def rabbitmq_integration_suite(
tools = [],
deps = [],
runtime_deps = [],
flaky = True,
**kwargs):
ct_suite(
erlc_opts = RABBITMQ_TEST_ERLC_OPTS + erlc_opts,
@ -141,5 +142,6 @@ def rabbitmq_integration_suite(
"//deps/rabbit_common:bazel_erlang_lib",
"@rabbitmq_ct_helpers//:bazel_erlang_lib",
] + deps,
flaky = flaky,
**kwargs
)