root
/
rabbitmq-server
mirror of https://github.com/rabbitmq/rabbitmq-server.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

amqp10_client: Handle `close` message in the `open_sent` state 

[Why]
Without this, the connection process crashes. We see this happenning in
CI frequently.
This commit is contained in:
Jean-Sébastien Pédron 2025-02-25 19:22:54 +01:00
parent 2c66191043
commit 77e3636272
No known key found for this signature in database
GPG Key ID: 39E99761A5FD94CC
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
deps/amqp10_client/src/amqp10_client_connection.erl vendored
View File

@ -287,6 +287,22 @@ open_sent({call, From}, begin_session,
#state{pending_session_reqs = PendingSessionReqs} = State) -> #state{pending_session_reqs = PendingSessionReqs} = State) ->
State1 = State#state{pending_session_reqs = [From | PendingSessionReqs]}, State1 = State#state{pending_session_reqs = [From | PendingSessionReqs]},
{keep_state, State1}; {keep_state, State1};
open_sent(_EvtType, {close, Reason}, State) ->
%% TODO: stop all sessions writing
%% We could still accept incoming frames (See: 2.4.6)
case send_close(State, Reason) of
ok ->
%% "After writing this frame the peer SHOULD continue to read from the connection
%% until it receives the partner's close frame (in order to guard against
%% erroneously or maliciously implemented partners, a peer SHOULD implement a
%% timeout to give its partner a reasonable time to receive and process the close
%% before giving up and simply closing the underlying transport mechanism)." [§2.4.3]
{next_state, close_sent, State, {state_timeout, ?TIMEOUT, received_no_close_frame}};
{error, closed} ->
{stop, normal, State};
Error ->
{stop, Error, State}
end;
open_sent(info, {'DOWN', MRef, process, _, _}, open_sent(info, {'DOWN', MRef, process, _, _},
#state{reader_m_ref = MRef}) -> #state{reader_m_ref = MRef}) ->
{stop, {shutdown, reader_down}}. {stop, {shutdown, reader_down}}.