root
/
rabbitmq-server
mirror of https://github.com/rabbitmq/rabbitmq-server.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Fix flake in test case session_upgrade_v3_v5_qos1 

CI sometimes failed with the following error:
```
v5_SUITE:session_upgrade_v3_v5_qos failed on line 1068
Reason: {test_case_failed,Received unexpected PUBLISH payload. Expected: <<"2">> Got: <<"3">>}
```

The emqtt client auto acks by default.
Therefore, if Subv3 client was able to successfully auto ack message 2
before Subv3 disconnected, Subv5 client did not receive message 2.

This commit fixes this flake by making sure that Subv3 does not ack
message 2.
This commit is contained in:
David Ansari 2025-03-11 16:58:59 +01:00 committed by David Ansari
parent 04a806731b
commit 7cf076673b
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
deps/rabbitmq_mqtt/test/v5_SUITE.erl vendored
View File

@ -1020,17 +1020,27 @@ session_upgrade_v3_v5_qos0(Config) ->
session_upgrade_v3_v5_qos(Qos, Config) ->
ClientId = Topic = atom_to_binary(?FUNCTION_NAME),
Pub = connect(<<"publisher">>, Config),
Subv3 = connect(ClientId, Config, [{proto_ver, v3} | non_clean_sess_opts()]),
Subv3 = connect(ClientId, Config,
[{proto_ver, v3},
{auto_ack, false}] ++
non_clean_sess_opts()),
?assertEqual(3, proplists:get_value(proto_ver, emqtt:info(Subv3))),
{ok, _, [Qos]} = emqtt:subscribe(Subv3, Topic, Qos),
Sender = spawn_link(?MODULE, send, [self(), Pub, Topic, 0]),
receive {publish, #{payload := <<"1">>,
client_pid := Subv3}} -> ok
client_pid := Subv3,
packet_id := PacketId}} ->
case Qos of
0 -> ok;
1 -> emqtt:puback(Subv3, PacketId)
end
after ?TIMEOUT -> ct:fail("did not receive 1")
end,
%% Upgrade session from v3 to v5 while another client is sending messages.
ok = emqtt:disconnect(Subv3),
Subv5 = connect(ClientId, Config, [{proto_ver, v5}, {clean_start, false}]),
Subv5 = connect(ClientId, Config, [{proto_ver, v5},
{clean_start, false},
{auto_ack, true}]),
?assertEqual(5, proplists:get_value(proto_ver, emqtt:info(Subv5))),
Sender ! stop,
NumSent = receive {N, Sender} -> N