Merge pull request #12894 from rabbitmq/md/cli-warnings

CLI: Error on compiler warnings in tests
This commit is contained in:
Michael Klishin 2024-12-04 14:41:26 -05:00 committed by GitHub
commit 9fb0136513
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 5 additions and 7 deletions

View File

@ -17,7 +17,7 @@ VERBOSE_TEST ?= true
MAX_CASES ?= 1
MIX_TEST_OPTS ?= ""
MIX_TEST = ERL_COMPILER_OPTIONS=deterministic mix test --max-cases=$(MAX_CASES)
MIX_TEST = ERL_COMPILER_OPTIONS=deterministic MIX_ENV=test mix do compile --warnings-as-errors, test --max-cases=$(MAX_CASES) --warnings-as-errors
ifneq ("",$(MIX_TEST_OPTS))
MIX_TEST := $(MIX_TEST) $(MIX_TEST_OPTS)

View File

@ -94,7 +94,7 @@ defmodule RabbitMQ.CLI.AutoComplete do
defp complete_command_opts(command, <<"-", _::binary>> = opt) do
switches =
command.switches
command.switches()
|> Keyword.keys()
|> Enum.map(fn sw -> "--" <> to_string(sw) end)

View File

@ -10,7 +10,6 @@ defmodule CheckIfAnyDeprecatedFeaturesAreUsedCommandTest do
@command RabbitMQ.CLI.Diagnostics.Commands.CheckIfAnyDeprecatedFeaturesAreUsedCommand
@policy_name "cmq-policy-8373"
@policy_value "{\"ha-mode\":\"all\"}"
setup_all do
RabbitMQ.CLI.Core.Distribution.start()

View File

@ -10,7 +10,6 @@ defmodule CheckIfClusterHasClassicQueueMirroringPolicyCommandTest do
@command RabbitMQ.CLI.Diagnostics.Commands.CheckIfClusterHasClassicQueueMirroringPolicyCommand
@policy_name "cmq-policy-8373"
@policy_value "{\"ha-mode\":\"all\"}"
setup_all do
RabbitMQ.CLI.Core.Distribution.start()

View File

@ -37,7 +37,7 @@ defmodule DiscoverPeersCommandTest do
@tag test_timeout: 15000
test "run: returns a list of nodes when the backend isn't configured", context do
this_node = node()
assert match?({:ok, {[this_node], _}}, @command.run([], context[:opts]))
this_node = context.opts.node
assert match?({:ok, {[^this_node], _}}, @command.run([], context[:opts]))
end
end

View File

@ -121,7 +121,7 @@ defmodule RabbitMQCtlTest do
test "short node name without the host part connects properly" do
command = ["status", "-n", "rabbit"]
capture_io(:stderr, fn -> error_check(command, exit_ok()) end)
capture_io(:stdio, fn -> error_check(command, exit_ok()) end)
end
test "a non-existent command results in help message displayed" do