root
/
rabbitmq-server
mirror of https://github.com/rabbitmq/rabbitmq-server.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Replace Async threads warning with Dirty I/O 

Async threads are basically not used these days.
Dirty I/O schedulers, on the other hand, are used a lot.
This commit is contained in:
Michal Kuratczyk 2021-03-01 14:06:02 +01:00 committed by Michael Klishin
parent 66ac1bf5e9
commit a0aa8139b1
No known key found for this signature in database
GPG Key ID: E80EDCFA0CDB21EE
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
deps/rabbit/src/rabbit.erl vendored
View File

@ -271,7 +271,7 @@
-define(APPS, [os_mon, mnesia, rabbit_common, rabbitmq_prelaunch, ra, sysmon_handler, rabbit, osiris]).
-define(ASYNC_THREADS_WARNING_THRESHOLD, 8).
-define(DIRTY_IO_SCHEDULERS_WARNING_THRESHOLD, 10).
%% 1 minute
-define(BOOT_START_TIMEOUT, 1 * 60 * 1000).
@ -1230,11 +1230,11 @@ warn_if_kernel_config_dubious() ->
"and CPU utilization may worsen.~n")
end
end,
AsyncThreads = erlang:system_info(thread_pool_size),
case AsyncThreads < ?ASYNC_THREADS_WARNING_THRESHOLD of
DirtyIOSchedulers = erlang:system_info(dirty_io_schedulers),
case DirtyIOSchedulers < ?DIRTY_IO_SCHEDULERS_WARNING_THRESHOLD of
true -> rabbit_log:warning(
"Erlang VM is running with ~b I/O threads, "
"file I/O performance may worsen~n", [AsyncThreads]);
"Erlang VM is running with ~b dirty I/O schedulers, "
"file I/O performance may worsen~n", [DirtyIOSchedulers]);
false -> ok
end,
IDCOpts = case application:get_env(kernel, inet_default_connect_options) of