From 4c73edd923f65ef654f6b63ddf29d0911ce09c3f Mon Sep 17 00:00:00 2001 From: David Ansari Date: Thu, 17 Jul 2025 10:35:00 +0200 Subject: [PATCH 1/2] Deny `amqp_filter_set_bug` by default The deprecated feature flag `amqp_filter_set_bug` was introduced in RabbitMQ 4.1 with phase `permitted_by_default`. See https://github.com/rabbitmq/rabbitmq-server/pull/12415 This commit which will land in RabbitMQ 4.2 changes the phase to `denied_by_default`. --- deps/rabbit/src/rabbit_amqp_session.erl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/rabbit/src/rabbit_amqp_session.erl b/deps/rabbit/src/rabbit_amqp_session.erl index 27c6d96913..303476f779 100644 --- a/deps/rabbit/src/rabbit_amqp_session.erl +++ b/deps/rabbit/src/rabbit_amqp_session.erl @@ -34,7 +34,7 @@ -rabbit_deprecated_feature( {amqp_filter_set_bug, - #{deprecation_phase => permitted_by_default, + #{deprecation_phase => denied_by_default, doc_url => "https://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-filter-set" }}). From a850505b18e0d881eb62ed8dad1b6e8e41aedd4b Mon Sep 17 00:00:00 2001 From: David Ansari Date: Thu, 17 Jul 2025 11:29:53 +0200 Subject: [PATCH 2/2] Fix failing test case `streams` Fix ``` make -C deps/rabbit ct-amqp_dotnet t=cluster_size_1:streams ``` --- .../rabbit/test/amqp_dotnet_SUITE_data/fsharp-tests/Program.fs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/deps/rabbit/test/amqp_dotnet_SUITE_data/fsharp-tests/Program.fs b/deps/rabbit/test/amqp_dotnet_SUITE_data/fsharp-tests/Program.fs index 67758ec6a7..3aa07b5274 100755 --- a/deps/rabbit/test/amqp_dotnet_SUITE_data/fsharp-tests/Program.fs +++ b/deps/rabbit/test/amqp_dotnet_SUITE_data/fsharp-tests/Program.fs @@ -199,7 +199,8 @@ module Test = for spec in specs do printfn "testing streams spec %A" spec let filterSet = Map() - filterSet.Add(Symbol "rabbitmq:stream-offset-spec", spec) + let describedValue = DescribedValue(Symbol "rabbitmq:stream-offset-spec", spec) + filterSet.Add(Symbol "my offset", describedValue) let source = Source(Address = address, FilterSet = filterSet) let attach = Attach(Source = source)