From e1b649c0c6fd82031704a2ecba353062ecb7e70f Mon Sep 17 00:00:00 2001
From: Michal Kuratczyk <mkuratczyk@vmware.com>
Date: Mon, 15 Jul 2024 14:09:11 +0200
Subject: [PATCH] check_if_node_is_mirror_sync_critical is no-op

Make `check_if_node_is_mirror_sync_critical` a no-op
with a deprecation warning. Since this command is commonly used
as part of the node shutdown process (eg. by Cluster Operator),
making it a no-op instead of removing completly will make the
transition to 4.0 easier for users.
---
 ...if_node_is_mirror_sync_critical_command.ex | 90 ++-----------------
 1 file changed, 9 insertions(+), 81 deletions(-)

diff --git a/deps/rabbitmq_cli/lib/rabbitmq/cli/queues/commands/check_if_node_is_mirror_sync_critical_command.ex b/deps/rabbitmq_cli/lib/rabbitmq/cli/queues/commands/check_if_node_is_mirror_sync_critical_command.ex
index 733d58cb4f..33b1d398bf 100644
--- a/deps/rabbitmq_cli/lib/rabbitmq/cli/queues/commands/check_if_node_is_mirror_sync_critical_command.ex
+++ b/deps/rabbitmq_cli/lib/rabbitmq/cli/queues/commands/check_if_node_is_mirror_sync_critical_command.ex
@@ -6,6 +6,8 @@
 
 defmodule RabbitMQ.CLI.Queues.Commands.CheckIfNodeIsMirrorSyncCriticalCommand do
   @moduledoc """
+  DEPRECATED: this command does nothing in RabbitMQ 4.0 and newer.
+
   Exits with a non-zero code if there are classic mirrored queues that don't
   have any in sync mirrors online and would potentially lose data
   if the target node is shut down.
@@ -25,103 +27,29 @@ defmodule RabbitMQ.CLI.Queues.Commands.CheckIfNodeIsMirrorSyncCriticalCommand do
   use RabbitMQ.CLI.Core.RequiresRabbitAppRunning
 
   def run([], %{node: node_name, timeout: timeout}) do
-    case :rabbit_misc.rpc_call(node_name, :rabbit_nodes, :is_single_node_cluster, [], timeout) do
-      # if target node is the only one in the cluster, the check makes little sense
-      # and false positives can be misleading
-      true ->
-        {:ok, :single_node_cluster}
-
-      false ->
-        case :rabbit_misc.rpc_call(
-               node_name,
-               :rabbit_amqqueue,
-               :list_local_mirrored_classic_without_synchronised_mirrors_for_cli,
-               [],
-               timeout
-             ) do
-          [] -> {:ok, []}
-          qs when is_list(qs) -> {:ok, qs}
-          other -> other
-        end
-
-      other ->
-        other
-    end
+    :ok
   end
 
-  def output({:ok, :single_node_cluster}, %{formatter: "json"}) do
-    {:ok,
-     %{
-       "result" => "ok",
-       "message" =>
-         "Target node seems to be the only one in a single node cluster, the check does not apply"
-     }}
-  end
-
-  def output({:ok, []}, %{formatter: "json"}) do
+  def output(:ok, %{formatter: "json"}) do
     {:ok, %{"result" => "ok"}}
   end
 
-  def output({:ok, :single_node_cluster}, %{silent: true}) do
-    {:ok, :check_passed}
-  end
-
-  def output({:ok, []}, %{silent: true}) do
-    {:ok, :check_passed}
-  end
-
-  def output({:ok, :single_node_cluster}, %{node: node_name}) do
-    {:ok,
-     "Node #{node_name} seems to be the only one in a single node cluster, the check does not apply"}
-  end
-
-  def output({:ok, []}, %{node: node_name}) do
-    {:ok,
-     "Node #{node_name} reported no classic mirrored queues without online synchronised mirrors"}
-  end
-
-  def output({:ok, qs}, %{node: node_name, formatter: "json"}) when is_list(qs) do
-    {:error, :check_failed,
-     %{
-       "result" => "error",
-       "queues" => qs,
-       "message" =>
-         "Node #{node_name} reported local classic mirrored queues without online synchronised mirrors"
-     }}
-  end
-
-  def output({:ok, qs}, %{silent: true}) when is_list(qs) do
-    {:error, :check_failed}
-  end
-
-  def output({:ok, qs}, %{node: node_name}) when is_list(qs) do
-    lines = queue_lines(qs, node_name)
-
-    {:error, :check_failed, Enum.join(lines, line_separator())}
+  def output(:ok, %{node: node_name}) do
+    {:ok, "ok"}
   end
 
   use RabbitMQ.CLI.DefaultOutput
 
-  def help_section(), do: :observability_and_health_checks
+  def help_section(), do: :deprecated
 
   def description() do
-    "Health check that exits with a non-zero code if there are classic mirrored queues " <>
-      "without online synchronised mirrors (queues that would potentially lose data if the target node is shut down)"
+    "DEPRECATED. Mirrored queues were removed in RabbitMQ 4.0. This command is a no-op."
   end
 
   def usage, do: "check_if_node_is_mirror_sync_critical"
 
   def banner([], %{node: node_name}) do
-    "Checking if node #{node_name} is critical for data safety of any classic mirrored queues ..."
+    "This command is DEPRECATED and is a no-op. It will be removed in a future version."
   end
 
-  #
-  # Implementation
-  #
-
-  def queue_lines(qs, node_name) do
-    for q <- qs do
-      "#{q["readable_name"]} would lose its only synchronised replica (master) if node #{node_name} is stopped"
-    end
-  end
 end