root
/
rabbitmq-server
mirror of https://github.com/rabbitmq/rabbitmq-server.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

rabbit_exchange_type_consistent_hash_SUITE: Don't enable a feature flag that never existed 

[Why]
The `rabbit_consistent_hash_exchange_raft_based_metadata_store` does not
seem to be a feature flag that ever existed according to the git
history. This causes the test case to always be skipped.

[How]
Simply remove the statement that enables this ghost feature flag.
This commit is contained in:
Jean-Sébastien Pédron 2025-08-04 10:02:15 +02:00
parent 832d701f1f
commit ea2689f06a
No known key found for this signature in database
GPG Key ID: 39E99761A5FD94CC
1 changed files with 24 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
deps/rabbitmq_consistent_hash_exchange/test/rabbit_exchange_type_consistent_hash_SUITE.erl vendored
View File

@ -978,36 +978,30 @@ from_mnesia_to_khepri(Config) ->
case rabbit_ct_broker_helpers:enable_feature_flag(Config, khepri_db) of
ok ->
case rabbit_ct_broker_helpers:enable_feature_flag(Config, rabbit_consistent_hash_exchange_raft_based_metadata_store) of
ok ->
[amqp_channel:call(Chan,
#'basic.publish'{exchange = CHX, routing_key = rnd()},
#amqp_msg{props = #'P_basic'{}, payload = <<>>})
|| _ <- lists:duplicate(IterationCount, const)],
amqp_channel:wait_for_confirms(Chan, 300),
timer:sleep(500),
Counts =
[begin
#'queue.declare_ok'{message_count = M} =
amqp_channel:call(Chan, #'queue.declare' {queue = Q,
exclusive = true}),
M
end || Q <- Queues],
?assertEqual(IterationCount, lists:sum(Counts)), %% All messages got routed
%% Chi-square test
%% H0: routing keys are not evenly distributed according to weight
Expected = [IterationCount div 6, IterationCount div 6, (IterationCount div 6) * 2, (IterationCount div 6) * 2],
Obs = lists:zip(Counts, Expected),
Chi = lists:sum([((O - E) * (O - E)) / E || {O, E} <- Obs]),
ct:pal("Chi-square test for 3 degrees of freedom is ~p, p = 0.01 is 11.35, observations (counts, expected): ~p",
[Chi, Obs]),
clean_up_test_topology(Config, CHX, Queues),
rabbit_ct_client_helpers:close_connection_and_channel(Conn, Chan),
ok;
Skip ->
rabbit_ct_client_helpers:close_connection_and_channel(Conn, Chan),
Skip
end;
[amqp_channel:call(Chan,
#'basic.publish'{exchange = CHX, routing_key = rnd()},
#amqp_msg{props = #'P_basic'{}, payload = <<>>})
|| _ <- lists:duplicate(IterationCount, const)],
amqp_channel:wait_for_confirms(Chan, 300),
timer:sleep(500),
Counts =
[begin
#'queue.declare_ok'{message_count = M} =
amqp_channel:call(Chan, #'queue.declare' {queue = Q,
exclusive = true}),
M
end || Q <- Queues],
?assertEqual(IterationCount, lists:sum(Counts)), %% All messages got routed
%% Chi-square test
%% H0: routing keys are not evenly distributed according to weight
Expected = [IterationCount div 6, IterationCount div 6, (IterationCount div 6) * 2, (IterationCount div 6) * 2],
Obs = lists:zip(Counts, Expected),
Chi = lists:sum([((O - E) * (O - E)) / E || {O, E} <- Obs]),
ct:pal("Chi-square test for 3 degrees of freedom is ~p, p = 0.01 is 11.35, observations (counts, expected): ~p",
[Chi, Obs]),
clean_up_test_topology(Config, CHX, Queues),
rabbit_ct_client_helpers:close_connection_and_channel(Conn, Chan),
ok;
Skip ->
rabbit_ct_client_helpers:close_connection_and_channel(Conn, Chan),
Skip