This allows scanning for `src/*.hrl` files under each deps directory
entry, fixing lookup for lines like:
-include("src/rabbit_feature_flags.hrl").
in `deps/rabbit/src/rabbit_feature_flags.erl` or
-include("src/amqp10_client.hrl").
in `deps/amqp10_client/test/mock_server.erl`.
This fixes ErlangLS include lookups for `include_lib` attributes like
```erl
-include_lib("khepri/lib/include.hrl").
```
when running erlang_ls and building with Bazel.
`khepri` ends up in the `extra_deps` directory as a symlink after
running `bazel run //tools:symlink_deps_for_erlang_ls`, so this change
picks up that `khepri` directory as a lib for `include_lib`s.
Repeated re-queues are a problem for quorums queues. A consumer
that repeatedly re-queues all messages may eventually cause the
quorum queue to run out of messages as the log cannot be truncated
if messages are not consumed in a fifo-ish order.
This change addresses this as follows:
All return commands are not send directly to the log but instead
are sent to the aux machine which evaluates how the return should be
processed. After this decision it will use the new "append" effect
to add it to the log as before.
If the queue has a delivery_limit configured the return command
will be appended as before and the message will be returned
to the front of the queue as before. This is safe as eventually
the message will be dropped or dead-letter when it reaches
it's delivery limit.
If the queue has _not_ configured a delivery_limit the return
will be turned into a new command that includes the original
message in full and will be returne to the back of the queue.
This ensure that messages in the queue will be cycled in fifo-ish
order and thus snapshots will be taken.
As suggested in #3647:
* Add commented-out section to disable bound_var_in_pattern
* Comment-out `elvis` as that is not yet a standard used by the team
cc @kjnilsson @mkuratczyk
Michael Davis
Rin Kuryloski
Luke Bakken
Karl Nilsson
Alexey Lebedeff
Michal Kuratczyk