Commit Graph

4704 Commits

Author SHA1 Message Date
Michael Klishin 20188a770e
rabbitmq.conf schema and tests for #13698 2025-04-09 02:02:47 -04:00
Loïc Hoguin 400e8006e5
Add new option require_auth_for_api_desc_page to mgmt
This allows restricting access to the /api/index.html and
the /cli/index.html page to authenticated users should the
user really want to. This can be enabled via advanced.config.
2025-04-07 15:59:13 +02:00
Marcial Rosales 8dfcfa61e4 Use relative path for the path linked to the cookie
used by mangement ui oauth logic to store the
token until it is moved onto the local storage
2025-04-01 14:02:51 +02:00
Michael Klishin 3756775ebe
Revert "Redirect to end_session_endpoint for idp_initiated logon when it is configured" 2025-03-28 02:31:09 -04:00
Michael Klishin ab8799a739
Redirect to end_session_endpoint for idp-initiated logon
Conflicts:
	selenium/bin/components/fakeportal
2025-03-27 19:01:01 -04:00
Karl Nilsson 4fe96dfd27 Ra 2.16.5 - bug fixes and minor improvements
Ra improvements:

* Don't allow a non-voter to start elections
* Register with ra directory before initialising ra server.
* Trigger tick_timeout immediately after entering leader state.
* Set a configurable segment max size

This commit also includes a change to turn the quorum queue
become leader callback to become a noop and instead rely on
the more promptly tick_handler to handle the meta data store
update after a leader election.

This more prompt tick update means there should be a much shorter
gap between the queue metrics being deleted from the old leader
node to them being available again on the new node resulting
in smoother message count metrics.

Fix test that relied on waiting on too simplistic a property
before asserting.
2025-03-27 17:06:31 +00:00
Loïc Hoguin 0a7c86b480
Fix the exception logged by Cowboy caused by double reply (#13612)
Issue introduced in 383ddb1634.

Authored-by: @lhoguin.
2025-03-25 17:12:57 -04:00
Iliia Khaprov 8ae0163643 Switch is_<queue_type> to using queue.type field
Also, since queue.type field rendered by QueueMod:format and all queues had it hard-coded here,
I unhardcode them here to use Type name.
2025-03-24 19:15:20 +01:00
Michael Klishin f2da1b5544
Extend the idea in #13512 to a few more tabs 2025-03-19 15:44:18 -04:00
Michael Klishin e275f77c4c
HTTP API: tests for the /health/checks/quorum-queues-without-elected* endpoints 2025-03-19 15:44:18 -04:00
Michael Klishin c8f24f535c
New HTTP API health check endpoints
for the check introduced in #13487.

Note that encoding a regular expression pattern
with percent encoding is a pain (e.g. '.*' = '.%2a'),
so these endpoints fall back to a default pattern
value that matches all queues.
2025-03-19 15:44:18 -04:00
Michael Klishin 2472e450ff
By @efimov90: a dark theme for the management UI (#13567)
This is a squashed commit that includes the following changes by @efimov90:

* Initial-theme-fix

Added light.css
Added dark.css
Added link for light.css and dark.css with media attribute
Added switcher

* Rework-light-style

* dark theme

* Removed not needed div

* Fix folder name

* Color scheme fix

Removes color-scheme from main.css
Added color-scheme: dark to dark.css
Added color-scheme: light to light.css

* Fixed theme switch bug with sammy.js

Adapts code to works with sammy.js

* Icons update

* Reworked theme switcher

* Fix updating attributes

---------

Authored-by: Sergey Efimov <efimov90@gmail.com>
2025-03-19 15:44:17 -04:00
Aitor Perez be30e9dc1d
Remove Bazel files 2025-03-19 15:44:15 -04:00
Iliia Khaprov a0abfaa5b0 Change browser tab/window title according to currently loaded 'page'.
It is very hard now to distinguish different tabs. With this addition
we have titles like 'RabbitMQ - Queue vhost/name', 'RabbitMQ - Exchanges'.
To be continued...
2025-03-14 09:42:53 +01:00
Michael Klishin ea5345e045
Merge pull request #13476 from rabbitmq/mgt-oauth-login-without-redirect
Improve oauth2 idp-initiated login
2025-03-12 15:16:41 -04:00
Marcial Rosales 69b54869c9 Use POST+Redirect_with_cookie 2025-03-12 16:48:02 +01:00
Mirah Gary f8ae3f1361
Update support link. 2025-03-12 16:06:51 +01:00
Michael Klishin ad42ae31e5
Make sure rabbitmq_management.delegate_count is always set 2025-03-06 15:36:13 -05:00
Ayanda Dube f60b284824 Add schema for management.delegate_count config 2025-03-06 13:09:15 +00:00
Ayanda Dube b5d9ebf16a Configurable management delegate count via: rabbitmq_management.delegate_count 2025-03-06 12:39:52 +00:00
Michal Kuratczyk 4b30935182
Update queue-messages and queue-message-body-bytes tooltips
Only large messages delivered to multiple CQs are stored once for
multiple queues.

Non-durable queues are deprecated and will be removed, so don't even
mention them.

We don't "page out" messages anymore.
2025-02-17 15:58:20 +01:00
Péter Gömöri b62e09806b Show consumer count column on Mgmt UI Channels page
Consumer count is already returned by the /channels API endpoint. Now
the consumer count column can be shown in the channels table but it is
hidden by default.
2025-02-03 18:31:55 +01:00
Michael Klishin bfd3a60954
Management plugin: recommend rabbitmqadmin v2 in one more place 2025-01-30 15:56:05 -05:00
Michael Klishin 4d04852c3e
Management plugin: recommend rabbitmqadmin v2 2025-01-30 15:49:57 -05:00
GitHub 840928de0e bazel run gazelle 2025-01-29 04:02:31 +00:00
Michael Klishin 00be47b828
Merge pull request #13167 from rabbitmq/mk-metadata-store-initialized-health-check
New health checks for metadata store initialization
2025-01-28 22:33:17 -05:00
Michael Davis 8969e98819
bazel: Comment out `assert_suites` checks for apps with missing suites
`rabbitmq_management` is missing one suite definition and `rabbit_mqtt`
is missing two. `assert_suites` causes a build failure because of the
missing suites. This change comments out `assert_suites` for these apps
instead of adding the missing suite definitions because Bazel is no
longer used to test these apps.
2025-01-28 16:12:12 -05:00
Michael Klishin cb81bb944a
HTTP API: add two new health checks, references #13153 2025-01-28 14:38:51 -05:00
Karl Nilsson 7862c2f501
Merge pull request #12713 from rabbitmq/ra-2.16.0
Ra v2.16.0
2025-01-28 16:00:08 +01:00
David Ansari 579c58603e Support AMQP over WebSocket (OSS part) 2025-01-27 17:50:47 +01:00
Karl Nilsson f2b1f37331 QQ: Use new log_ext effect
This offloads the work of reading messages from on-disk segments
to the interacting process rather than doing this blocking, performance
affecting work in the ra server process.

QQ: ensure opened segments are closed after some time of inactivity

Processes that havea received messages that had to be read from disks
may keep a segment open indefinitely. This introduces a timer which
after some time of inactivity will close all opened segments to ensure
file descriptors are not kept open indefinitely.
2025-01-27 13:50:38 +00:00
David Ansari 99782120f7 Highlight busy incoming links
Visualise busy links from publisher to RabbitMQ. If the link credit
reaches 0, we set a yellow background colour in the cell.
Note that these credit values can change many times per second while the
management UI refreshes only every few seconds. However, it may still
give a user an idea of what links are currently busy.

We use yellow since that's consistent with the `flow` state in AMQP
0.9.1, which is also set to yellow.

We do not want want to highlight **outgoing** links with credit 0 as
that might be a paused consumer, and therefore not a busy link.

We also use yellow background color if incoming-window is 0 (in case of
a cluster wider memory or disk alarm) or if remote-incoming-window is 0
as consumers should try to keep their incoming-window open and instead
use link credit if they want to pause consumption.

Additionaly we set a grey background colour for the `/management`
address just to highlight them slightly since these are "special" link
pairs.
2025-01-17 14:40:43 +01:00
Jean-Sébastien Pédron 57ed962ef6
rabbitmq_ct_helpers: Fix how we set `$RABBITMQ_FEATURE_FLAGS` in tests
[Why]
In order to make `khepri_db` the default in the future, the handling of
`$RABBITMQ_FEATURE_FLAGS` had to be adapted to be able to *disable*
Khepri instead.

Unfortunately I broke the behavior with stable feature flags that are
only available in the primary umbrella. In this case, they were
automatically enabled and thus, clustering with an old umbrella that did
not have these feature flags failed with `incompatible_feature_flags`.

[How]
The solution is to always use an absolute list of feature flags, not the
new relative list.

V2: Allow a testsuite to skip the configuration of the metadata store.
    This is needed for the feature_flags_SUITE testsuite because it
    tests the default behavior and the configuration of the metadata
    store changes that behavior.

    While here, fix a ct log message where variables were swapped
    compared to the format strieg expectation.

V3: Enable `rabbitmq_4.0.0` feature flag in rabbit_mgmt_http_SUITE. This
    testsuite apparently requires it and if it's not enabled, it fails.
2025-01-15 20:43:41 +01:00
Michael Klishin ad906c9786
HTTP API: make GET /api/aliveness-test a no-op
This follows the decision that was made for
'rabbitm-diagnostics node_health_check' which
is a no-op as of 4.0.0 following a few years of
deprecation.

The justification is very similar:

1. There is no such thing as "One True Health Check".
   A single health check is too coarse-grained to
   explain what specifically is not right about
   cluster state
2. Indivual fine-grained health checks have been
   available for a few years now, see
   https://www.rabbitmq.com/docs/monitoring#health-checks
3. This particular check tests something that
   effectively never fails, based on my 14+
   years of RabbitMQ contributions and user support
   of all shapes and forms
4. This check uses a deprecated feature: non-exclusive
   non-durable/transient classic queues

If something about this health check is worth
preserving, we can always add a new one
under GET /api/health/checks/*

Closes #13047.
2025-01-10 22:04:18 -05:00
Michael Klishin 2dce5e7302
HTTP API reference: remove one more duplicate sentence 2025-01-08 22:20:24 -05:00
Michael Klishin fa00423fe5
HTTP API reference: remove duplicate sentences 2025-01-08 22:19:29 -05:00
Michael Klishin 9359a3aaf5
HTTP API reference: updates for 4.0.x
Closes #13042
2025-01-08 22:11:04 -05:00
Michael Klishin 9b1422e8f1
HTTP API reference: a follow-up to #13037 2025-01-07 20:35:11 -05:00
Michael Klishin 48aa250006
HTTP API reference: fix a typo 2025-01-07 19:27:27 -05:00
Michael Klishin bcb080179c
Improve documentation of certain health checks
in the HTTP API documentation reference
as well as one CLI command that apparently
needed a clarification.
2025-01-07 18:48:39 -05:00
GitHub fce1f945c9 bazel run gazelle 2025-01-04 04:02:49 +00:00
Michael Klishin faa4f5a025
One more integration test for #13015 2025-01-03 19:33:24 -05:00
Michael Klishin 315c247231
Make sure protected_from_deletion is included into virtual host definitions exported over the HTTP API 2025-01-03 18:49:11 -05:00
Michal Kuratczyk 9ef226e571
MGMT UI: display deletion protection in vhost details 2025-01-03 11:54:49 +01:00
Michael Klishin 3f5b13d47f
Merge branch 'main' into mk-virtual-host-protection-from-accidental-deletion 2025-01-02 17:01:54 -05:00
Michael Klishin f62d46c286
Introduce a way to protect a virtual host from deletion
Accidental "fat finger" virtual deletion accidents
would be easier to avoid if there was a protection mechanism
that would apply equally even to CLI tools and external
applications that do not use confirmations for deletion
operations.

This introduce the following changes:

 * Virtual host metadata now supports a new queue,
   'protected_from_deletion', which, when set,
   will be considered by key virtual host deletion function(s)
 * DELETE /api/vhosts/{name} was adapted to handle
   such blocked deletion attempts to respond with
   a 412 Precondition Failed status
 * 'rabbitmqctl list_vhosts' and 'rabbitmqctl delete_vhost'
   were adapted accordingly
 * DELETE /api/vhosts/{name}/deletion/protection
   is a new endpoint that can be used to remove
   the protective seal (the metadata key)
 * POST /api/vhosts/{name}/deletion/protection
   marks the virtual host as protected

In the case of the HTTP API, all operations on
virtual host metadata require administrative
privileges from the target user.

Other considerations:

 * When a virtual host does not exist, the behavior
  remains the same: the original, protection-unaware
  code path is used to preserve backwards compatibility

References #12772.
2025-01-02 16:50:51 -05:00
Michael Klishin 968eefa1bb
Bump (c) line year
There are no functional changes to this massive diff.
2025-01-01 17:54:10 -05:00
Michael Klishin 1cae417dbf
Merge pull request #12821 from rabbitmq/rabbitmq-server-12776
Definition export: inject default queue type into virtual host metadata
2024-11-27 14:53:25 -05:00
Michael Klishin 8a5ea76fe4
Inject DQT into 'ctl export_definitions' 2024-11-27 12:29:48 -05:00
Michael Klishin dd408a46d9
Single virtual host definition export: export the entire metadata map 2024-11-27 11:51:26 -05:00