Commit Graph

52220 Commits

Author SHA1 Message Date
Michael Klishin 0a8dd19434
Cosmetics
(cherry picked from commit 042725d8364bac3fed40df4dcdb534728dd56576)
2023-01-02 07:15:58 -05:00
Michael Klishin 1020958399
Merge pull request #6783 from rabbitmq/mk-c-year-2023
(c) year bump: 2022 => 2023
2023-01-02 16:15:07 +04:00
Michael Klishin ec4f1dba7d
(c) year bump: 2022 => 2023 2023-01-01 23:17:36 -05:00
Michael Klishin 4ee60d6a6e
Merge pull request #6780 from dentarg/mgmt/escape-error-param
Management UI: escape the user controlled error parameter
2022-12-30 20:17:57 +04:00
Patrik Ragnarsson 29d3a0e0d4 Escape the user controlled error parameter 2022-12-30 12:48:55 +01:00
Michael Klishin 2835e38e1f
Merge pull request #6767 from rabbitmq/dependabot/github_actions/main/actions/cache-3.2.2
Bump actions/cache from 3.2.1 to 3.2.2
2022-12-28 11:33:09 +04:00
dependabot[bot] 95dcde644c
Bump actions/cache from 3.2.1 to 3.2.2
Bumps [actions/cache](https://github.com/actions/cache) from 3.2.1 to 3.2.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.2.1...v3.2.2)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-27 18:04:48 +00:00
Michael Klishin 291befadab
Merge pull request #6761 from rabbitmq/lukebakken/recon-2.5.3 2022-12-24 11:59:47 +04:00
Luke Bakken f56557a53c
Pin to recon 2.5.3
https://github.com/ferd/recon/issues/102

Huzzah!
2022-12-23 11:13:40 -08:00
Michael Klishin 169e2a430a
Merge pull request #6757 from rabbitmq/dependabot/github_actions/main/actions/cache-3.2.1 2022-12-23 22:10:42 +04:00
dependabot[bot] df5d8cf706
Bump actions/cache from 3.2.0 to 3.2.1
Bumps [actions/cache](https://github.com/actions/cache) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.2.0...v3.2.1)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-23 18:05:12 +00:00
Michal Kuratczyk 5aaf212c7a
Merge pull request #6738 from rabbitmq/coordinator-quorum-check
Check if stream coordinator is quorum critial
2022-12-22 18:21:07 +01:00
Michal Kuratczyk 44ed4eb340
Make a test less flaky; formatting 2022-12-22 14:59:47 +01:00
Michal Kuratczyk 4160dac33e
Check if stream coordinator is quorum critial 2022-12-22 10:02:13 +01:00
Michael Klishin 0f96f21be1
Link to Bazel guide in CONTRIBUTING.md 2022-12-22 01:33:37 +04:00
Michael Klishin ed687118a2
Merge pull request #6740 from rabbitmq/bazel-6-mixed-version-tests
Fix Bazel 6 compatibility for tests
2022-12-22 00:08:34 +04:00
Alexey Lebedeff b51304d233 Bazel 6 compatibility
Directory name for tools in runfiles is a bit unpredictable. Maybe
there is a better way, but at least this should cover all the cases
that I've observed.

One unexpected consequence is that this directory name can contains `~`,
and it's not being properly escaped in `ct:pal` calls (causing
badarg's for `io:format/4`.
2022-12-21 20:40:24 +01:00
Michael Klishin 9d645977e0
Merge pull request #6739 from rabbitmq/ra-2.4.6
Ra 2.4.6
2022-12-21 23:30:23 +04:00
Michael Klishin 2e8aec0b19
Merge pull request #6741 from rabbitmq/dependabot/github_actions/main/actions/cache-3.2.0 2022-12-21 22:12:24 +04:00
dependabot[bot] 7d302c80bb
Bump actions/cache from 3.0.11 to 3.2.0
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.11 to 3.2.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.0.11...v3.2.0)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-21 18:05:21 +00:00
Karl Nilsson b1de79c9e0 Ra 2.4.6
This release includes improvements for paths containing unicode characters
and a stale read fix for the `ra:consistent_read/2` function.
2022-12-21 15:16:17 +00:00
Michael Klishin 8ea8253bfc
Merge pull request #6727 from rabbitmq/bump-otp-25.2
Adopt otp 25.2
2022-12-21 15:43:27 +04:00
Michael Klishin 26fa97447a
Merge pull request #6726 from rabbitmq/bump-otp-25.1
Adopt otp 25.1.2
2022-12-21 15:43:16 +04:00
Michael Klishin 2b071c6db8
Merge pull request #6725 from rabbitmq/bump-otp-25.0
Adopt otp 25.0.4
2022-12-21 15:43:07 +04:00
Michael Klishin 46100536e2
Merge pull request #6724 from rabbitmq/bump-elixir-1.13
Adopt elixir 1.13.4
2022-12-21 15:42:59 +04:00
GitHub 6c775037c6 Adopt otp 25.2 2022-12-21 03:11:28 +00:00
GitHub f68b7a36af Adopt otp 25.1.2 2022-12-21 03:06:30 +00:00
GitHub d14a26bfd0 Adopt otp 25.0.4 2022-12-21 03:04:50 +00:00
GitHub ec4ce0ac17 Adopt elixir 1.13.4 2022-12-21 03:04:28 +00:00
Michael Klishin 2ceb0b6694
Merge pull request #6719 from cloudamqp/badrpc_listeners
Don't crash listing listeners when a node is shutting down
2022-12-21 00:42:01 +04:00
Péter Gömöri d42f7c6641 Don't crash listing listeners when a node is shutting down
Previously a management api request could crash as below while the overview
page was open during a node restart.

```
crasher:
  initial call: cowboy_stream_h:request_process/3
  pid: <0.1902.0>
  registered_name: []
  exception error: bad argument
    in operator  ++/2
       called as {badrpc,
                  {'EXIT',
                   {badarg,
                    [{ets,match_object,
                      [rabbit_listener_ets,'_'],
                      [{error_info,
                        #{cause => id,module => erl_stdlib_errors}}]},
                     {ets,tab2list,1,[{file,"ets.erl"},{line,771}]}]}}}
                 ++
                 [{listener,'rabbit@<hostname>',http,
                      "<hostname>",
                      {0,0,0,0,0,0,0,0},
                      15672,
                      [{cowboy_opts,[{sendfile,false}]},
                       {ip,"0.0.0.0"},
                       {port,15672},
                       {ssl,false}]},
...
    in call from lists:append/1 (lists.erl, line 155)
    in call from rabbit_mgmt_wm_overview:listeners/0 (rabbit_mgmt_wm_overview.erl, line 111)
    in call from rabbit_mgmt_wm_overview:to_json/2 (rabbit_mgmt_wm_overview.erl, line 66)
    in call from cowboy_rest:call/3 (src/cowboy_rest.erl, line 1575)
    in call from cowboy_rest:set_resp_body/2 (src/cowboy_rest.erl, line 1464)
    in call from cowboy_rest:upgrade/4 (src/cowboy_rest.erl, line 284)
    in call from cowboy_stream_h:execute/3 (src/cowboy_stream_h.erl, line 300)
```
2022-12-20 21:01:24 +01:00
Michael Klishin 4fa5d1cc69
Merge pull request #6708 from rabbitmq/lukebakken/preserve-heartbeat-error
Preserve heartbeat error reason
2022-12-20 23:25:15 +04:00
Michael Klishin dc14942a2f
Merge pull request #6704 from SimonUnge/bazel-minor-updates
Bazel minor updates
2022-12-20 23:23:48 +04:00
Michael Klishin cf16b2f28c
Merge pull request #6707 from lukebakken/lukebakken/recon-master
Pin recon to master
2022-12-20 23:09:55 +04:00
Luke Bakken 943668c9b1 pin recon to cf5bfc290c6cdd46bea45ae4a6418e9802d511e5 2022-12-20 18:32:39 +00:00
Michael Klishin f97786456f
Merge pull request #6695 from rabbitmq/rin/use-rules_erlang-3.8.5
Use rules_erlang 3.8.5
2022-12-20 22:31:33 +04:00
Luke Bakken c7ea2fb92e
Preserve heartbeat error reason
https://groups.google.com/g/rabbitmq-users/c/gRURlk9E6M0

In the above thread, the user experienced a heartbeat send timeout that
was logged as `{inet_error, timeout}`. The only way to know this was
related to heartbeats was to reproduce the issue and do a debug trace.
After this change, the error message will be as follows:

```
2022-12-20 08:57:12.614470-08:00 [error] <0.959.0> closing AMQP connection <0.959.0> (127.0.0.1:52052 -> 127.0.0.1:5672):
2022-12-20 08:57:12.614470-08:00 [error] <0.959.0> {inet_error,{heartbeat_send_error,timeout}}
```

I grepped the code for cases where `inet_error` is caught. The one place
where this happens is compatible with the change in this patch.
2022-12-20 09:10:41 -08:00
Simon Unge 03ddcce844 See #6703. Add consumer_timeout default 2022-12-20 15:26:14 +01:00
Simon Unge 5a7c4d6556 See #6703. Add rabbit-queues target 2022-12-20 15:26:13 +01:00
Michael Klishin 03eb5fc7f5
Merge pull request #6698 from rabbitmq/rebalance-stream-man
Add `rabbitmq-queues rebalance stream` to the man page
2022-12-19 18:38:21 +04:00
Jean-Sébastien Pédron 71309f76f6
Merge pull request #6694 from rabbitmq/fix-rabbit_ff_controller-log-message
rabbit_feature_flags: Fix log message in rabbit_ff_controller
2022-12-19 14:36:02 +01:00
Rin Kuryloski 3db02f7f9f Update `//:test-logs` and `//:test-node-data`
to handle the new ct_logdir flag
2022-12-19 13:49:07 +01:00
Jean-Sébastien Pédron cf239b5dc7
rabbit_feature_flags: Fix log message in rabbit_ff_controller
If the RPC call failed, the log message used `?MODULE` instead of the
actually called module.
2022-12-19 12:38:12 +01:00
Rin Kuryloski e799daa24e Use rules_erlang 3.8.5 2022-12-19 11:16:04 +01:00
Michal Kuratczyk e203dd8615
Add `rabbitmq-queues rebalance stream` to the man page 2022-12-19 10:50:40 +01:00
Jean-Sébastien Pédron e5839053a9
rabbit_db_vhost: Fix typo in `vhost:tag()` type 2022-12-18 19:28:39 +01:00
Michael Klishin db0f54c002
Merge pull request #6687 from amazon-mq/default-operator-policies
Parse and apply default_policies.operator
2022-12-17 03:57:17 +04:00
Alex Valiushko e07ed47d83 Parse and apply default_policies.operator
Example:

  default_policies.operator.policy-name.vhost_pattern = ^device
  default_policies.operator.policy-name.queue_pattern = .*
  default_policies.operator.policy-name.max_length_bytes = 1GB
  default_policies.operator.policy-name.max_length = 1000000
2022-12-16 10:25:30 -08:00
Michael Klishin 366527ff43
Merge pull request #6690 from rabbitmq/small-stream-name-tweak
Remove redundant binary_to_list/1 call
2022-12-16 19:24:29 +04:00
Karl Nilsson 56e41668eb Remove redundant list_to_binary/1 call
When creating the internal stream id. Modern versions of osiris can handle
binary names just fine.
2022-12-16 14:34:10 +00:00