Commit Graph

341 Commits

Author SHA1 Message Date
Philip Kuryloski 8f9de08de7 Also assert no missing suites for all other deps 2021-07-12 18:05:55 +02:00
Philip Kuryloski 30f9a95b9f Add dialyze for remaning tier-1 plugins 2021-06-01 10:19:10 +02:00
Philip Kuryloski a6f70b8dda Add xref for remaining tier-1 plugins 2021-05-25 11:39:03 +02:00
Michael Klishin 040f8cc912
Replace a few more leftover MPLv1.1 license headers
Most files have been using the MPLv2 headers for months now.
These were detected by the OSL process.
2021-05-19 21:20:47 +03:00
Philip Kuryloski e6df6615e1 Futher bazel file refactoring and deduplication 2021-05-11 16:15:33 +02:00
Philip Kuryloski 59f0076b0b Add rabbitmq_tracing to bazel 2021-05-07 09:45:53 +02:00
Philip Kuryloski a63f169fcb Remove duplicate rabbitmq-components.mk and erlang.mk files
Also adjust the references in rabbitmq-components.mk to account for
post monorepo locations
2021-03-22 15:40:19 +01:00
kjnilsson 52f745dcde Update rabbitmq-components.mk
use v1.x branch of ra
2021-03-18 15:14:40 +00:00
Loïc Hoguin d5e3bdd623
Add ADDITIONAL_PLUGINS variable
This allows including additional applications or third party
plugins when creating a release, running the broker locally,
or just building from the top-level Makefile.

To include Looking Glass in a release, for example:

$ make package-generic-unix ADDITIONAL_PLUGINS="looking_glass"

A Docker image can then be built using this release and will
contain Looking Glass:

$ make docker-image

Beware macOS users! Applications such as Looking Glass include
NIFs. NIFs must be compiled in the right environment. If you
are building a Docker image then make sure to build the NIF
on Linux! In the two steps above, this corresponds to Step 1.

To run the broker with Looking Glass available:

$ make run-broker ADDITIONAL_PLUGINS="looking_glass"

This commit also moves Looking Glass dependency information
into rabbitmq-components.mk so it is available at all times.
2021-03-12 12:29:28 +01:00
Michael Klishin 97ff62d3b2
Drop trailing newlines from logged messages where possible
Lager strips trailing newline characters but OTP logger with the default
formatter adds a newline at the end. To avoid unintentional multi-line log
messages we have to revisit most messages logged.

Some log entries are intentionally multiline, others
are printed to stdout directly: newlines are required there
for sensible formatting.
2021-03-11 15:17:37 +01:00
Jean-Sébastien Pédron cdcf602749
Switch from Lager to the new Erlang Logger API for logging
The configuration remains the same for the end-user. The only exception
is the log root directory: it is now set through the `log_root`
application env. variable in `rabbit`. People using the Cuttlefish-based
configuration file are not affected by this exception.

The main change is how the logging facility is configured. It now
happens in `rabbit_prelaunch_logging`. The `rabbit_lager` module is
removed.

The supported outputs remain the same: the console, text files, the
`amq.rabbitmq.log` exchange and syslog.

The message text format slightly changed: the timestamp is more precise
(now to the microsecond) and the level can be abbreviated to always be
4-character long to align all messages and improve readability. Here is
an example:

    2021-03-03 10:22:30.377392+01:00 [dbug] <0.229.0> == Prelaunch DONE ==
    2021-03-03 10:22:30.377860+01:00 [info] <0.229.0>
    2021-03-03 10:22:30.377860+01:00 [info] <0.229.0>  Starting RabbitMQ 3.8.10+115.g071f3fb on Erlang 23.2.5
    2021-03-03 10:22:30.377860+01:00 [info] <0.229.0>  Licensed under the MPL 2.0. Website: https://rabbitmq.com

The example above also shows that multiline messages are supported and
each line is prepended with the same prefix (the timestamp, the level
and the Erlang process PID).

JSON is also supported as a message format and now for any outputs.
Indeed, it is possible to use it with e.g. syslog or the exchange. Here
is an example of a JSON-formatted message sent to syslog:

    Mar  3 11:23:06 localhost rabbitmq-server[27908] <0.229.0> - {"time":"2021-03-03T11:23:06.998466+01:00","level":"notice","msg":"Logging: configured log handlers are now ACTIVE","meta":{"domain":"rabbitmq.prelaunch","file":"src/rabbit_prelaunch_logging.erl","gl":"<0.228.0>","line":311,"mfa":["rabbit_prelaunch_logging","configure_logger",1],"pid":"<0.229.0>"}}

For quick testing, the values accepted by the `$RABBITMQ_LOGS`
environment variables were extended:
  * `-` still means stdout
  * `-stderr` means stderr
  * `syslog:` means syslog on localhost
  * `exchange:` means logging to `amq.rabbitmq.log`

`$RABBITMQ_LOG` was also extended. It now accepts a `+json` modifier (in
addition to the existing `+color` one). With that modifier, messages are
formatted as JSON intead of plain text.

The `rabbitmqctl rotate_logs` command is deprecated. The reason is
Logger does not expose a function to force log rotation. However, it
will detect when a file was rotated by an external tool.

From a developer point of view, the old `rabbit_log*` API remains
supported, though it is now deprecated. It is implemented as regular
modules: there is no `parse_transform` involved anymore.

In the code, it is recommended to use the new Logger macros. For
instance, `?LOG_INFO(Format, Args)`. If possible, messages should be
augmented with some metadata. For instance (note the map after the
message):

    ?LOG_NOTICE("Logging: switching to configured handler(s); following "
                "messages may not be visible in this log output",
                #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),

Domains in Erlang Logger parlance are the way to categorize messages.
Some predefined domains, matching previous categories, are currently
defined in `rabbit_common/include/logging.hrl` or headers in the
relevant plugins for plugin-specific categories.

At this point, very few messages have been converted from the old
`rabbit_log*` API to the new macros. It can be done gradually when
working on a particular module or logging.

The Erlang builtin console/file handler, `logger_std_h`, has been forked
because it lacks date-based file rotation. The configuration of
date-based rotation is identical to Lager. Once the dust has settled for
this feature, the goal is to submit it upstream for inclusion in Erlang.
The forked module is calld `rabbit_logger_std_h` and is based
`logger_std_h` in Erlang 23.0.
2021-03-11 15:17:36 +01:00
dcorbacho 61f7b2a723 Update to ranch 2.0 2021-03-08 23:11:05 +01:00
Michael Klishin b6c4831e75
Bump Lager to 3.9.1 2021-03-04 04:36:39 +03:00
Loïc Hoguin 66ac1bf5e9
Bump observer_cli to 1.6.1
More responsive when the system is overloaded with file calls.
2021-03-01 21:55:27 +03:00
Michael Klishin 8fe3df9343
Upgrade Lager to 3.9.0 for OTP 24 compatibility
`lager_util:expand_path/1` use changes are
due to erlang-lager/lager#540
2021-02-26 00:52:15 +03:00
Michael Klishin f73e851f9c
Bump observer_cli to 1.6.0 2021-02-24 12:53:55 +03:00
Michael Klishin a5098b28a7
Bump Lager to 3.8.2 for OTP 24 compatibility 2021-02-24 12:53:30 +03:00
Arnaud Cogoluègnes b921ac11a8
Merge pull request #2712 from rabbitmq/rabbitmq-stream-prometheus
Add stream prometheus plugin
2021-01-27 16:46:37 +01:00
Michael Klishin 52479099ec
Bump (c) year 2021-01-22 09:00:14 +03:00
Arnaud Cogoluègnes bf72683eb2
Add stream prometheus plugin 2021-01-11 16:49:56 +01:00
Arnaud Cogoluègnes 23d7e8114c
Introduce stream management plugin 2020-11-19 14:48:25 +01:00
Jean-Sébastien Pédron 47686ee1f0
Remove unused .github directories
They were valid until the switch to the "monorepository" when everything
was merged into a single Git repository.
2020-11-17 13:33:16 +01:00
Arnaud Cogoluègnes 3751bc6eb7 Update rabbitmq-components.mk 2020-11-03 14:27:51 +01:00
Michael Klishin 7c9be099ac Update rabbitmq-components.mk 2020-10-21 12:55:47 +03:00
Luke Bakken d25cc774ee Update rabbitmq-components.mk 2020-08-04 08:41:50 -07:00
Jean-Sébastien Pédron 1a5228a032 Update rabbitmq-components.mk 2020-07-30 12:06:58 +02:00
Luke Bakken 21ba3217d3 Update rabbitmq-components.mk 2020-07-29 10:02:06 -07:00
dcorbacho 9639868f1f Update erlang.mk 2020-07-21 14:34:02 +01:00
Michael Klishin b7b72357ea Update rabbitmq-components.mk 2020-07-21 13:12:56 +03:00
Michael Klishin cfb5ce48b0 Update rabbitmq-components.mk 2020-07-21 03:45:32 +03:00
dcorbacho 1fd04bfae9 Revert drop of Exhibit B on MPL 2.0 2020-07-20 17:04:47 +01:00
Michael Klishin ff7b21cd0b Switch to MPL2 2020-07-15 02:46:53 +03:00
Jean-Sébastien Pédron eac39a2718 Update erlang.mk 2020-06-23 17:15:47 +02:00
Michael Klishin 2d4cf62487 Update rabbitmq-components.mk 2020-06-10 19:51:23 +03:00
Jean-Sébastien Pédron 946bf7e87a Update copyright (year 2020) 2020-03-10 16:59:50 +01:00
Gerhard Lazu 01b25275a4 Update rabbitmq-components.mk 2020-03-06 09:19:21 +00:00
Gerhard Lazu 220f32dbd3 Update erlang.mk 2020-03-06 09:18:37 +00:00
Jean-Sébastien Pédron 32bbb63d07 Travis CI: Update config from rabbitmq-common 2020-03-04 14:24:32 +01:00
Jean-Sébastien Pédron cdf131c4a0 Travis CI: Update config from rabbitmq-common 2020-03-04 11:17:19 +01:00
Jean-Sébastien Pédron a06c7435e0 Travis CI: Update config from rabbitmq-common 2020-03-03 14:53:42 +01:00
Gerhard Lazu 66b6bf2d25 Update rabbitmq-components.mk 2020-02-11 15:31:50 +00:00
Luke Bakken 7c8248a7ed add GitHub templates 2020-02-03 08:43:22 -08:00
Michael Klishin 6586f1dec3 (c) bump 2019-12-29 05:50:37 +03:00
Jean-Sébastien Pédron ea550415db Git: Ignore copied CLI 2019-12-12 15:09:22 +01:00
Jean-Sébastien Pédron 5c72dd26f9 Update rabbitmq-components.mk 2019-12-12 13:14:59 +01:00
Luke Bakken cdb8037e16 Catch error when getting trace file info
On win32 systems, deleting a trace file from out under RabbitMQ will lead to subsequent `{error, eacces}` errors.

Fixes #31
2019-10-17 14:40:52 -07:00
kjnilsson 262f074734 Update rabbitmq-components.mk 2019-09-13 10:24:35 +01:00
kjnilsson 01c3c82cd9 Update rabbitmq-components.mk 2019-09-04 10:31:13 +01:00
Jean-Sébastien Pédron 241e448d27 Update erlang.mk 2019-08-29 20:46:06 +02:00
Michael Klishin 27392722be Update rabbitmq-components.mk 2019-08-11 01:48:11 +10:00