to prevent `amqp_connection:start/2` from logging a warning when we use default
values.
The default for `connection_timeout` is already 60000. When we don't explicitly
set it to a lower value, `amqp_connection:maybe_update_call_timeout/2` adjusts
it to 70000 and logs a warning message, which may appear unexpected, especially
for users upgrading to 3.8.10+ with no config changes.
This change addresses that problem by pre-adjusting it to 70000, making it safe
by default and ensuring our default values don't conflict with each other.
While not all suites strictly require it, those same suites depend on
it via the broker dependency anyway. Thus, there is no penalty, but it
shortens the BUILD.bazel file for deps/rabbit
Adds WORKSPACE.bazel, BUILD.bazel & *.bzl files for partial build & test with Bazel. Introduces a build-time dependency on https://github.com/rabbitmq/bazel-erlang
Lager strips trailing newline characters but OTP logger with the default
formatter adds a newline at the end. To avoid unintentional multi-line log
messages we have to revisit most messages logged.
Some log entries are intentionally multiline, others
are printed to stdout directly: newlines are required there
for sensible formatting.
operations. At some point, these have to timeout to
avoid having lingering connection processes attempting
remote connections under unstable conditions.
Improve handling of potential call timeout exceptions
in amqp_gen_connection.
establishment. This guarantees that the effective
call timeouts are always safe, i.e. granting enough
time to the underlying network operations, which must
always timeout first in case of any unexpected
lingering operations leading to timeouts. This eliminates
the chance of leaking connection processes when call
timeouts elapse, while underlying remote cconnection
establishment call was still taking place.
amqp_main_reader:post_init/1 is invoked within
amqp_gen_connection:connect/1 with a timeout of ?CALL_TIMEOUT, so the
same timeout interval cannot be reasonably for both
Specifically, handle and return the error resulting from
`ssl:controlling_process/2` when opening a connection
Also increase the timeout around `ssl:setopts/2` when opening a
connection to the global client timeout
Michal Kuratczyk
Philip Kuryloski
Michael Klishin
João Britto
Paweł Chmielowski
Michael Klishin
kjnilsson
Luke Bakken
Pawel Antemijczuk
Ayanda-D
Arnaud Cogoluègnes
dcorbacho
Jean-Sébastien Pédron
Luke Bakken