Commit Graph

49842 Commits

Author SHA1 Message Date
Arnaud Cogoluègnes 6aabfdbbb4
Format stream plugin 2021-10-20 14:53:08 +02:00
Alexey Lebedeff a3b02bd01c Fix persistent message count display in mgmt UI
Fixes #3396

As can be seen in
9cf18e83f2/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs (L171)
there should be 3 colums for a classic queue.

While it's possible to share the same field with the quorum queues
case, I did it this way so that conditions for the labels and for the
values will have the same shape.
2021-10-20 13:00:26 +02:00
Michael Klishin 9cf18e83f2
Merge branch 'RentTheRunway-falconertc/fix_duplicate_binding_exchange' 2021-10-19 23:04:42 +03:00
Michael Klishin 87325b09f7
Improve a comment 2021-10-19 23:03:47 +03:00
Loïc Hoguin 7e2a6ff328
Finalize 3.9.8 release notes 2021-10-19 22:59:44 +03:00
Michael Klishin 1e7df8c436
Merge pull request #3591 from rabbitmq/3.9.8-release-notes
Finalize 3.9.8 release notes
2021-10-19 12:50:00 +03:00
Michael Klishin f4bac62855
Finalize 3.9.8 release notes 2021-10-19 12:48:40 +03:00
Loïc Hoguin b8e6acc89a
Finalize 3.9.8 release notes 2021-10-19 12:45:31 +03:00
Falcon Taylor-Carter 43b10615be Fix binding deletion in duplicate-binding scenarios 2021-10-18 23:25:27 -04:00
Falcon Taylor-Carter 4dab02289d Add tests for duplicate binding scenarios 2021-10-18 23:25:06 -04:00
Michael Klishin e64c316716
Merge pull request #3586 from rabbitmq/declare-stream-with-node-down-fix
Declare stream with node down fix
2021-10-18 18:34:38 +03:00
Karl Nilsson 691de2bea4 Take all clustered nodes into account when declaring stream.
Deriving a max-cluster-size only from running nodes would create situations where
in a three-node with only two nodes running cluster it would select an non-running
node as follower.
2021-10-18 15:44:53 +01:00
Michael Klishin a0d0fbf904
Update 3.9.8 release notes 2021-10-18 14:37:07 +03:00
Michal Kuratczyk 115a868d55 More accurate wording in the release notes 2021-10-18 13:18:30 +02:00
Michal Kuratczyk 347b1857a4 Mention osiris hostname fix in the release notes 2021-10-18 12:36:21 +02:00
Michael Klishin b8583c1d67
Merge pull request #3584 from rabbitmq/dependabot/github_actions/actions/checkout-2.3.5
Bump actions/checkout from 2.3.4 to 2.3.5
2021-10-16 01:35:21 +03:00
dependabot[bot] 589a70788c
Bump actions/checkout from 2.3.4 to 2.3.5
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2.3.4...v2.3.5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-15 18:09:04 +00:00
Michael Klishin 4c2c4bc9b3
Merge pull request #3574 from rabbitmq/fix-stream-coordinator-log
Fix stream coordinator log message
2021-10-15 16:27:39 +03:00
Michael Klishin 732e72b0da
Merge pull request #3582 from luos/channel-q-pid-leak-fix-v39x
Fix an Erlang monitor leak when queue churn is high

(cherry picked from commit a78b76afcd)
2021-10-15 16:25:24 +03:00
Michael Klishin 45a654c929
Merge pull request #3579 from tvhong-amazon/tvhong/log_error
Log response body of failed AWS requests
2021-10-15 00:59:07 +03:00
Michael Klishin 2140562209
Merge pull request #3562 from rabbitmq/disable_stream_plugin_3557
Disable the stream_plugin if stream feature flag is not enabled
2021-10-14 18:45:26 +03:00
Michael Klishin 78e18afd57
Wording 2021-10-14 18:24:52 +03:00
Arnaud Cogoluègnes 6d0dc3f6b4
Attach add/delete super stream command to streams scope only
Not to ctl.

References #3503
2021-10-14 17:09:18 +02:00
Michael Klishin 2fbc5fab25
Formatting, wording 2021-10-14 17:20:59 +03:00
dcorbacho 5f1ec61b50 Fix stream coordinator log message 2021-10-14 11:14:41 +02:00
Arnaud Cogoluègnes 75b2a53f52
Merge pull request #3503 from rabbitmq/super-stream-cli
Add functions to create/delete super stream in manager
2021-10-14 11:01:58 +02:00
dcorbacho 141f95598e Handling of `stream_not_found` return value when init a stream client
This error probably shouldn't happen if the system is correct, however
`stream_not_found` is a valid return value for the functions called
- it comes from `register_listener`.
Not handling it causes a case_clause (and long stacktrace) that is sent
to the client as an internal error, instead of a known protocol error.
Seen while debugging another issue.
2021-10-13 17:51:00 +02:00
Michael Klishin c935f9c7fa
Merge pull request #3544 from rabbitmq/bump-otp-for-oci
Adopt otp 24.1.2 for OCI workflow
2021-10-13 18:49:06 +03:00
Karl Nilsson 3f667a3cb8 amqp10_client: make shutdown scenarios a bit less noisy
by handling specific EXIT and DOWN messages that may occur during
certain connection closure cases.
2021-10-13 14:30:46 +01:00
Michael Klishin 15116a60e9
Merge pull request #3570 from rabbitmq/lh-fix-memory_breakdown
Fix memory_breakdown for connection procs
2021-10-13 16:22:36 +03:00
Loïc Hoguin 0ee8a0612e
Fix memory_breakdown for connection procs
Instead of trying to read the ranch_server ETS table directly,
use an internal Ranch function that does the same. While neither
are documented, the latter is less likely to change.
2021-10-13 15:20:01 +02:00
Michael Klishin d48ed6dfb6
Merge pull request #3560 from rabbitmq/lh-fix-mandatory-flag
Fix memory leak when using mandatory flag in CQs
2021-10-13 16:16:31 +03:00
Loïc Hoguin 7ffb154787
Fix memory leak when using mandatory flag in CQs
MsgNo is defined for both mandatory flags and confirms,
but only confirms need to be kept track of in this module.
2021-10-13 14:13:56 +02:00
Michael Klishin 84b0ade5de
Merge pull request #3566 from rabbitmq/run-broker-more-plugin-ports
Allow having multiple `make run-broker` simulatneously
2021-10-13 13:39:59 +03:00
Michael Klishin d5b71e04b3
Merge pull request #3565 from rabbitmq/stream-queue-handle-unsupported-header-values
Stream queue: handle unsupported header value types
2021-10-13 13:17:10 +03:00
Gabriele Santomaggio f2df98aef9 change message 2021-10-13 12:01:21 +02:00
Gabriele Santomaggio 2eb625531d Disable the stream_plugin and stream management if the feature flag
is not enabled.
fixes https://github.com/rabbitmq/rabbitmq-server/issues/3557
2021-10-13 11:59:11 +02:00
Karl Nilsson 5520c6cafe Stream queue: handle unsupported header value types
As AMQP 0.9.1 headers are translated into AMQP 1.0 application properties
they are not able to contain complex values such as arrays or tables.

RabbitMQ federation does use array and table values so to avoid crashing when
delivering a federated message to a stream queue we drop them. These header values
should be considered internal however so dropping them before a final queue deliver should not be a huge problem.
2021-10-13 10:27:00 +01:00
Alexey Lebedeff 23be565a38 Allow having multiple `make run-broker` simulatneously
It was automatically happening for e.g. `make start-cluster`.

But some plugins were not covered by default generated config, and
running rabbit from 2 different worktrees was a bit complicated.
2021-10-13 10:52:02 +02:00
Michael Klishin 3826a0df25
Compile #3561 2021-10-13 01:27:16 +03:00
Michael Klishin 670f240537
Compile #3561 2021-10-12 20:17:51 +03:00
Gabriele Santomaggio c270ebf037 Disable the stream_plugin if the feature flag
is not enabled.
fixes https://github.com/rabbitmq/rabbitmq-server/issues/3557
2021-10-12 19:09:34 +02:00
Michael Klishin e087403e1a
Merge pull request #3554 from johanneswuerbach/expose-cluster-id
feat(prom): expose cluster id in identity
2021-10-12 17:48:46 +03:00
Johannes Würbach 84de860b4c
feat(prom): expose cluster id in identity 2021-10-12 15:43:46 +02:00
Gabriele Santomaggio 4ce920cac5
Merge pull request #3550 from rabbitmq/stream-queue-consumer-fix
Stream queue: use local pid for offset listeners
2021-10-12 14:43:14 +02:00
Arnaud Cogoluègnes 6b9589bae4
Handle stream arguments in add_super_stream command
max-age, leader-locator, etc.
2021-10-11 16:50:03 +02:00
Arnaud Cogoluègnes ecbd969834
Embed RPC call function in test 2021-10-11 16:50:02 +02:00
Arnaud Cogoluègnes 8ae60bef73
Fix group spec in test 2021-10-11 16:50:02 +02:00
Arnaud Cogoluègnes b0bd5f8a00
Add delete_super_stream CLI command 2021-10-11 16:50:02 +02:00
Arnaud Cogoluègnes a73b1a3d0d
Add add_super_stream CLI command 2021-10-11 16:50:01 +02:00