Commit Graph

4326 Commits

Author SHA1 Message Date
Michael Klishin 73188f4a26 An alternative to #10415, closes #10330
Per discussion in #10415, this introduces a new module,
rabbit_mgmt_nodes, which provides a couple of helpers
that can be used to implement Cowboy REST's
resource_exists/2 in the modules that return
information about cluster members.

(cherry picked from commit 0c0e2ca932)
2024-01-26 00:06:34 +00:00
Michael Klishin 5b4dc00bf1
Merge pull request #10245 from rabbitmq/mergify/bp/v3.12.x/pr-10243
Use correct user to test authentication via various messaging protocols (backport #10243)
2024-01-02 10:22:07 -05:00
Marcial Rosales 560ee42635 Do not expect permission check to create a queue
for the last-will feature given that MQTT plugin
in 3.12.x does not support that feature
2024-01-02 11:25:47 +01:00
Michael Klishin 8b26fdc510
(c) year bump 2024-01-01 22:04:04 -05:00
Ariel Otilibili dec52c68d4 Defined "tags" as list
Typo spotted in #4050

(cherry picked from commit 0b24d3c0bb)
2023-12-28 01:23:27 +00:00
Marcial Rosales 9dc66c01a1 Use correct user to authenticate
depending on the backend we want to
exercise

(cherry picked from commit b9f3771f2d)
2023-12-27 19:04:01 +00:00
Michael Klishin 795b0fa821
Selenium: update run-suites.sh argument to match #10200
(cherry picked from commit 5af5f0cf3d)
2023-12-23 20:54:39 -05:00
Marcial Rosales 49e93148a2 Clean up
(cherry picked from commit f3c4355cfb)
2023-12-24 00:11:44 +00:00
Marcial Rosales dae6061360 Propagate all credentials to http backend
(cherry picked from commit 2fc8d2b3ae)
2023-12-24 00:11:42 +00:00
Ariel Otilibili 04c68cb0ad Replaced true | false by boolean()
(cherry picked from commit e1d09fbba6)
2023-12-23 03:42:12 +00:00
Michael Klishin 685c4f6027
Resolve a conflict #10185 #10187 2023-12-20 04:40:09 -05:00
Michael Klishin 7042bc4864 Revert "HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call"
This reverts commit 78f901a224.

(cherry picked from commit 7ebaae7ef0)

# Conflicts:
#	deps/rabbitmq_management/src/rabbit_mgmt_wm_queue.erl
2023-12-20 09:37:59 +00:00
Péter Gömöri 68cea6bbec Prevent formatter crash in mgmt_util
`rabbit_mgmt_util:direct_request/6` is always called with an
`ErrorMsg` which expects one format argument as a string. Convert the
arbitrary reason term into a string to avoid a crash like the below:

```
warning: FORMATTER CRASH: {"Delete exchange error: ~ts",[{'EXIT',{{badmatch,{error,...
```

(cherry picked from commit 0a144e7698)
2023-12-20 04:12:36 +00:00
Péter Gömöri 6638fef533 Tolerate race condition when starting management db cache process
This prevents the below harmless crash when multiple parallel API
requests arrive soon after starting the node.

```
exception error: no match of right hand side value
                 {error,{already_started,<0.1593.0>}}
  in function  rabbit_mgmt_db_cache:fetch/4 (rabbit_mgmt_db_cache.erl, line 68)
  in call from rabbit_mgmt_db:submit_cached/4 (rabbit_mgmt_db.erl, line 756)
  in call from rabbit_mgmt_util:augment/2 (rabbit_mgmt_util.erl, line 412)
  in call from rabbit_mgmt_util:run_augmentation/2 (rabbit_mgmt_util.erl, line 389)
  in call from rabbit_mgmt_util:augment_resources0/6 (rabbit_mgmt_util.erl, line 378)
  in call from rabbit_mgmt_util:with_valid_pagination/3 (rabbit_mgmt_util.erl, line 302)
  in call from rabbit_mgmt_wm_queues:to_json/2 (rabbit_mgmt_wm_queues.erl, line 44)
  in call from cowboy_rest:call/3 (src/cowboy_rest.erl, line 1583)
```

(cherry picked from commit f4a9edfd2f)
2023-12-19 19:19:22 +00:00
David Ansari b385e87d46 Fix crash when closing connection
Avoid the following crash
```
** Reason for termination ==
** {mqtt_unexpected_cast,{shutdown,"Closed via management plugin"}}

  crasher:
    initial call: rabbit_mqtt_reader:init/1
    pid: <0.1096.0>
    registered_name: []
    exception exit: {mqtt_unexpected_cast,
                        {shutdown,"Closed via management plugin"}}
      in function  gen_server:handle_common_reply/8 (gen_server.erl, line 1208)
```
when closing MQTT or Stream connections via HTTP API endpoint
```
/connections/username/:username
```

(cherry picked from commit f44c851293)
2023-12-14 13:02:57 +00:00
Michael Klishin 898510724d Definition import: more logging improvements
(cherry picked from commit 26aa534e40)
2023-12-10 03:14:16 +00:00
Michael Klishin e8325976f8 Another take at #10068
Scan queues, exchanges and bindings before attempting
to import anything on boot. If they miss the virtual
host field, fail early and log a sensible message.

(cherry picked from commit 62fffb6634)
2023-12-10 03:14:14 +00:00
Michael Klishin 45bcd1a18c Fixes #9983
(cherry picked from commit cc3084dfbf)
2023-11-26 01:07:06 +00:00
Michael Klishin 7273e29621
Update (c) according to [1]
1. https://investors.broadcom.com/news-releases/news-release-details/broadcom-and-vmware-intend-close-transaction-november-22-2023
2023-11-21 23:26:04 -05:00
Michael Klishin 1e7c669f24 Management UI: link to GitHub Discussions and not the Google group
(cherry picked from commit 28ad76467e)
2023-11-19 19:36:03 -05:00
Emerson Almeida aebc8981d3 remove test to idp-initiated
(cherry picked from commit 9c87e1902d)
2023-11-01 20:34:52 +00:00
Emerson Almeida 29ee632899 make the baseUrl equal when run with prefix
(cherry picked from commit 64ded4632d)
2023-11-01 20:34:52 +00:00
Duke f5a59fa3c1 move store pref to startWithOAuthLogin
(cherry picked from commit cd680bc568)
2023-11-01 20:34:52 +00:00
Duke 3c79d5f2b4 Remove overview var from redirection-after-login.js
(cherry picked from commit 9060941fc2)
2023-11-01 20:34:52 +00:00
Duke 02b7a03311 remove unused overview var
(cherry picked from commit 0e757f394a)
2023-11-01 20:34:52 +00:00
Emerson Almeida 01730a8ea7 fix pref default
(cherry picked from commit 7bf452c522)
2023-11-01 20:34:52 +00:00
Emerson Almeida ba2cdec188 add tests
(cherry picked from commit 7525ccc236)
2023-11-01 20:34:52 +00:00
Duke c675204767 add oauth-return-to
(cherry picked from commit 3e0ca9ede7)
2023-11-01 20:34:51 +00:00
Marcial Rosales 843f6eb599 Reduce by 5 seconds every oauth2 test
clickToLogin sbould only check that the
login button exists and not that the
warning messages is not visible

(cherry picked from commit 7c58649942)
2023-10-31 16:06:43 +00:00
Marcial Rosales 2e1e1e463b Bump up chromedriver version
(cherry picked from commit b409d97927)
2023-10-31 16:06:43 +00:00
Marcial Rosales cadb1154af Fix issue in run-scripts
(cherry picked from commit c169f6ef50)
2023-10-31 16:06:42 +00:00
Karl Nilsson 9abbed63ab Actually nack when using 'Nack message requeue true'
Option in mgmt UI.

(cherry picked from commit 1ba62a90f2)
2023-10-17 14:50:00 +00:00
Michael Klishin e6eb78b480 HTTP API: adapt publishing tests
to take the newly introduced 10 MiB default body size limit
into account.

(cherry picked from commit 087794dded)
2023-10-17 01:50:46 +00:00
Michael Klishin 6d8a4ead2c Reduce default HTTP API request body size limit to 10 MiB
per discussion with the team.

It should be enough to accomodate a definition file with about
100K queues.

(cherry picked from commit c6d0382be4)
2023-10-17 01:50:46 +00:00
Michael Klishin 0de73e5f3f Introduce HTTP request body limit for definition uploads
The default is 20 MiB, which is enough to upload
a definition file with 200K queues, a few virtual host
and a few users. In other words, it should accomodate
a lot of environments.

(cherry picked from commit b7b3514bb1)
2023-10-17 01:50:45 +00:00
Michael Klishin 4a0f995c9a Add length limit overflow behavior to supported features in the UI
(cherry picked from commit aa0c52093f)
2023-10-06 00:42:07 -04:00
Michael Klishin 86edb49aff HTTP API docs: be more specific
(cherry picked from commit 8ca0200503)
2023-09-28 10:03:10 +00:00
Diana Parra Corbacho cbd699f608 HTTP API: document disable_stats and enable_queue_totals
Using GET /api/queues?disable_stats=true&enable_queue_totals=true is far more efficient than the standard GET /api/queues and in many cases will suffice for monitoring and operating purposes.

(cherry picked from commit 9d8a537073)
2023-09-28 10:03:09 +00:00
Diana Parra Corbacho a304c188a6 HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call
A direct client operation fails if the queue is exclusive. This
API should behave like the rabbitmqctl that can delete the queue
even in that case

(cherry picked from commit 78f901a224)
2023-09-27 06:56:50 +00:00
Jean-Sébastien Dominique 24797c5a12 Add Classic Queue version to operator policies
(cherry picked from commit 8c6ba6daca)
2023-09-27 01:01:47 +00:00
Diana Parra Corbacho b3cbbcae73 mgmt UI admin page: list all operator policies per queue type
(cherry picked from commit cbf479f1a9)
2023-09-26 23:33:29 +00:00
Marcial Rosales 1ba09544a0 Run full manaegement ui suite by default
(cherry picked from commit 54ff3273ab)
2023-09-05 20:51:53 +00:00
Marcial Rosales b46c25c308 Refactor suites to shorten pipeline execution
- Separate pure management ui suites from authnz
- Run full management ui suite on every commit to main or
 release brances
 - Fun full management ui suite on every change done to
 rabbitmq_management plugin on any PR

(cherry picked from commit 7fb55881a4)
2023-09-05 20:51:52 +00:00
Michael Klishin 525b9bbf1e Resolve a conflict (#9156) 2023-08-23 12:58:08 +04:00
Simon Unge 922e769bcc Disable add/delete/shrink/grow QQ operations via HTTP api
(cherry picked from commit 2d74d24b80)

# Conflicts:
#	deps/rabbitmq_management/src/rabbit_mgmt_features.erl
2023-08-23 08:24:42 +00:00
Marcial Rosales 05f885edf6 Fix wrong config
(cherry picked from commit 1e74490412)
2023-08-15 08:48:50 +00:00
Marcial Rosales c3ee4e5a6d Fix #9043
(cherry picked from commit dbffccba9d)
2023-08-15 08:48:50 +00:00
Arnaud Cogoluègnes 491a159bdd Document stream management plugin endpoints
Fixes #8751

(cherry picked from commit d0a6efc1c9)
2023-07-13 15:57:30 +00:00
antsthebul 2cdf8a16aa Set max height value for popup, as to not conlfict with smaller length popups
(cherry picked from commit 4ebc3244f0)
2023-07-02 15:47:59 +00:00
antsthebul d3468a182b Adjust CSS on Popup box
(cherry picked from commit b8f65083d1)
2023-07-02 15:47:59 +00:00