Commit Graph

332 Commits

Author SHA1 Message Date
Arnaud Cogoluègnes 8941223fce Fix link to exchange details 2019-07-22 11:57:15 +02:00
Michael Klishin 8e433df6ac Cosmetics 2019-07-22 11:46:31 +03:00
Michael Klishin 84539f3672 Highlight leading and trailing ws individually
Instead of replacing the entire group of characters
with a single block.

While at it, highlight all tab spaces separately,
even in the middle. Unlike spaces, tabs in the middle
of a name were likely used by mistake.
2019-07-21 09:18:08 +03:00
Michael Klishin fd5837d24c Highlight leading and trailing ws in names
Queue and exchange names, for now.

Currently leading and trailing whitespace in names
is very difficult to spot as both management UI
and CLI tools do not highlight whitespace in names
in any way.

Names with leading and trailing whitespace are always
a mistake and cause confusion. In a recent support
case they wasted quite a bit of time.
2019-07-21 06:25:23 +03:00
Gerhard Lazu 5636b3e8e8 Fix bytes prefix symbol
B is used for powers of 10, e.g. 10^6 bytes = 1MB
iB is used for powers of 2, e.g. 2^20 bytes = 1MiB

Since the division is using a power of 2, the symbol used also needs to
be a power of 2.

https://en.wikipedia.org/wiki/Byte
2019-04-23 15:50:35 +01:00
Diana Corbacho d66d378208 Hide SAC label if x-single-active-consumer=false
[#164890920]
2019-04-05 12:14:32 +01:00
Grigory Starinkin b762de7968 allow uri with credentials formatter to accept multiple uris
fix federations page where one federation can have multiple uris
2019-03-21 15:24:38 +00:00
Luke Bakken 8e1ef5c445 Remove type check 2019-03-04 12:04:19 -08:00
Daniil Fedotov 83ffea87a5 Format terminated status for queues as yellow.
If a queue is deleted, it's not an error, but is not a normal queue operation.
2019-03-01 13:46:35 -05:00
Luke Bakken a08229d3b5 formatters.js: Fix a typo 2019-02-01 17:55:05 +01:00
Daniil Fedotov 0937bf407f Merge pull request #653 from rabbitmq/rabbitmq-server-1838-active-field-for-consumers
Add help and link to explain active consumer flag
2019-01-28 20:49:17 +04:00
Arnaud Cogoluègnes 7f41cc17fd Add consumer activity status column
[#163298456]

References rabbitmq/rabbitmq-server#1838
2019-01-24 10:53:30 +01:00
Michael Klishin 48be230dac Truncate client ID, product and platform info at 120 characters
On the connection listing page.

Pair: @acogoluegnes.
2019-01-22 13:15:43 +03:00
Arnaud Cogoluègnes 3f997ef7d3 Display client ID in connection list
[#153246723]

References rabbitmq/rabbitmq-mqtt#152
2019-01-22 10:31:26 +01:00
Michael Klishin 0b9e03b589 Missing var(s), condition braces, semicolons 2019-01-03 01:20:02 +03:00
Michael Klishin 35eb988e33 Escape filter values
The values are not populated from request parameters but being
more defensive against potential injections wouldn't hurt.
2019-01-03 00:50:44 +03:00
Michael Klishin 2e6b450759 Variable naming 2019-01-03 00:08:26 +03:00
Michael Klishin 74f7a0e7b5 Rename a function 2019-01-02 23:55:44 +03:00
Michael Klishin d9d123f67f Correct a typo in function name 2019-01-02 23:51:27 +03:00
Luke Bakken 7045490001 Restore code removed in 456c3a0 that links an exclusive owner connection 2018-12-20 13:47:06 -08:00
Diana Corbacho de414e81d3 Copy by reference as the object is not used anymore
JS methods weren't copied usign assign, so indexOf could not be found.
Giving up and allowing a copy by reference as we don't need that data anymore.
2018-10-26 12:44:35 +01:00
Diana Corbacho 8cd188b67d Fix minority calculation
JS objects are copied by reference in a var assignation, and / is a float operation.
2018-10-26 12:44:35 +01:00
Diana Corbacho 34463b2fe7 Display members and online information for quorum queues
[#157146500]
2018-10-26 12:44:35 +01:00
Gerhard Lazu 6f622f3f44 Use consistent & healthy padding for table headers, even when sorting
Without this, as soon as a column is sorted, extra padding is added and
all table contents get shifted a few pixels downwards in a rather jerky
fashion - this is difficult to capture in screenshots. Also, text in
table headers becomes misaligned.

By using sorting symbols that have the same height, sorting columns
asc/desc doesn't make the content in table headers "jump" and remain
misaligned.
2018-02-06 22:26:11 +00:00
Daniil Fedotov 3d0fb2007f Merge branch 'stable' 2017-10-27 19:46:35 +01:00
Daniil Fedotov c24320c4bb Make policy clickable.
Policy is refered by name in exchanges and queues pages.
Make it a link, so it's easier to navigate.

Fixes #493
[#152274158]
2017-10-27 10:52:29 +01:00
Michael Klishin 2b94e510cf Merge branch 'stable'
Conflicts:
	priv/www/css/main.css
	priv/www/js/main.js
2017-10-27 07:15:02 +03:00
Gerhard Lazu 9594dad140 Address jQuery HTML selector vulnerability + UI improvements
Selectors could be interpreted as HTML, as per jQuery bug #11290:
https://bugs.jquery.com/ticket/11290

Same as last time when jQuery was upgraded, did a few UI improvements.

[#152142103]
2017-10-26 17:34:34 +01:00
Michael Klishin 91945d1c98 Fix a syntas error resulting from a bad merge in formatters.js 2017-10-12 20:13:10 +03:00
Michael Klishin 6e214de8fc Merge branch 'stable'
Conflicts:
	priv/www/css/main.css
	priv/www/js/formatters.js
	priv/www/js/global.js
2017-10-10 21:44:01 +01:00
Gerhard Lazu 584d9165ba Make links, buttons & abbr (former acronyms) stand out 2017-10-10 17:57:05 +01:00
Michael Klishin e45cc8d5ec Merge branch 'stable'
Conflicts:
	.gitignore
	priv/www/js/formatters.js
2017-09-18 12:40:19 -06:00
Luke Bakken ddf8e74eb4 Do not remove rabbit@ prefix 2017-09-18 10:49:00 -07:00
Luke Bakken 332ca5cd45 Format node names consistently
This change ensures that nodes whose name begins with `rabbit@` have that leading text removed. This saves UI space as, in production environments, the default node name is `rabbit@`.
2017-09-14 13:49:57 -07:00
Daniil Fedotov 61fb2316e8 Merge branch 'stable' 2017-08-30 19:20:38 +01:00
Michael Klishin 7c93c01549 Slash a few slashes 2017-08-29 17:27:39 -06:00
Michael Klishin 75db52b502 The +, - and . characters are allowed in URI schemes 2017-08-29 16:20:52 -06:00
Michael Klishin 140d604b0e Introduce a function that redacts passwords in URIs 2017-08-29 14:47:58 -06:00
Michael Klishin 13da0145a5 Merge branch 'stable'
Conflicts:
	priv/www/js/global.js
	priv/www/js/tmpl/queue.ejs
2017-08-06 17:26:58 +03:00
Michael Klishin 456c3a0887 Mark exclusive queues with Excl, like before
While at it, remove remaining references to owner_pid_details.
We don't return it in the API any more.
It is useful for linking to the owner connection, so that part
we will brought back eventually in some shape or form (see #467).
2017-08-06 15:02:16 +03:00
Luke Bakken c97e795127 Add UI marker for exclusive queue
Fixes #459
2017-08-04 14:18:52 -07:00
Michael Klishin 2158cb3ef7 Merge branch 'master' into rabbitmq-management-460 2017-08-03 16:16:19 +03:00
Daniil Fedotov 6b2cb31773 Format per-node vhost state on the vhost page. Change vhsot status from down to stopped 2017-08-02 15:39:48 +01:00
Michael Klishin 576efad87c Cosmetics 2017-08-01 18:31:03 +03:00
Daniil Fedotov accd9a1e36 Change the vhost API to have cluster_state instead of state.
Vhost supervisor status can be different on different nodes.
Report a warning if a vhost is down on any node.
State can be calculated from the cluster state.

Fixes #460
[#149634421]
2017-08-01 14:58:41 +01:00
Daniil Fedotov 553240a2d5 Report queues, stopped by a supervisor, using red color
Queues can be stopped with a vhost supervisor. This state requires
an operator attention and should be red.
2017-07-26 15:25:07 +01:00
Michael Klishin 8d7aba5060 Merge branch 'stable' 2017-06-17 05:06:59 +03:00
Michael Klishin 83932ed2bd Wording
This is more precise: internal flow control (the "flow"
state) is transient and throttling is a more suitable
and widely used term for describing what it effectively does.
2017-06-17 05:05:34 +03:00
Michael Klishin 2ecff64ca4 Merge branch 'stable' 2017-03-28 14:58:14 +03:00
Michael Klishin 7b016c80d5 Management UI: be more defensive
* Don't throw and give up when our "pre-pre-prehistoric virtual DOM"
   update isn't consistent, reaload instead

 * Coerce the input to a string in two formatting functions

 * In the same functions, catch nulls and undefined values early

This fixes a couple of relatively difficult to reproduce exceptions
caused by stats emission timing + DOM updates timing
that make the UI dysfunctional.
2017-03-28 14:40:08 +03:00