Commit Graph

356 Commits

Author SHA1 Message Date
Michael Klishin 2b94e510cf Merge branch 'stable'
Conflicts:
	priv/www/css/main.css
	priv/www/js/main.js
2017-10-27 07:15:02 +03:00
Gerhard Lazu 9594dad140 Address jQuery HTML selector vulnerability + UI improvements
Selectors could be interpreted as HTML, as per jQuery bug #11290:
https://bugs.jquery.com/ticket/11290

Same as last time when jQuery was upgraded, did a few UI improvements.

[#152142103]
2017-10-26 17:34:34 +01:00
Michael Klishin e0efa5c1dc Merge branch 'stable'
Conflicts:
	priv/www/css/main.css
	priv/www/js/tmpl/paths.ejs
2017-10-19 01:07:34 +03:00
Gerhard Lazu e157238c80 Add no-op #/ route for Sammy.js, fixes 404 not found error 2017-10-13 18:21:01 +01:00
Michael Klishin 6e214de8fc Merge branch 'stable'
Conflicts:
	priv/www/css/main.css
	priv/www/js/formatters.js
	priv/www/js/global.js
2017-10-10 21:44:01 +01:00
Gerhard Lazu 584d9165ba Make links, buttons & abbr (former acronyms) stand out 2017-10-10 17:57:05 +01:00
Luke Bakken 47b70d8a8a Add TODO for queue limit validation
Validation code in place, how to display?

Take existing queue count into consideration

Server-side validation takes existing queue count into consideration. Improve error message sent back to web application.

Improve messaging, remove unused template

Take existing queues into account when importing definitions for all vhosts. Fix test suite.
2017-07-10 07:58:34 -07:00
Michael Klishin 96d24e09c3 Merge branch 'stable' 2017-06-21 02:01:38 +03:00
Luke Bakken 6d63eb7bc8 Escape queue filter input value when regex is used 2017-06-20 11:08:24 -07:00
Diana Corbacho bc76cff78c Manage topic permissions from the UI in user and vhost tabs
Added endpoint /topic-permissions/:vhost/:user/:exchange to
delete individual permissions

rabbitmq-management#405
[#146603709]
2017-06-05 19:20:29 +01:00
Michael Klishin be1b30f643 Merge branch 'stable' 2017-05-18 15:34:59 +01:00
Michael Klishin 1447c812c7 Wording (take 2, spotted by @dcorbacho) 2017-05-18 15:33:35 +01:00
Michael Klishin b4baf55c66 Wording 2017-05-18 15:22:50 +01:00
Diana Corbacho efedce7c99 Only submit import definitions if a file has been selected
rabbitmq-management#389
2017-05-17 23:47:00 +01:00
Diana Corbacho fc7f5183c7 Add confirm dialog to import definitions
rabbitma-management#389
2017-05-17 23:28:47 +01:00
Michael Klishin 2ecff64ca4 Merge branch 'stable' 2017-03-28 14:58:14 +03:00
Michael Klishin 7b016c80d5 Management UI: be more defensive
* Don't throw and give up when our "pre-pre-prehistoric virtual DOM"
   update isn't consistent, reaload instead

 * Coerce the input to a string in two formatting functions

 * In the same functions, catch nulls and undefined values early

This fixes a couple of relatively difficult to reproduce exceptions
caused by stats emission timing + DOM updates timing
that make the UI dysfunctional.
2017-03-28 14:40:08 +03:00
Michael Klishin b5c3a994bb Merge branch 'stable' 2017-03-27 15:18:15 +03:00
Michael Klishin 172ecfad1f Strip HTML tags from filter inputs
Since they are used to construct the markup of the updated form.

[#142393391]
2017-03-24 18:59:23 +03:00
Michael Klishin 1403a92f4c Merge branch 'stable'
Conflicts:
	src/rabbit_mgmt_wm_channel.erl
	src/rabbit_mgmt_wm_queue.erl
2017-03-23 22:51:55 +03:00
kjnilsson 6a7ec9fa94 Don't html escape all popup text
The popup is also used for displaying the help menu
and the column selection form.

[#142213453]
2017-03-23 12:43:42 +00:00
kjnilsson 979eb64917 Catch errors from message publish
When trying to publish a message with e.g. an invalid header
value type no error message is shown.

[#142213453]
2017-03-23 11:07:47 +00:00
kjnilsson d57161ba45 Html escape displayed messages.
Html escape error messages before returning from management
API. Also escape text before launching popup.

[#142213453]
2017-03-23 10:29:45 +00:00
Michael Klishin 7380fd69ec Merge branch 'stable' 2017-03-23 01:47:58 +03:00
Michael Klishin 7aebeb5651 Store authentication details in the cookie again
It was moved to local storage together with personal
preferences (e.g. what columns should be displayed in various
tables) in 8be18652f4 (3.4.0), very unlikely
by design.

This is a short term solution for session expiration. A proper
one would be moving to a token-based system such as OAuth 2.0.

[#142212963]
2017-03-22 15:44:21 +03:00
Michael Klishin 2d78a4d009 Merge branch 'stable' 2017-01-03 19:21:27 +08:00
Michael Klishin 728e7dafab Merge branch 'stable' into rabbitmq-management-159 2017-01-03 19:19:08 +08:00
Michael Klishin c756556b33 Merge branch 'stable' 2017-01-03 19:02:50 +08:00
Diana Corbacho bf43226bf4 Notify UI users of not authorised access 2017-01-03 11:40:00 +01:00
Michael Klishin b3c604fc02 Merge branch 'stable' 2017-01-03 17:24:51 +08:00
Diana Corbacho f6d07d887d Add lazy queue argument in queues and policies page 2017-01-03 08:49:36 +01:00
Diana Corbacho 4123cf3207 Make delete and purge confirmation messages more explicit 2016-12-30 16:52:13 +01:00
Diana Corbacho 5f1e0a3103 Merge remote-tracking branch 'origin/rabbitmq-management-236' 2016-12-05 17:18:57 +00:00
Jean-Sébastien Pédron a30b6072b9 Merge branch 'stable' into rabbitmq-management-236 2016-11-24 12:09:26 +01:00
Daniil Fedotov 8643ed2335 Do not update .updatable elements if there are outstanding requests 2016-11-23 14:39:09 +00:00
Daniil Fedotov 93df289366 Updated limits page to edit limits. Updated policies page to create operator policies 2016-10-03 13:06:16 +01:00
Michael Klishin f7eb596814 Cosmetics 2016-09-28 14:45:43 +03:00
Sergey Nepomnyachiy bc5234df7e Allow giving path when using #/login 2016-09-19 08:14:20 -04:00
Ilya Khaprov cc7703e2c3 fixes #251.
Makes setup_extensions more resilient.
Particularly this allows api-only management plugins.
2016-07-14 14:39:27 -07:00
Jean-Sébastien Pédron 16daebc425 main.js: Use arbitrary options as query string parameters
References rabbitmq/rabbitmq-top#10.
[#121658507]
2016-06-16 13:05:11 +02:00
Diana Corbacho 585f9f75e9 Include auth and escape vhost name 2016-02-17 16:25:31 +00:00
Michael Klishin 231a5f363d Strip trailing ws 2016-02-17 08:31:29 +03:00
Michael Klishin 711d5ad1e3 Merge branch 'stable' into rabbitmq-management-65 2016-02-17 07:18:29 +03:00
Gabriele Santomaggio 41d390af27 added import vhost 2016-02-16 11:50:45 +01:00
Diana Corbacho a4b3016788 Escape vhost in URI 2016-02-15 16:33:01 +00:00
Gabriele Santomaggio 0dd0683914 added vhost on download definition function 2016-02-15 17:21:14 +01:00
Gabriele Santomaggio d07a5f5d1b updated sammy 0.7.6 2016-01-27 23:00:09 +01:00
Michael Klishin 1823333a40 Trailing ws 2016-01-26 01:51:53 +03:00
Gabriele Santomaggio 6303314adf redirect for currect_context 2016-01-25 09:58:09 +01:00
Gabriele Santomaggio fc659d282e fix IE enter key 2016-01-24 11:28:51 +01:00
Loïc Hoguin 67b060f105 Show an error on bad_request and not_found responses
Some validation can only be done server-side, therefore we need
to show a popup in some cases when the input was invalid.
2016-01-20 13:01:09 +01:00
Michael Klishin c637c4e188 Do not use for .. of from ECMAScript 2015
It is not supported by any Internet Explorer version:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of
2015-12-30 04:29:36 +03:00
chris 66698448a2 help toggle 2015-12-23 13:18:36 +00:00
Gabriele Santomaggio afa77d38c7 fix connections 2015-11-20 09:57:22 +01:00
Gabriele Santomaggio 9d0c44ace2 fix redirect 2015-11-19 12:42:35 +01:00
Gabriele Santomaggio 2a5c2bbe47 changed redirect 2015-11-19 10:33:20 +01:00
Gabriele Santomaggio 583b49a3ba removed unused variable 2015-11-17 17:31:55 +01:00
Gabriele Santomaggio 955286e0c6 pagination all contexts 2015-11-17 16:59:49 +01:00
Gabriele Santomaggio 05ebdae4e1 filter by name 2015-11-12 22:25:01 +01:00
Michael Klishin 202f3672eb Fix autorefresh when a non-existent page is requested 2015-11-03 11:23:05 +03:00
Gabriele Santomaggio c6793e2ded fix spaces JS 2015-10-22 14:35:37 +02:00
Gabriele Santomaggio b259ec9a64 fix code style 2015-10-22 12:46:52 +02:00
Gabriele Santomaggio 0bdb45a84d handle API errors 2015-10-22 09:55:36 +02:00
Gabriele Santomaggio 2f00265997 pages preferences 2015-10-15 12:44:36 +02:00
Gabriele Santomaggio f1ef53ec6b pagination UI 2015-10-13 15:53:20 +02:00
Michael Klishin e2c1fd0cdb Introduce GET /api/vhosts/{vhost}/channels and /connections
Make lists of connections and channels honor the current vhost
scope when updating.

Fixes #34.
2015-04-14 00:22:19 +03:00
Simon MacMullen 2e3edb4a03 Simplify the mass of multiplying "updatable" divs (bug 26613).
If we make show/hide sections capable of being inside an updatable
div then we can wrap most of node.ejs in a single updatable rather
than having dozens of the things. This also means charts don't manage
their own updatability any more.
2015-02-27 12:34:04 +00:00
Simon MacMullen 06d7398593 Cancel outstanding requests when changing template; when they arrive they will probably cause page rendering to fail. 2014-11-05 12:03:54 +00:00
Simon MacMullen f219693b95 No longer relevant 2014-10-21 11:32:30 +01:00
Simon MacMullen f45d42bc14 Oops 2014-10-06 13:05:52 +01:00
Simon MacMullen 2c8d379a87 A bit more abstraction. 2014-10-06 13:03:49 +01:00
Simon MacMullen 3d692f1c4e Display binary use in mgmt. 2014-10-02 17:09:06 +01:00
Simon MacMullen c3c964364f That had been bugging me since 2010. No idea why it's needed. 2014-10-02 15:41:36 +01:00
Simon MacMullen e962b64041 Make all chart ranges use the same preference. 2014-09-25 11:44:51 +01:00
Simon MacMullen 8be18652f4 Don't store the auth cookie explicitly, do everything via the prefs module. 2014-09-22 17:45:53 +01:00
Simon MacMullen 933bfa8886 Column show / hide mechanism, and convert the queue list page to use it for the existing columns. 2014-09-19 15:19:43 +01:00
Simon MacMullen 97c07cf1cc Add a mechanism to fill in argument fields, remove the "known field" filling. 2014-09-11 16:27:39 +01:00
Simon MacMullen 0815ce6b0c Proof-of-concept: show a chart of memory use over time. 2014-06-11 16:33:53 +01:00
Simon MacMullen 74235e35eb UI to hide lines in charts. 2014-06-04 17:44:19 +01:00
Simon MacMullen cd068d1a59 Merge bug26107 2014-05-19 10:39:23 +01:00
Simon MacMullen 87459a12e5 Don't allow bad property types through. 2014-04-24 13:20:29 +01:00
Simon MacMullen bc1ac34c4f Ignore empty string values in sub-lists. 2014-04-23 14:10:59 +01:00
Simon MacMullen 577e50441d Basic mode for stats; where we show rates per-thing, but not per {thing, other thing} pair. 2014-04-11 17:41:02 +01:00
Simon MacMullen 2cad32fb8d Management support for cluster name. 2014-01-31 13:40:48 +00:00
Simon MacMullen 6a5dce09cc Make controls-appearance support multiple divs, not just yes/no. 2013-11-22 15:32:44 +00:00
Simon MacMullen 1a7f31125b If the regex is invalid, display the error message rather than returning all rows. 2013-11-13 11:09:44 +00:00
Simon MacMullen ecdac946c7 Reduce distance to default and fix layout (on my browser at least...) 2013-11-12 17:09:02 +00:00
Simon MacMullen 77a0f492f6 Patch as contributed. 2013-11-12 16:41:31 +00:00
Simon MacMullen 2cb832e304 Remove vestiges of uri_auth_used. 2013-11-06 15:58:32 +00:00
Matthew Sackman 654115ec25 Move bug25865 to stable. 2013-11-06 15:51:08 +00:00
Simon MacMullen 494fa8ed45 userinfo is already decoded at both call sites. 2013-10-31 11:22:31 +00:00
Simon MacMullen 43cb6268b2 Hide "log out" button if it's not going to do anything. 2013-10-09 18:04:49 +01:00
Simon MacMullen 6ab31a4bfc Simplify and abstract a bit. 2013-10-09 17:55:23 +01:00
Matthew Sackman 3c1ce12eed Remember how stupid JS is... 2013-10-09 17:24:41 +01:00
Matthew Sackman 485f0f4687 Detect if there's a userinfo section in the window href, and if there is, try to set up the ram auth cookie correctly so that we immediately auth straight through. 2013-10-09 17:16:47 +01:00
Emile Joubert 611f1d5b99 Merged bug25778 into default 2013-09-26 10:02:11 +01:00
Simon MacMullen cfbfffedaa Turn off EJS caching when we first load a template since page refresh (but leave it on otherwise, lest we retrieve lots of templates every five seconds). Also don't use Req:get(raw_path) when serving static content, it doesn't remove the query string and so causes us to 404 if one is present. 2013-09-20 14:31:59 +01:00
Simon MacMullen 3eafb50836 Introduce new policymaker tag, and updates to web UI to support that (which involves rewriting half the menu code since it didn't really deal with anything other than admin vs non-admin). 2013-09-19 13:29:25 +01:00
Simon MacMullen 7932b085c6 Oops 2013-06-18 16:59:17 +01:00
Emile Joubert a3a0842c0d Merged bug25063 2013-05-17 15:17:56 +01:00