root
/
redis
mirror of https://github.com/redis/redis.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

* fix comments

This commit is contained in:
jonathan keinan 2025-02-05 10:13:50 +02:00 committed by YaacovHazan
parent b9361ad5fe
commit 7a40fd630d
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/module.c
View File

@ -13287,7 +13287,7 @@ int RM_RegisterNumericConfig(RedisModuleCtx *ctx, const char *name, long long de
* Only call this function if the module would like to make changes to the * Only call this function if the module would like to make changes to the
* configuration values before the actual values are applied by RedisModule_LoadConfigs. * configuration values before the actual values are applied by RedisModule_LoadConfigs.
* Otherwise it's sufficient to call RedisModule_LoadConfigs, it should already set the default values if needed. * Otherwise it's sufficient to call RedisModule_LoadConfigs, it should already set the default values if needed.
* This makes it possible to distinguish between default values and user provided values and apply other changes between setting the defaults and the user values.``` * This makes it possible to distinguish between default values and user provided values and apply other changes between setting the defaults and the user values.
* This will return REDISMODULE_ERR if it is called: * This will return REDISMODULE_ERR if it is called:
* 1. outside RedisModule_OnLoad * 1. outside RedisModule_OnLoad
* 2. more than once * 2. more than once

2
tests/unit/moduleapi/moduleconfigs.tcl
View File

@ -350,7 +350,7 @@ start_server {tags {"modules"}} {
CONFIG moduleconfigs.memory_numeric 2mb \ CONFIG moduleconfigs.memory_numeric 2mb \
ARGS override-default ARGS override-default
# Verify CONFIG values took precedence over the pseudo values that # Verify CONFIG values took precedence over the values that override-default would have caused the module to set
assert_equal [r config get moduleconfigs.string] "moduleconfigs.string goo" assert_equal [r config get moduleconfigs.string] "moduleconfigs.string goo"
assert_equal [r config get moduleconfigs.memory_numeric] "moduleconfigs.memory_numeric 2097152" assert_equal [r config get moduleconfigs.memory_numeric] "moduleconfigs.memory_numeric 2097152"