root
/
redis
mirror of https://github.com/redis/redis.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Sentinel tests, disable FD leak check, and print more details (#8376) 

* Print more details about fd leaks
* temporarily prevent the leaks from failing the tests

Co-authored-by: Oran Agra <oran@redislabs.com>
This commit is contained in:
Andy Pan 2021-01-22 18:11:58 +08:00 committed by GitHub
parent 0232778f35
commit 8449a5df87
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/instances.tcl
View File

@ -423,7 +423,8 @@ proc end_tests {} {
if { [file exists $sentinel_fd_leaks_file] } { if { [file exists $sentinel_fd_leaks_file] } {
puts [colorstr red "WARNING: sentinel test(s) failed, there are leaked fds in sentinel:"] puts [colorstr red "WARNING: sentinel test(s) failed, there are leaked fds in sentinel:"]
puts [exec cat $sentinel_fd_leaks_file] puts [exec cat $sentinel_fd_leaks_file]
exit 1 # temporarily disabling this error from failing the tests until leaks are fixed.
#exit 1
} }
if {$::failed == 0 } { if {$::failed == 0 } {

1
tests/sentinel/tests/includes/notify.sh
View File

@ -16,5 +16,6 @@ then
if [ ! -f $sentinel_fd_leaks_file ] if [ ! -f $sentinel_fd_leaks_file ]
then then
ls -l /proc/self/fd | cat >> $sentinel_fd_leaks_file ls -l /proc/self/fd | cat >> $sentinel_fd_leaks_file
lsof -p $$ | cat >> $sentinel_fd_leaks_file
fi fi
fi fi