rubyzip/test/file_extract_test.rb

150 lines
4.3 KiB
Ruby
Raw Normal View History

# frozen_string_literal: true
require 'test_helper'
class ZipFileExtractTest < MiniTest::Test
include CommonZipFileFixture
2015-03-21 16:27:44 +08:00
EXTRACTED_FILENAME = 'test/data/generated/extEntry'
ENTRY_TO_EXTRACT, *REMAINING_ENTRIES = TEST_ZIP.entry_names.reverse
def setup
super
2014-02-07 07:00:38 +08:00
::File.delete(EXTRACTED_FILENAME) if ::File.exist?(EXTRACTED_FILENAME)
end
2019-09-13 05:01:38 +08:00
def teardown
::Zip.reset!
end
def test_extract
2015-03-21 16:10:37 +08:00
::Zip::File.open(TEST_ZIP.zip_name) do |zf|
zf.extract(ENTRY_TO_EXTRACT, EXTRACTED_FILENAME)
2014-02-07 07:00:38 +08:00
assert(File.exist?(EXTRACTED_FILENAME))
2015-03-21 16:16:06 +08:00
AssertEntry.assert_contents(EXTRACTED_FILENAME,
2019-09-27 05:38:28 +08:00
zf.get_input_stream(ENTRY_TO_EXTRACT, &:read))
::File.unlink(EXTRACTED_FILENAME)
entry = zf.get_entry(ENTRY_TO_EXTRACT)
entry.extract(EXTRACTED_FILENAME)
2014-02-07 07:00:38 +08:00
assert(File.exist?(EXTRACTED_FILENAME))
2015-03-21 16:16:06 +08:00
AssertEntry.assert_contents(EXTRACTED_FILENAME,
2019-09-27 05:38:28 +08:00
entry.get_input_stream(&:read))
2015-03-21 16:10:37 +08:00
end
end
2015-03-25 00:02:54 +08:00
def test_extract_exists
text = 'written text'
::File.open(EXTRACTED_FILENAME, 'w') { |f| f.write(text) }
2015-03-21 16:10:37 +08:00
assert_raises(::Zip::DestinationFileExistsError) do
::Zip::File.open(TEST_ZIP.zip_name) do |zf|
zf.extract(zf.entries.first, EXTRACTED_FILENAME)
2015-03-21 16:10:37 +08:00
end
end
2015-03-21 16:27:44 +08:00
File.open(EXTRACTED_FILENAME, 'r') do |f|
assert_equal(text, f.read)
2015-03-21 16:10:37 +08:00
end
end
2015-03-25 00:02:54 +08:00
def test_extract_exists_overwrite
text = 'written text'
::File.open(EXTRACTED_FILENAME, 'w') { |f| f.write(text) }
called_correctly = false
2015-03-21 16:10:37 +08:00
::Zip::File.open(TEST_ZIP.zip_name) do |zf|
2020-02-18 06:35:08 +08:00
zf.extract(zf.entries.first, EXTRACTED_FILENAME) do |entry, extract_loc|
called_correctly = zf.entries.first == entry &&
extract_loc == EXTRACTED_FILENAME
true
2015-03-21 16:10:37 +08:00
end
end
assert(called_correctly)
2015-03-21 16:27:44 +08:00
::File.open(EXTRACTED_FILENAME, 'r') do |f|
assert(text != f.read)
2015-03-21 16:10:37 +08:00
end
end
2015-03-25 00:02:54 +08:00
def test_extract_non_entry
zf = ::Zip::File.new(TEST_ZIP.zip_name)
2015-03-21 16:27:44 +08:00
assert_raises(Errno::ENOENT) { zf.extract('nonExistingEntry', 'nonExistingEntry') }
ensure
zf.close if zf
end
def test_extract_another_non_entry
out_file = 'outfile'
2015-03-21 16:10:37 +08:00
assert_raises(Errno::ENOENT) do
zf = ::Zip::File.new(TEST_ZIP.zip_name)
non_entry = 'hotdog-diddelidoo'
assert(!zf.entries.include?(non_entry))
zf.extract(non_entry, out_file)
zf.close
2015-03-21 16:10:37 +08:00
end
assert(!File.exist?(out_file))
end
2019-09-13 05:01:38 +08:00
def test_extract_incorrect_size
# The uncompressed size fields in the zip file cannot be trusted. This makes
# it harder for callers to validate the sizes of the files they are
# extracting, which can lead to denial of service. See also
# https://en.wikipedia.org/wiki/Zip_bomb
Dir.mktmpdir do |tmp|
real_zip = File.join(tmp, 'real.zip')
fake_zip = File.join(tmp, 'fake.zip')
file_name = 'a'
true_size = 500_000
fake_size = 1
::Zip::File.open(real_zip, ::Zip::File::CREATE) do |zf|
zf.get_output_stream(file_name) do |os|
os.write 'a' * true_size
end
end
compressed_size = nil
::Zip::File.open(real_zip) do |zf|
a_entry = zf.find_entry(file_name)
compressed_size = a_entry.compressed_size
assert_equal true_size, a_entry.size
end
true_size_bytes = [compressed_size, true_size, file_name.size].pack('VVv')
fake_size_bytes = [compressed_size, fake_size, file_name.size].pack('VVv')
2019-09-13 05:01:38 +08:00
data = File.binread(real_zip)
assert data.include?(true_size_bytes)
data.gsub! true_size_bytes, fake_size_bytes
File.open(fake_zip, 'wb') do |file|
file.write data
end
Dir.chdir tmp do
::Zip::File.open(fake_zip) do |zf|
a_entry = zf.find_entry(file_name)
assert_equal fake_size, a_entry.size
::Zip.validate_entry_sizes = false
2021-06-18 23:31:23 +08:00
assert_output('', /.+'a'.+1B.+/) do
a_entry.extract
end
2019-09-13 05:01:38 +08:00
assert_equal true_size, File.size(file_name)
FileUtils.rm file_name
::Zip.validate_entry_sizes = true
error = assert_raises ::Zip::EntrySizeError do
a_entry.extract
end
assert_equal \
"entry 'a' should be 1B, but is larger when inflated.",
2019-09-13 05:01:38 +08:00
error.message
end
end
end
end
end