root
/
rubyzip
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix rubocop Style/PredicateName cop

This commit is contained in:
Pavel Lobashov 2015-03-23 19:18:51 +03:00
parent f291e1f616
commit 31fb9d729b
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.rubocop_rubyzip.yml
View File

@ -209,11 +209,6 @@ Style/NumericLiterals:
Style/PercentLiteralDelimiters: Style/PercentLiteralDelimiters:
Enabled: false Enabled: false
# Offense count: 1
# Configuration parameters: NamePrefix, NamePrefixBlacklist.
Style/PredicateName:
Enabled: false
# Offense count: 3 # Offense count: 3
# Configuration parameters: MaxSlashes. # Configuration parameters: MaxSlashes.
Style/RegexpLiteral: Style/RegexpLiteral:

8
lib/zip/file.rb
View File

@ -375,16 +375,16 @@ module Zip
private private
def is_directory(newEntry, srcPath) def directory?(newEntry, srcPath)
srcPathIsDirectory = ::File.directory?(srcPath) srcPathIsDirectory = ::File.directory?(srcPath)
if newEntry.is_directory && !srcPathIsDirectory if newEntry.directory? && !srcPathIsDirectory
raise ArgumentError, raise ArgumentError,
"entry name '#{newEntry}' indicates directory entry, but " \ "entry name '#{newEntry}' indicates directory entry, but " \
"'#{srcPath}' is not a directory" "'#{srcPath}' is not a directory"
elsif !newEntry.is_directory && srcPathIsDirectory elsif !newEntry.directory? && srcPathIsDirectory
newEntry.name += '/' newEntry.name += '/'
end end
newEntry.is_directory && srcPathIsDirectory newEntry.directory? && srcPathIsDirectory
end end
def check_entry_exists(entryName, continue_on_exists_proc, procedureName) def check_entry_exists(entryName, continue_on_exists_proc, procedureName)