root
/
rubyzip
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a test helper for more human-readable file permission comparison 

Before this change:
  1) Failure:
FilePermissionsTest#test_umask_027 [/Users/marcoswk/workspace/rubyzip/test/file_permissions_test.rb:52]:
Expected: 33184
  Actual: 33183

After this change:
  1) Failure:
FilePermissionsTest#test_umask_027 [/Users/marcoswk/workspace/rubyzip/test/file_permissions_test.rb:52]:
--- expected
+++ actual
@@ -1,2 +1,2 @@
 # encoding: US-ASCII
-"100640"
+"100637"
This commit is contained in:
Marcos Wright-Kuhns 2016-06-30 14:47:41 -07:00
parent 046b7f8f86
commit 4b27538818
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/file_permissions_test.rb
View File

@ -17,7 +17,7 @@ class FilePermissionsTest < MiniTest::Test
def test_windows_perms
create_files
assert_equal ::File.stat(FILENAME).mode, ::File.stat(ZIPNAME).mode
assert_matching_permissions FILENAME, ZIPNAME
end
else
@ -25,7 +25,7 @@ class FilePermissionsTest < MiniTest::Test
def test_current_umask
create_files
assert_equal ::File.stat(FILENAME).mode, ::File.stat(ZIPNAME).mode
assert_matching_permissions FILENAME, ZIPNAME
end
def test_umask_000
@ -33,7 +33,7 @@ class FilePermissionsTest < MiniTest::Test
create_files
end
assert_equal ::File.stat(FILENAME).mode, ::File.stat(ZIPNAME).mode
assert_matching_permissions FILENAME, ZIPNAME
end
def test_umask_066
@ -41,7 +41,7 @@ class FilePermissionsTest < MiniTest::Test
create_files
end
assert_equal ::File.stat(FILENAME).mode, ::File.stat(ZIPNAME).mode
assert_matching_permissions FILENAME, ZIPNAME
end
def test_umask_027
@ -49,11 +49,18 @@ class FilePermissionsTest < MiniTest::Test
create_files
end
assert_equal ::File.stat(FILENAME).mode, ::File.stat(ZIPNAME).mode
assert_matching_permissions FILENAME, ZIPNAME
end
end
def assert_matching_permissions(expected_file, actual_file)
assert_equal(
::File.stat(expected_file).mode.to_s(8).rjust(4, '0'),
::File.stat(actual_file).mode.to_s(8).rjust(4, '0')
)
end
def create_files
::Zip::File.open(ZIPNAME, ::Zip::File::CREATE) do |zip|
zip.comment = "test"