From 55ed74c20e721a8440655407ec6be75c1d0f5831 Mon Sep 17 00:00:00 2001 From: Robert Haines Date: Sun, 23 May 2021 22:03:33 +0100 Subject: [PATCH] Fix/configure Style/AccessorGrouping cop. --- .rubocop.yml | 5 +++++ .rubocop_todo.yml | 9 --------- lib/zip/decompressor.rb | 3 +-- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 4ef52bd..643cb49 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -64,6 +64,11 @@ Naming/VariableNumber: Exclude: - 'test/file_permissions_test.rb' +# Need to allow accessors in Entry to be separated for doc purposes. +Style/AccessorGrouping: + Exclude: + - 'lib/zip/entry.rb' + # Set a consistent way of checking types. Style/ClassCheck: EnforcedStyle: kind_of? diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 8a40491..38e5730 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -51,15 +51,6 @@ Naming/AccessorMethodName: - 'lib/zip/input_stream.rb' - 'lib/zip/streamable_stream.rb' -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: separated, grouped -Style/AccessorGrouping: - Exclude: - - 'lib/zip/decompressor.rb' - - 'lib/zip/entry.rb' - # Offense count: 7 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. diff --git a/lib/zip/decompressor.rb b/lib/zip/decompressor.rb index 0d29e61..b6bb9cc 100644 --- a/lib/zip/decompressor.rb +++ b/lib/zip/decompressor.rb @@ -16,8 +16,7 @@ module Zip decompressor_classes[compression_method] end - attr_reader :input_stream - attr_reader :decompressed_size + attr_reader :decompressed_size, :input_stream def initialize(input_stream, decompressed_size = nil) super()