Remove compare_enumerables from test_helper.rb

This change has several benefits:
* When errors occur, the test provides useful feedback, showing you
  expected vs. actual.
* We no longer need to open and modify the Enumerable module.
* The test is more readable.
This commit is contained in:
Brian Buchalter 2021-01-26 06:15:14 -07:00
parent e5e3f97ec8
commit 72cedd7ce4
2 changed files with 1 additions and 13 deletions

View File

@ -10,9 +10,7 @@ class ZipCentralDirectoryTest < MiniTest::Test
cdir = ::Zip::CentralDirectory.read_from_stream(zip_file)
assert_equal(TestZipFile::TEST_ZIP2.entry_names.size, cdir.size)
assert(cdir.entries.sort.compare_enumerables(TestZipFile::TEST_ZIP2.entry_names.sort) do |cdir_entry, test_entry_name|
cdir_entry.name == test_entry_name
end)
assert_equal(cdir.entries.map(&:name).sort, TestZipFile::TEST_ZIP2.entry_names.sort)
assert_equal(TestZipFile::TEST_ZIP2.comment, cdir.comment)
end
end

View File

@ -165,16 +165,6 @@ module CrcTest
end
end
module Enumerable
def compare_enumerables(enumerable)
array = enumerable.to_a
each_with_index do |element, index|
return false unless yield(element, array[index])
end
size == array.size
end
end
module CommonZipFileFixture
include AssertEntry