root
/
rubyzip
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up empty.zip after running tests. 

After running the tests there was a file left in the project directory,
'empty.zip', which was simply 'touch'ed to use as a null file. Switch to create
this as one of the generated test files so it's cleaned up automatically.

Also, use 'null.zip' as the name as there is already an 'empty.zip' generated
that is a zip file, but empty.
This commit is contained in:
Robert Haines 2016-08-28 12:17:17 +01:00
parent 7aa3666e34
commit 7caab1f467
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/file_test.rb
View File

@ -528,9 +528,8 @@ class ZipFileTest < MiniTest::Test
end end
def test_empty_zip def test_empty_zip
puts `touch empty.zip`
assert_raises(::Zip::Error) do assert_raises(::Zip::Error) do
::Zip::File.open('empty.zip') ::Zip::File.open(TestFiles::NULL_FILE)
end end
end end

4
test/gentestfiles.rb
View File

@ -9,6 +9,8 @@ class TestFiles
RANDOM_BINARY_FILE1 = 'test/data/generated/randomBinary1.bin' RANDOM_BINARY_FILE1 = 'test/data/generated/randomBinary1.bin'
RANDOM_BINARY_FILE2 = 'test/data/generated/randomBinary2.bin' RANDOM_BINARY_FILE2 = 'test/data/generated/randomBinary2.bin'
NULL_FILE = 'test/data/generated/null.zip' # Zero length, so not a zip file.
EMPTY_TEST_DIR = 'test/data/generated/emptytestdir' EMPTY_TEST_DIR = 'test/data/generated/emptytestdir'
ASCII_TEST_FILES = [RANDOM_ASCII_FILE1, RANDOM_ASCII_FILE2, RANDOM_ASCII_FILE3] ASCII_TEST_FILES = [RANDOM_ASCII_FILE1, RANDOM_ASCII_FILE2, RANDOM_ASCII_FILE3]
@ -28,6 +30,8 @@ class TestFiles
create_random_binary(filename, 1E4 * (index + 1)) create_random_binary(filename, 1E4 * (index + 1))
end end
system("touch #{NULL_FILE}")
ensure_dir(EMPTY_TEST_DIR) ensure_dir(EMPTY_TEST_DIR)
end end