Use named parameters for `File::split`.
This commit is contained in:
parent
f033ae760d
commit
debc9fda91
|
@ -104,13 +104,6 @@ Style/NumericPredicate:
|
|||
- 'lib/zip/ioextras.rb'
|
||||
- 'lib/zip/ioextras/abstract_input_stream.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Configuration parameters: AllowedMethods.
|
||||
# AllowedMethods: respond_to_missing?
|
||||
Style/OptionalBooleanParameter:
|
||||
Exclude:
|
||||
- 'lib/zip/file_split.rb'
|
||||
|
||||
# Offense count: 17
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
|
||||
|
|
|
@ -67,8 +67,8 @@ module Zip
|
|||
|
||||
# Splits an archive into parts with segment size
|
||||
def split(
|
||||
zip_file_name, segment_size = MAX_SEGMENT_SIZE,
|
||||
delete_zip_file = true, partial_zip_file_name = nil
|
||||
zip_file_name, segment_size: MAX_SEGMENT_SIZE,
|
||||
delete_original: true, partial_zip_file_name: nil
|
||||
)
|
||||
raise Error, "File #{zip_file_name} not found" unless ::File.exist?(zip_file_name)
|
||||
raise Errno::ENOENT, zip_file_name unless ::File.readable?(zip_file_name)
|
||||
|
@ -90,7 +90,7 @@ module Zip
|
|||
)
|
||||
end
|
||||
end
|
||||
::File.delete(zip_file_name) if delete_zip_file
|
||||
::File.delete(zip_file_name) if delete_original
|
||||
szip_file_index
|
||||
end
|
||||
end
|
||||
|
|
|
@ -27,7 +27,9 @@ class ZipFileSplitTest < MiniTest::Test
|
|||
end
|
||||
|
||||
def test_split
|
||||
result = ::Zip::File.split(TEST_ZIP.zip_name, 65_536, false)
|
||||
result = ::Zip::File.split(
|
||||
TEST_ZIP.zip_name, segment_size: 65_536, delete_original: false
|
||||
)
|
||||
|
||||
return if result.nil?
|
||||
|
||||
|
|
Loading…
Reference in New Issue