ef520b4b94
Add `compression_level` to the Entry API.
...
Allow an Entry to specify a compression level and pass this down to the
underlying OutputStream infrastructure. OutputStream has been able to
specify a compression level for a while but this has, up until now, only
ever been set to the default.
This fundamentally changes the API so will need a major version bump.
2020-08-31 17:48:08 +01:00
0790695e8c
Clean up OutputStream#init_next_entry.
...
There's no need for this private method to specify a default.
2020-08-31 17:48:08 +01:00
0fee529de5
Use guard instead of if else construct
2020-04-29 17:06:29 +03:00
5af76cecb5
Use Zlib::SYNC_FLUSH so buffer does not grow until finished
...
With JRuby implementation deflate would always return empty string
without Zlib::SYNC_FLUSH. That can cause memory problems when large
files are in deflate buffer as whole and red there with finish call at
once.
2020-04-29 16:38:33 +03:00
69186f65cd
Bump version to 2.3.0
2020-03-14 11:31:39 +00:00
fabacf1633
Merge pull request #440 from hainesr/rubocop-names
...
Rubocop name cops
2020-03-14 10:58:54 +00:00
66324a711c
Remove duplicate binmode call
2020-03-02 11:06:50 +01:00
c30d9dfb26
Configure Naming/MemoizedInstanceVariableName in source.
...
Rather than turn it off for a whole file, it's better to mark these
exceptions in comments.
2020-02-29 18:11:52 +00:00
f9b161eb32
Fix Naming/VariableName cop in the library code.
2020-02-29 18:11:52 +00:00
aa6ea05d45
Fix Naming/MethodParameterName cop in the library code.
2020-02-29 18:11:52 +00:00
b0ee2683b0
Set buffers to binmode by default
2020-02-19 18:48:13 +01:00
846e704048
Fix Naming/BlockParameterName cop.
2020-02-17 22:35:08 +00:00
989a565340
Fix Style/TrailingCommaInHashLiteral cop.
2020-02-15 16:26:32 +00:00
d07b36b2e6
Fix Style/TernaryParentheses cop.
2020-02-15 16:26:32 +00:00
5ce4e13ddd
Configure and fix Style/ClassCheck cop.
2020-02-15 16:26:32 +00:00
6cab5922bc
Configure and fix Metrics/LineLength cop.
...
Set a workable line length for now, and fix a couple of particularly bad
examples.
Also, turn off for the tests.
2020-02-15 16:26:32 +00:00
0df6cb3059
Fix Style/SymbolProc cop.
2020-02-15 16:26:32 +00:00
bb3b4474fa
Fix Style/SpecialGlobalVars cop.
2020-02-15 16:26:32 +00:00
2f993221c0
Fix Style/Next cop.
2020-02-15 16:26:32 +00:00
835843d992
Fix Naming/HeredocDelimiterCase cop.
2020-02-15 16:26:32 +00:00
d42c66ce2c
Fix Style/MultilineWhenThen cop.
2020-02-15 16:26:32 +00:00
2dfe092728
Fix Style/UnpackFirst cop.
2020-02-15 16:26:32 +00:00
4e1b679c73
Fix Style/TrailingCommaInArrayLiteral cop.
2020-02-15 16:26:32 +00:00
2e11a88fd2
Fix Style/StringLiterals cop.
2020-02-15 16:26:32 +00:00
45f4c2dc29
Fix Style/GuardClause cop.
2020-02-15 16:26:32 +00:00
3121ad066f
Fix Style/Alias cop.
2020-02-15 16:26:32 +00:00
468a80ce02
Fix Style/IfInsideElse cop.
2020-02-15 16:26:32 +00:00
b3f241353a
Fix Style/CommentedKeyword cop.
2020-02-15 16:26:32 +00:00
5a1baf46ab
Fix Style/RedundantReturn cop.
2020-02-15 16:26:32 +00:00
61c83b2a1a
Configure Layout/HashAlignment cop.
2020-02-15 16:26:32 +00:00
cfe4972e71
Fix Layout/EmptyLineAfterGuardClause cop.
2020-02-15 16:26:32 +00:00
fff2c41d68
Configure Lint/SuppressedException cop.
...
In the tests we can say "anything goes", but in the main body of the
code we should at least comment if we're not handling an exception
fully.
2020-02-15 16:26:32 +00:00
0d49421711
Fix Lint/UselessAccessModifier cop.
2020-02-15 16:26:32 +00:00
b528cae084
Fix Lint/LiteralAsCondition cop.
...
This fixes Style/InfiniteLoop as a side-effect.
2020-02-15 16:26:32 +00:00
98c6969c18
Fix Layout/SpaceAroundOperators cop.
2020-02-15 16:26:32 +00:00
73e405acef
Fix Security/Open cop errors.
2020-02-15 15:56:17 +00:00
976dbd3408
reverted the change according to comment below:
...
https://github.com/rubyzip/rubyzip/pull/431#discussion_r376698387
2020-02-08 19:54:45 +09:00
b326d17438
use @+ operator instead of #dup to get unfrozen string
2020-02-05 11:40:56 +09:00
3bc85ccdec
fixed frozen error caseud by frozen string literal
2020-02-05 11:30:30 +09:00
f42827e99c
Bump version to 2.2.0
2020-02-01 13:24:50 +00:00
040962a59f
Remove unused error argument
2020-02-01 13:19:15 +00:00
666fb8c03f
Merge pull request #427 from jspanjers/refactor-decompressor
...
Support decompressor plugins
2020-02-01 13:15:03 +00:00
a5d068d3e8
Support Decompressor plugins
2020-01-26 15:34:17 +01:00
2b7268373a
Define compression methods
2020-01-26 15:34:17 +01:00
456bd4d92c
Mimic IO#read return values in Decompressor#read
2020-01-26 15:34:17 +01:00
c66277db58
Rename Decompressor#sysread to #read
2020-01-26 15:34:17 +01:00
00b525d76e
Fix returned outbuf for Inflater#sysread
2020-01-26 15:34:17 +01:00
cda7127107
Add Decompressor#input_stream
2020-01-26 15:34:17 +01:00
5707c52a15
Move PassTruDecompressor#decompressed_size to Decompressor
2020-01-26 15:34:17 +01:00
2bbcec0e34
Cleanup PassTruDecompressor
2020-01-26 15:34:17 +01:00
4ac83737b1
Cleanup Inflater
2020-01-26 15:34:17 +01:00
dd74bc0e73
Cleanup NullDecompressor
2020-01-26 15:34:17 +01:00
b80ce3cc57
Make decryption generic for all compression methods
...
Now, STORED files can be decrypted, just like DEFLATED files.
2020-01-26 15:34:17 +01:00
4e28f7286c
Untangle encryption and decompression
2020-01-26 15:34:17 +01:00
8f7c5caf29
Drop #produce_input from Decompressor class
2020-01-26 15:34:17 +01:00
d20a6834a3
Rework Inflater#produce_input to use sysread
...
This aligns Inflater#produce_input with
PassThruDecompresser#produce_input.
2020-01-26 15:34:17 +01:00
1b6aeb2cd0
Replace Decompressor#input_finished? with #eof
2020-01-26 15:34:17 +01:00
4a4c553b1e
Move :eof from InputStream to AbastractInputStream
2020-01-26 15:34:17 +01:00
e072c57beb
Add Entry#incomplete?
2020-01-26 15:34:17 +01:00
c897bbdf77
Add Entry#encrypted?
2020-01-26 15:34:17 +01:00
0b7b78dc4a
Encapsulate Zlib errors within DecompressionError
2020-01-26 15:34:13 +01:00
f6639f9b55
Bump version to 2.1.0
2020-01-25 18:12:57 +00:00
ee028d2746
UniversalTime: more ruby-like (readable) code.
2019-12-15 22:42:09 +00:00
9849500d73
UniversalTime: correctly parse included timestamps.
...
From the documentation: "...times that are present will appear in the
order indicated, but any combination of times may be omitted. (Creation
time may be present without access time, for example.)"
This fixes the parsing so that the times are read into the correct
fields, according to the flags. Before they were simply assumed to be in
order and all present.
2019-12-15 22:37:29 +00:00
a5e785c737
UniversalTime: better check for size on parse.
2019-12-15 22:26:06 +00:00
65cfd8a9a5
UniversalTime: correctly pack/unpack the timestamps.
...
From the documentation: "The time values are in standard Unix signed-long
format, indicating the number of seconds since 1 January 1970 00:00:00."
The three time values were being unpacked with 'VVV', which is unsigned
32-bit, but they should be unpacked with 'l<l<l<': signed-long little
endian.
2019-12-15 22:26:06 +00:00
b58b97fe23
UniversalTime: correctly set the flags.
...
When a timestamp is set/unset the flags should reflect this.
2019-12-15 22:26:06 +00:00
2d6b6e024b
Ensure File#get/find_entry work consistently.
...
I have switched around the logic somewhat so that `get_entry` calls
`find_entry` and raises an exception if it gets `nil` back.
2019-10-31 18:12:18 +00:00
0f6ca04a9d
Set the default options in `Entry` the same as `File`.
2019-10-31 17:30:14 +00:00
2bdd37d894
Add a convenience method for creating DOSTime instances.
...
DOSTime::from_time creates a DOSTime instance from a vanilla Time
instance.
2019-10-20 19:30:34 +01:00
8c694d38ee
Add functionality to restore file timestamps.
...
There has been an option in `Zip::File` (`:restore_times`) for a long
time, but it seems it has never worked. Firstly the actual timestamp of
an added file wasn't being saved, and secondly an extracted file wasn't
having its timestamp set correctly.
This commit fixes both of those issues, and adds tests to make sure.
2019-10-20 19:30:27 +01:00
378293539d
Make the attr_accessors in File more readable.
...
Note what the default is and that a couple of them will change at some
point soon.
2019-10-19 20:46:21 +01:00
253457545e
Correctly set/default options in the File class.
...
Fixes #395 . Set the options to false for now for consistency.
2019-10-19 20:45:29 +01:00
056c00cb16
Merge pull request #418 from hainesr/open-options
...
Add `options` parameter to `Zip::File.open`.
2019-10-19 17:38:38 +01:00
3fea9958c2
Update comment for `Zip::File.open`.
2019-10-19 07:15:51 +01:00
f58e38012c
Add the `options` parameter to `Zip::File.open`.
2019-10-19 07:04:04 +01:00
935a4f31a2
Make warning messages consistent.
...
And fix a few spelling mistakes.
2019-10-12 12:52:04 +01:00
340379f080
Use `warn` instead of `puts` for messages from the library code.
...
`warn` has the advantage of easily being disabled by, the `-W0` interpreter
flag or setting $VERBOSE to nil.
2019-10-11 19:31:42 +01:00
506d557edc
StreamableStream now uses the OS temp directory.
...
Rather than using the local folder.
Fixes #410
2019-09-27 16:13:56 +01:00
cb407b1065
Bump version to 2.0.0
2019-09-25 21:10:05 +01:00
7c65e1e359
Bump version to 1.3.0
2019-09-25 19:59:24 +01:00
97cb6aefe6
Warn when an entry size is invalid
2019-09-18 18:34:23 +01:00
4167f0ce67
Validate entry sizes when extracting
2019-09-15 15:11:35 +01:00
ecb2776218
Zip::File.add_stored() to add uncompressed files.
...
Adding uncompressed files to a zip archive can be overly complex, so
this convenience method makes it easier.
2019-09-14 13:58:30 +01:00
0d85cb6a49
Bump to 1.2.4
2019-09-06 18:01:30 +01:00
7fbaf1e6c0
Merge pull request #360 from hainesr/fix-open-buffer
...
Fix #280 - `open_buffer` mangles the content of the buffer it is given.
2019-09-05 18:48:39 +01:00
6f0b219265
Merge pull request #393 from rubyzip/v1-2-3
...
Bump version to 1.2.3
2019-05-23 19:33:53 +02:00
fb1c230cac
Bump version to 1.2.3
2019-03-22 18:14:23 +02:00
ad15c3c494
Allow tilde in zip entry names
...
Use absolute_path rather than expand_path to allow tilde to pass through
unchanged. Otherwise, we try to expand it to a home directory.
2019-03-22 16:30:25 +02:00
bb3488723f
Merge pull request #385 from mihyaeru21/remove-commas
...
remove some strange commas
2019-03-21 22:22:32 +02:00
3219d8e5af
Merge pull request #390 from taichi-ishitani/master
...
fixed FrozenError caused by frozen-string-literal
2019-03-21 21:58:17 +02:00
74f0d4eabb
fixed errors caused by frozen-string-literal
2019-02-28 01:23:29 +09:00
a420323c84
require pathname where it is used
2019-02-10 11:51:29 -05:00
afb1b79efd
remove some strange commas
2018-12-04 00:14:32 +09:00
fd81bd523c
Bump version to 1.2.2
2018-08-27 09:07:21 +01:00
cf35774ed6
Bump version to 1.3.0
2018-08-27 09:02:11 +01:00
ffb374c6b1
Bump version to 2.0.0
2018-08-27 08:37:53 +01:00
8a1de58286
Expand from root rather than current working directory
2018-08-26 19:55:26 +01:00
3dd165b494
Disable symlinks and check for path traversal
2018-08-26 14:21:38 +01:00
8e78311d67
Fix CVE-2018-1000544 symlink path traversal
...
Not sure if the exception is the right way to go
2018-08-23 18:14:48 -04:00
6e0d23178a
Fix CVE-2018-1000544 absolute path traversal
...
Small refactor along the way to centralize destination handling when no explicit path is given and a potential malicious one from the zipfile is used
2018-08-23 18:14:48 -04:00
aa6284db7a
When globbing in ZipFSDir, take CWD into account.
2018-04-30 20:06:21 +01:00
1673da744d
Pass glob through from ZipFileNameMapper.
...
Just pass the basic glob straight through to the underlying Zip::File
implementation.
2018-04-30 19:59:02 +01:00
84c208982f
Switch newly created StringIOs to binmode.
...
StringIO objects created within File.open_buffer were not being switched into
binmode, but those passed in were. Fix this inconsistency and add a test.
2018-04-04 16:02:19 +01:00
15ccc25da1
Fix File.open_buffer when no changes are made.
...
Things are now more carefully set up, and if a buffer is passed in which
represents a file that already exists then this is taken into account. All
initialization is now done in File.new, rather than being split between there
and File.open_buffer.
This has also needed a bit of a re-write of Zip::File.initialize. I've tried to
bring some logic to it as a result, and have added comments to explain what is
now happening.
2018-04-04 15:54:12 +01:00
03633933eb
No need to require stringio in Zip::File.open_buffer.
...
It's already required in zip.rb.
2018-04-04 14:31:34 +01:00
cfa9441914
Handle passing an IO to Zip::File.new better.
...
This now actually extracts the path from the IO if one is passed in.
2018-04-03 23:48:54 +01:00
7cd263e6a0
Clean up use of file_name in Zip::File::initialize.
2018-04-03 23:45:04 +01:00
c787d94852
Handle stored files with general purpose bit 3 set
...
Signed-off-by: Sam Coward <scoward@pivotal.io>
2018-04-03 16:07:18 -04:00
05af1231f4
Merge pull request #353 from pnomolos/pnomolos/fix_stringio
...
Added fix for calling 'close' on a StringIO-backed zip file, and specs
2018-03-30 16:58:27 +03:00
ffd0b671b8
Fix regression caused by Rubocop cleanup
...
InputStream:
```
if @current_entry && @current_entry.gp_flags & 8 == 8 && @current_entry.crc == 0 \
&& @current_entry.compressed_size == 0 \
&& @current_entry.empty? && !@internal
```
`Zip::Entry#empty?` doesn't exist, but an automatic Rubocop check thought it should be converted from `size == 0`.
Unfortunately, this is tricky to write a test for as it only fails under some very specific conditions.
2018-02-23 13:22:57 -08:00
792266dbf3
Added fix for calling 'close' on a StringIO-backed zip file, and specs
2018-02-21 11:48:56 -08:00
57c3772d94
Merge pull request #325 from aeroastro/feature/tempfile-directory
...
Save temporary files to a temporary directory
2017-11-08 20:38:22 +02:00
deb6616c5f
Merge branch 'master' into force-entry-names-encoding-option
2017-10-18 19:24:58 +03:00
a9f020c0a0
add option to force entry names encoding
...
if you need to work with existing zip files which contain names with
non-ascii characters then you can specify this option.
Without this option find_entry will not work properly
2017-10-18 18:20:56 +03:00
cf91112b57
Apply automatic correction by rubocop
2017-06-29 11:57:12 +09:00
258ef02914
Save temporary files to a temporary directory
2017-06-27 09:17:55 +09:00
98f4f2ed9b
Version bump
2017-02-08 13:50:16 +02:00
ce4208fdec
Fix #315 and resolve relative path vulnerability
2017-02-08 13:43:14 +02:00
df8dfbcff3
Merge pull request #314 from mwlang/bugfix/open_buffer_without_block
...
allows open_buffer to work without a given block
2017-02-08 13:16:06 +02:00
14b8fed18c
allows open_buffer to work without a given block
2017-01-16 13:24:22 -06:00
960414aff0
Fix warnings: `constant ::Fixnum is deprecated` in Ruby 2.4
2017-01-08 16:41:23 +09:00
a4e3b55bb2
remove tr to support cp932 encoding
2016-12-07 22:35:33 +09:00
a0cf673186
Merge pull request #300 from hainesr/fix-create-perms
...
Fix permissions on new zip files (#294 )
2016-11-09 22:19:04 +02:00
82fa57cc83
Merge pull request #303 from deivid-rodriguez/extended_globbing
...
Extended globbing
2016-11-09 22:17:17 +02:00
579e78f1ef
Update entry.rb
...
Add accessor to @internal_file_attributes
See http://stackoverflow.com/questions/39800771/hot-to-set-binary-flag-in-zip-file-with-rubyzip
2016-10-10 23:04:36 +02:00
9c475f5160
Add extended globbing support
2016-10-08 19:32:53 -03:00
c00d767533
Fix rubocop offence caused by temp files changes.
2016-09-05 17:34:12 +01:00
fc23f68f77
Refactor the create logic in Zip::File.
...
Make the internal @create varible more consistent and actually match the
documentation.
Zip::File::CREATE is now true, rather than 1.
A new test is added to check if passing 1 in still works to ensure backwards
compatibility.
2016-09-05 15:16:57 +01:00
63ed0d970b
Refactor the code which manages temp files.
...
Combine the creation of the temporary filename with the writing to it.
2016-09-05 15:07:18 +01:00
7b14d11c00
Stop using 0600 perms for temporary files.
...
This fixes #294 in what I hope is a more sensible way than trying to mess with
umasks, etc, directly.
Temporary files were being created with 0600 permissions and then being set to
different permissions, based on umask, etc, afterwards. I don't know what the
rationale for this was, but there were errors in the umask calculations when
moving from the temporary file to the intended end result.
2016-09-01 12:10:56 +01:00
3ec40d875d
Version bump
2016-02-19 11:14:57 +02:00
560bf5d432
Merge pull request #259 from mnaberez/remove-tempfile
...
Fix accidental unlink (#185 ) without using ObjectSpace (#252 )
2016-01-05 00:37:53 +02:00
972749c518
Merge pull request #263 from ShockwaveNN/feature/fix-warn-date-tests
...
Add correct test for `Zip.warn_invalid_date` attribute
2016-01-05 00:37:17 +02:00
73bfa5955c
Fix TypeError: can't dup NilClass from EntrySet#dup
2015-12-19 11:26:20 +02:00
73a35d4515
User `warn` method instead `STDERR.puts` to correctly check error in tests
...
See http://stackoverflow.com/questions/34351144/minitest-assert-output-incorrect-check-for-stderr
about this
2015-12-18 16:40:24 +03:00
6e1dea4f66
Fix accidental unlink ( #185 ) without using ObjectSpace ( #252 )
2015-11-22 14:40:59 -08:00
8447f0e230
Fix #252
2015-11-21 12:07:30 +02:00
7a4b8bb048
Fix high memory usage due to Deflater buffering
...
When support for ZipCrypto was added, an internal StringIO buffer was
added to Deflater, in order to fix a decryption bug. While this worked,
it caused unlimited memory growth when compressing large files. The
proper fix is to writer the encryption header in init_next_entry instead
of finalize_current_entry, so the headers are written before any
encrypted data. Because of this fix we can remove the buffering in
Deflater, which keeps memory usage low and allows to stream compressed
data while it is written.
This should fix issue #233 .
2015-10-17 17:06:41 +02:00
77acc03ddb
Fix exception due to calling empty? on nil.
2015-09-30 03:57:21 -04:00
05a9ba3f20
Use duck typing to detect IO-like objects.
2015-09-03 06:16:32 -07:00
a1f75a3ab9
Added error for empty (zero bit) zip file. Added tests for empty and non existant zips
2015-07-27 23:20:59 -07:00
37a5baad96
Accept StringIO in Zip.open_buffer.
2015-07-02 14:17:17 -04:00
9acc50f004
Do something more expected with new file permissions.
...
Instead of inheriting the permissions from the tmp directory, new files should
have permissions that reflect the defaults on the system taking umask into
account.
It seems that (unix) permissions of 666 - umask are as close to a standard as
anything [1] and that 'touch' uses this. On Windows it seems sensible to just
use 644 directly [2].
[1] http://unix.stackexchange.com/a/102080
[2] http://ruby-doc.org/core-1.9.3/File.html
2015-06-24 18:25:22 +01:00
1e99ff69b9
Revert "fix rubocop cop Style/ClassCheck". It cause regression in tests
...
This reverts commit 8c13dfc265
2015-06-08 10:45:23 +03:00
8c13dfc265
fix rubocop cop Style/ClassCheck
2015-06-08 10:36:41 +03:00
4c81b1151a
fix rubocop cop Style/NilComparison
2015-06-08 10:30:12 +03:00
13658b0586
fix rubocop cop Style/NonNilCheck
2015-06-08 10:29:08 +03:00
f7eec2dd76
fix rubocop cop Style/SpaceAroundOperators
2015-06-08 10:26:13 +03:00
c0177a455b
Merge branch 'master' into rubocop_fixes
...
Conflicts:
README.md
samples/example_recursive.rb
2015-06-08 10:14:25 +03:00
d289780072
Fix #234 . Add special variable what is a flag about internal usege
2015-06-07 17:29:54 +03:00
32016ab1bf
Remove executable bit.
2015-03-31 13:15:46 +02:00
2007be0ab6
fix rubocop Lint/UselessAccessModifier cop
2015-03-24 19:47:49 +03:00
fd864bd7ab
fix rubocop Style/CaseEquality cop
2015-03-24 19:44:47 +03:00
96f3997f07
fix rubocop Style/GuardClause cop
2015-03-24 19:33:15 +03:00
ce7e01a206
fix rubocop Style/CommentIndentation cop
2015-03-24 19:31:28 +03:00
784e70be2a
fix rubocop Style/EmptyElse cop
2015-03-24 19:29:07 +03:00
112a77de7c
fix some Style/FormatString cop
2015-03-24 19:20:39 +03:00
b920a1eb49
fix rubocop Style/GuardClause cop
2015-03-24 19:16:03 +03:00
b9aefaffb5
fix rubocop Style/IfUnlessModifier cop
2015-03-24 19:09:22 +03:00
2c8f6f8cbd
fix correct initialization for ExtraField
2015-03-24 19:04:28 +03:00
b1bfb1a216
fix some rubocop Style/ModuleFunction cop
2015-03-23 19:36:47 +03:00
1ba81ff46f
fix rubocop Style/NumericLiterals cop
2015-03-23 19:23:04 +03:00
31fb9d729b
fix rubocop Style/PredicateName cop
2015-03-23 19:18:51 +03:00
f291e1f616
fix rubocop Style/NegatedIf cop
2015-03-23 19:11:32 +03:00
6a7a22fece
fix rubocop Style/MultilineOperationIndentation cop
2015-03-23 19:10:39 +03:00
47b72f5cab
fix rubocop Style/LeadingCommentSpace cop
2015-03-23 19:06:01 +03:00
d5f79822c1
fix rubocop Style/LineEndConcatenation cop
2015-03-23 19:03:28 +03:00
edf3126599
EntrySet.dub fix for code-style
2015-03-23 18:57:56 +03:00
8d6f23ba9a
fix rubocop Style/SpaceAroundOperators cop
2015-03-22 20:03:50 +03:00
5ea5710b18
fix rubocop Style/SpaceBeforeBlockBraces cop
2015-03-22 19:59:33 +03:00
d92d8d652a
fix rubocop Style/SpaceInsideParens cop
2015-03-22 19:56:37 +03:00
b13fafb7e8
fix rubocop Style/StringLiterals cop
2015-03-22 19:54:44 +03:00
b311998e25
fix rubocop Style/SpaceInsideBlockBraces cop
2015-03-22 19:49:07 +03:00
cb143f0cff
fix rubocop Style/SpaceAroundEqualsInParameterDefault cop
2015-03-22 19:45:26 +03:00
77ef05cf84
fix rubocop Style/SpaceAfterNot cop
2015-03-22 19:44:44 +03:00
73e5f70bdf
fix rubocop Style/SpaceAfterMethodName cop
2015-03-22 19:43:44 +03:00
d2b4a528de
fix rubocop Style/SpaceAfterComma cop
2015-03-22 19:41:47 +03:00
707bd44e66
fix rubocop Style/SingleLineMethods cop
2015-03-22 19:37:59 +03:00
735a0553a3
fix rubocop Style/RedundantBegin cop
2015-03-22 19:33:44 +03:00
105c2c71b2
fix rubocop Style/RedundantException cop
2015-03-22 19:32:47 +03:00
abf9cbec23
fix rubocop Style/RedundantSelf cop
2015-03-22 19:30:24 +03:00
225a4f70ce
fix rubocop Style/RedundantReturn cop
2015-03-22 19:27:29 +03:00
06e5a9352d
fix rubocop Style/ParenthesesAroundCondition cop
2015-03-22 19:25:35 +03:00
b730387cf2
redone fixes by rubocop Style/Alias to be in style of https://github.com/bbatsov/ruby-style-guide#alias-method-lexically
2015-03-21 13:14:21 +03:00
da863e4b55
Merge branch 'master' into rubocop_fixes
...
Conflicts:
lib/zip/entry.rb
2015-03-21 11:37:28 +03:00
b93ef1266f
fix rubocop Style/StringLiterals cop
2015-03-21 11:27:44 +03:00
f67cf18e45
fix rubocop Style/EmptyLinesAroundModuleBody cop
2015-03-21 11:22:47 +03:00
b9a757e045
fix rubocop Style/EmptyLinesAroundClassBody cop
2015-03-21 11:21:26 +03:00
eba5fa1983
fix rubocop Style/EmptyLinesAroundAccessModifier cop
2015-03-21 11:19:43 +03:00
d0c8e8df60
fix rubocop Style/EmptyLines cop
2015-03-21 11:19:14 +03:00
6c46c21abb
fix rubocop Style/ColonMethodCall cop
2015-03-21 11:16:06 +03:00
a0da550c22
fix rubocop Style/CaseIndentation cop
2015-03-21 11:12:01 +03:00
d2d8590ef8
fix rubocop Style/Blocks cop
2015-03-21 11:10:37 +03:00
0c6a10e631
fix rubocop Style/AndOr cop
2015-03-21 10:48:05 +03:00
a2afbafacf
fix rubocop Style/AndOr cop
2015-03-21 10:45:46 +03:00
98e6b5d057
fix rubocop Style/AlignParameters cop
2015-03-21 10:44:56 +03:00
bb08213cb7
fix rubocop Style/Alias cop
2015-03-20 23:17:05 +03:00
4ee6d6be39
fix rubocop Lint/UnusedMethodArgument cop
2015-03-20 23:09:41 +03:00
d3e911f04d
fix rubocop Lint/UnusedBlockArgument cop
2015-03-20 23:07:59 +03:00
Robert Haines
Joni Lahtinen
John Lees-Miller
Sebastian Henke
taichi
Jan-Joost Spanjers
David Ryskalczyk
Mihyaeru
Bart de Water
Andrew Meyer
Oleksandr Simonov
Phil
Alexey Sorokin
Takumasa Ochi
mwlang
Koichi ITO
dogatana
Alexander Simonov
knut2
David Rodríguez
Oleksandr Avoiants
Pavel Lobashov
Mike Naberezny
Felix Bünemann
Victor Costan
Seth Kingsley
Claire Pitman
Vít Ondruch
Pavel.Lobashov