Commit Graph

16 Commits

Author SHA1 Message Date
Robert Haines e10badf68e Fix Style/FrozenStringLiteralComment cop. 2021-05-25 21:24:50 +01:00
Robert Haines 4ed35cae94 DosTime#<=> should return `nil` if other is not comparable. 2021-05-17 19:57:16 +01:00
Robert Haines 6e9f2976d1 Add temporary fix for JRuby to workaround Time cmp bug.
Workaround jruby/jruby#6668 until fix is released.

Version 9.2.18.0 is hopefully the version that will fix this, but we can
adjust the version accordingly if not.
2021-05-17 19:55:13 +01:00
Robert Haines 5a4d1d8b6b Replace and deprecate `Zip::DOSTime#dos_equals`.
Having a specific 'does this instance equal another instance' method is
kind of annoying and breaks a number of things. Most obviously it breaks
comparing to `nil`: `nil.dos_equals(other)` will fail where
`nil == other` does not.

So this commit overrides `<=>` in `Zip::DOSTime` and deprecates
`dos_equals`.
2020-11-28 21:19:58 +00:00
Robert Haines aa6ea05d45 Fix Naming/MethodParameterName cop in the library code. 2020-02-29 18:11:52 +00:00
Robert Haines 2bdd37d894 Add a convenience method for creating DOSTime instances.
DOSTime::from_time creates a DOSTime instance from a vanilla Time
instance.
2019-10-20 19:30:34 +01:00
Takumasa Ochi cf91112b57 Apply automatic correction by rubocop 2017-06-29 11:57:12 +09:00
Pavel Lobashov c0177a455b Merge branch 'master' into rubocop_fixes
Conflicts:
	README.md
	samples/example_recursive.rb
2015-06-08 10:14:25 +03:00
Vít Ondruch 32016ab1bf Remove executable bit. 2015-03-31 13:15:46 +02:00
Pavel Lobashov 47b72f5cab fix rubocop Style/LeadingCommentSpace cop 2015-03-23 19:06:01 +03:00
Pavel.Lobashov 8d6f23ba9a fix rubocop Style/SpaceAroundOperators cop 2015-03-22 20:03:50 +03:00
Pavel.Lobashov abf9cbec23 fix rubocop Style/RedundantSelf cop 2015-03-22 19:30:24 +03:00
Pavel Lobashov b9a757e045 fix rubocop Style/EmptyLinesAroundClassBody cop 2015-03-21 11:21:26 +03:00
Alexander Simonov 974f5675c2 Code refactoring start 2013-06-02 21:33:03 +03:00
James Sanders ab99778c37 Add Zip namespace to DOSTime class
In the top level, it conflicts with the archive-zip library's class of
the same name.
2012-03-01 10:30:49 -07:00
Jean Boussier 85054091e8 Get rid of Time extensions 2012-02-01 11:16:13 +01:00