root
/
sftp
mirror of https://github.com/pkg/sftp.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

document why the cast to int can no longer overflow an int

This commit is contained in:
Cassondra Foesch 2021-04-23 08:55:35 +00:00
parent b63107c68c
commit 6b08f4a44a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client.go
View File

@ -1184,6 +1184,7 @@ func (f *File) WriteTo(w io.Writer) (written int64, err error) {
if concurrency64 > uint64(f.c.maxConcurrentRequests) || concurrency64 < 1 {
concurrency64 = uint64(f.c.maxConcurrentRequests)
}
// Now that concurrency64 is saturated to an int value, we know this assignment cannot possibly overflow.
concurrency := int(concurrency64)
cancel := make(chan struct{})
@ -1524,6 +1525,7 @@ func (f *File) readFromConcurrent(r io.Reader, remain int64) (read int64, err er
if concurrency64 > int64(f.c.maxConcurrentRequests) || concurrency64 < 1 {
concurrency64 = int64(f.c.maxConcurrentRequests)
}
// Now that concurrency64 is saturated to an int value, we know this assignment cannot possibly overflow.
concurrency := int(concurrency64)
pool := newBufPool(concurrency, f.c.maxPacket)