Previous code used the request ids to do ordering. This worked until a
client came along that used un-ordered request ids. This reworks the
ordering to use an internal counter (per session) to order all packets
ensuring that responses are sent in the same order as the requests were
received.
Fixes#260
TestCloseOutOfOrder was supposed to test handling the case where the
client sends a write packet after the close packet for that file. It did
this poorly and the test is unneeded as what should happen is an error,
and this is what does happen. The RFC specifies that once the close
packet is sent, that's it and so it should be up to the client to
properly finish writing before closing.
There is a data race with the waitgroup (wg) object used to synchronize
the workers with the server exit. The workers called wg.Add()
asynchronously and it was possible for the Wait() to get hit before any
of the Add() calls were made in certain conditions. I only ever saw this
sporatically in the travis tests.
This fixes it by making the wg.Add() calls synchronous.
The worker/packet mangement code needs to be in the packet manager so
the request-server can utilize it as well. This also improves the
encapsulation of the method as it relied on internal data that should be
better isolated inside the file/struct.
Cassondra Foesch
Nicola Murino
John Eikenberry