root
/
sftp
mirror of https://github.com/pkg/sftp.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity
1,170 Commits 14 Branches 33 Tags 3.9 MiB
Commit Graph

237 Commits

Author SHA1 Message Date
Cassondra Foesch 8a0fc6568b DO NOT close the CopyStderrTo writer 2025-05-30 12:50:06 +00:00
Cassondra Foesch 32bfbbb6c0 I think I prefer this API design 2025-05-23 10:18:29 +00:00
Cassondra Foesch 18192955ef fix ssh subsystem request invocation 2025-05-23 09:21:31 +00:00
Mike Ryan 28eb389db7 perf: ensure full write buffer for *File.ReadFrom 
In `*File.ReadFrom`, ensure that the buffer is filled to capacity (`maxPacket`
length) before performing the write.

Prior to this change, the amount of data read into the buffer was dictated by
the `io.Reader`'s `Read` implementation, and write performance would suffer
when the Read would return less than maxPacket bytes of data. An example
source would be a `net/http` response `Body` from a TLS server, which
seems to cap each read to 16384 bytes -- half the default max packet size of
32768 bytes.
 2025-03-24 08:47:25 -05:00
Cassondra Foesch 19bfb49e71
Merge pull request #618 from pkg/v1-backport-client-remove-and-fsync 
Backport v2/Client.Remove and File.Sync
 2025-03-12 15:08:34 +00:00
cloudsbit 067046a74c fix: readAt() occasional hang in concurrent reads 2025-03-12 08:42:59 +08:00
Cassondra Foesch eea14d0395 if errF and errD are pointers to os.PathError, then they won't compare equal, even when they are 2025-03-04 09:40:55 +00:00
Cassondra Foesch 584399def2 oops, duh 2025-02-27 14:02:29 +00:00
Cassondra Foesch 46608778f5 backport v2/client.Remove; return PathError 2025-02-27 13:52:52 +00:00
Cassondra Foesch a2172dc0b9 short-circuit File.Sync if not supported 2025-02-27 13:51:25 +00:00
Cassondra Foesch 050bb2ea5f Issue #609 - clarify what 'path contains a regular file' actually means 2024-12-30 03:43:58 +00:00
Leonid Emar-Kar 1988803cae update docs with suggested improvements 2024-06-05 10:53:34 +01:00
Leonid Emar-Kar 1629551c5e update ReadFrom and ReadFromWithConcurrency docs 2024-06-04 12:32:01 +01:00
Peter Verraedt 478aa2e956
Add fsetstat variant of SetExtendedData 
Signed-off-by: Peter Verraedt <peter@verraedt.be>
 2024-04-25 16:20:01 +02:00
Peter Verraedt 0814039fdf
Add SetExtendedData to Client 
Add function to set extended attributes in the sftp client.

Signed-off-by: Peter Verraedt <peter@verraedt.be>

Add longer comment

Signed-off-by: Peter Verraedt <peter@verraedt.be>
 2024-04-25 14:53:25 +02:00
dustin-ward 8411183d33 address review set 2 2024-04-05 16:07:40 -04:00
dustin-ward 96b29c55dd address review set 1 2024-04-05 12:37:27 -04:00
dustin-ward 9b553ccfda Add support for zos/s390x 2024-04-04 16:26:47 -04:00
Cassondra Foesch 3ce4d4e6e2 one more race-condition causing return 2024-02-06 08:51:12 +00:00
Cassondra Foesch ba3d6ab7c6 explain mechanics of use-after-close protection 2024-02-06 08:34:51 +00:00
Cassondra Foesch e808920da0 remove unnecessary block, and explain why the one added is necessary 2024-02-06 08:31:27 +00:00
Cassondra Foesch 6c7c0da80c remove warnings about aberrent race detection, I think it was real 2024-02-06 08:27:28 +00:00
Cassondra Foesch 4cd7ff45fc testing an idea 2024-02-06 08:12:54 +00:00
Cassondra Foesch 3df3035b74 new race condition warning, yay 2024-01-19 01:56:44 +00:00
Cassondra Foesch f3501dc6ba address code review 2024-01-19 01:23:22 +00:00
Cassondra Foesch d1903fbd46 rework client to prevent after-close usage, and support perm at open 2024-01-19 00:20:23 +00:00
Erik Unger 3aa53a572f sendPacket with context 2023-11-13 09:13:33 +01:00
Erik Unger 273341d347 added Client.ReadDirContext 2023-11-10 16:46:49 +01:00
tanishq.singhal 78e49babba Check 2023-05-19 11:38:25 +05:30
tanishq.singhal d17dfb25ab Resolve Comments 2023-05-18 22:57:23 +05:30
tanishq.singhal f96a7bef95 Handling error & Test func with working tree 2023-05-15 21:08:16 +05:30
tanishq.singhal 628da3e118 Adding Tests to test the func & resolving comment 2023-05-15 11:43:30 +05:30
tanishq.singhal 0ac5f90dbb Implemented Delete All Resources Function 2023-05-13 13:03:00 +05:30
Cassondra Foesch bd61319b07 refactor sshfx encoding, fix link rot, go fmt 2023-03-27 17:05:24 +00:00
Nick Craig-Wood 8add055936 Stop ReadFromWithConcurrency sending more data than it needs to 
It was discovered that the ReadFrom method for uploading files in
pkg/sftp was sending more data than it needed to.

This was tracked down to the ReadFromWithConcurrency method forgetting
to truncate the packets it was sending to the size Read.

This was giving the remote server more work to do as it was writing
and re-writing parts of a file.

See: https://github.com/rclone/rclone/issues/6763
 2023-02-13 14:18:36 +00:00
Cassondra Foesch aad3ee1c0e an even better error message 2022-07-11 11:34:22 +00:00
Cassondra Foesch cc19e20d72 more context for EOF during client setup 2022-06-29 12:13:03 +00:00
Nicola Murino c7fdf5e5c6 writeToSequential: improve tests for write errors 2022-03-03 12:30:24 +01:00
Hilari Moragrega 65f24bcee4 Improved test with CR feedback 2022-03-03 09:43:16 +01:00
Hilari Moragrega c2c0f6090e Return writer error if not nil in writeSequential 2022-03-03 09:43:11 +01:00
Gleb Teterin dad23755af Fix missing io.EOF when concurency is disabled #489 2022-01-20 07:55:17 +13:00
Cassondra Foesch 84714f9fee sequentially issue write requests, process results concurrently 2021-12-05 13:28:38 +00:00
Cassondra Foesch f525d180b6
Merge pull request #456 from pkg/refactor/regroup-and-lint 
Regroup marshling/unmarshaling and lint
 2021-08-20 22:59:08 +00:00
codesoap 997499abb6 Fix a few misspells 2021-08-20 21:00:33 +02:00
Cassondra Foesch 1b6d816185 remove min function 2021-08-11 13:29:16 +00:00
Cassondra Foesch ba854bee45 collect all marshal/unmarshal functions into packet.go 2021-08-11 11:12:34 +00:00
Nicola Murino eaa697cc21
Merge pull request #441 from CiscoM31/migrate_to_go_errors 
Use go errors instead of github.com/pkg/errors
 2021-07-05 21:28:12 +02:00
Cassondra Foesch ac2cd6e5ca
Merge pull request #447 from alanskind/master 
fix typo
 2021-06-30 17:07:29 +00:00
qianqian 0e4bd2a661 fix typo 2021-06-30 23:09:07 +08:00
Cassondra Foesch 6617a3a1aa [bugfix] short reads indicate EOF 2021-06-28 18:27:13 +00:00