root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Polish "Improve handling of non-standard status codes in RestTemplate metrics" 

See gh-17991
This commit is contained in:
Andy Wilkinson 2019-08-29 13:44:35 +01:00
parent 1acff410a2
commit 0217de4349
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/client/RestTemplateExchangeTagsTests.java
View File

@ -95,7 +95,7 @@ class RestTemplateExchangeTagsTests {
} }
@Test @Test
void outcomeTagIsClientErrorWhenResponseIsNonStandardInKnownSeries() throws IOException { void outcomeTagIsClientErrorWhenResponseIsNonStandardInClientSeries() throws IOException {
ClientHttpResponse response = mock(ClientHttpResponse.class); ClientHttpResponse response = mock(ClientHttpResponse.class);
given(response.getRawStatusCode()).willReturn(490); given(response.getRawStatusCode()).willReturn(490);
Tag tag = RestTemplateExchangeTags.outcome(response); Tag tag = RestTemplateExchangeTags.outcome(response);

2
spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/reactive/client/WebClientExchangeTagsTests.java
View File

@ -148,7 +148,7 @@ class WebClientExchangeTagsTests {
} }
@Test @Test
void outcomeTagIsClientErrorWhenResponseIsNonStandardInKnownSeries() { void outcomeTagIsClientErrorWhenResponseIsNonStandardInClientSeries() {
given(this.response.rawStatusCode()).willReturn(490); given(this.response.rawStatusCode()).willReturn(490);
Tag tag = WebClientExchangeTags.outcome(this.response); Tag tag = WebClientExchangeTags.outcome(this.response);
assertThat(tag.getValue()).isEqualTo("CLIENT_ERROR"); assertThat(tag.getValue()).isEqualTo("CLIENT_ERROR");