root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Polish "Fix scope of CqlSessionBuilder bean" 

See gh-19899
This commit is contained in:
Stephane Nicoll 2020-01-28 14:12:31 +01:00
parent c8105413b9
commit 0516520b7e
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/cassandra/CassandraAutoConfigurationTests.java
View File

@ -45,13 +45,13 @@ class CassandraAutoConfigurationTests {
.withConfiguration(AutoConfigurations.of(CassandraAutoConfiguration.class)); .withConfiguration(AutoConfigurations.of(CassandraAutoConfiguration.class));
@Test @Test
void cqlSessionBuilderThreadSafe() { void cqlSessionBuildHasScopePrototype() {
this.contextRunner.run((context) -> { this.contextRunner.run((context) -> {
CqlIdentifier keyspace = CqlIdentifier.fromCql("test"); CqlIdentifier keyspace = CqlIdentifier.fromCql("test");
assertThat(context).hasSingleBean(CqlSessionBuilder.class); CqlSessionBuilder firstBuilder = context.getBean(CqlSessionBuilder.class);
assertThat(context.getBean(CqlSessionBuilder.class).withKeyspace(keyspace)) assertThat(firstBuilder.withKeyspace(keyspace)).hasFieldOrPropertyWithValue("keyspace", keyspace);
.hasFieldOrPropertyWithValue("keyspace", keyspace); CqlSessionBuilder secondBuilder = context.getBean(CqlSessionBuilder.class);
assertThat(context.getBean(CqlSessionBuilder.class)).hasFieldOrPropertyWithValue("keyspace", null); assertThat(secondBuilder).hasFieldOrPropertyWithValue("keyspace", null);
}); });
} }

2
spring-boot-project/spring-boot-docs/src/docs/asciidoc/spring-boot-features.adoc
View File

@ -4266,6 +4266,8 @@ Generally, you provide `keyspace-name` and `contact-points` as well the local da
You can also register an arbitrary number of beans that implement `DriverConfigLoaderBuilderCustomizer` for more advanced driver customizations. You can also register an arbitrary number of beans that implement `DriverConfigLoaderBuilderCustomizer` for more advanced driver customizations.
The `CqlSession` can be customized with a bean of type `CqlSessionBuilderCustomizer`. The `CqlSession` can be customized with a bean of type `CqlSessionBuilderCustomizer`.
NOTE: If you're using `CqlSessionBuilder` to create multiple `CqlSession` beans, keep in mind the builder is mutable so make sure to inject a fresh copy for each session.
The following code listing shows how to inject a Cassandra bean: The following code listing shows how to inject a Cassandra bean:
[source,java,indent=0] [source,java,indent=0]