From 0ee610842784843fe91021301990a43e6aa7533a Mon Sep 17 00:00:00 2001
From: dreis2211 <christoph.dreis@freenet.de>
Date: Wed, 1 Apr 2020 15:32:09 +0200
Subject: [PATCH] Harmonize issue title for auto-created Docker upgrade issues

See gh-20793
---
 ci/parameters.yml                   |  1 -
 ci/pipeline.yml                     |  2 --
 ci/scripts/create-pull-request.sh   |  1 +
 ci/scripts/detect-docker-updates.sh | 10 +++++-----
 ci/tasks/create-pull-request.yml    |  1 -
 ci/tasks/detect-docker-updates.yml  |  1 -
 6 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/ci/parameters.yml b/ci/parameters.yml
index e39ea64a72d..bdde8a1bf61 100644
--- a/ci/parameters.yml
+++ b/ci/parameters.yml
@@ -1,4 +1,3 @@
-docker-upgrade-issue-title: "Upgrade Docker version in CI"
 email-server: "smtp.svc.pivotal.io"
 email-from: "ci@spring.io"
 email-to: ["spring-boot-dev@pivotal.io"]
diff --git a/ci/pipeline.yml b/ci/pipeline.yml
index 2a7222a9db6..fc48e2d7e3f 100644
--- a/ci/pipeline.yml
+++ b/ci/pipeline.yml
@@ -199,7 +199,6 @@ jobs:
       params:
         GITHUB_REPO: spring-boot
         GITHUB_ORGANIZATION: spring-projects
-        ISSUE_TITLE: ((docker-upgrade-issue-title))
       image: spring-boot-ci-image
     - put: git-repo-ci-docker
       params:
@@ -214,7 +213,6 @@ jobs:
         GITHUB_ORGANIZATION: spring-projects
         GITHUB_PASSWORD: ((github-password))
         GITHUB_USERNAME: ((github-username))
-        ISSUE_TITLE: ((docker-upgrade-issue-title))
       image: spring-boot-ci-image
 - name: build
   serial: true
diff --git a/ci/scripts/create-pull-request.sh b/ci/scripts/create-pull-request.sh
index 63f09db346d..bd6cdb5569a 100755
--- a/ci/scripts/create-pull-request.sh
+++ b/ci/scripts/create-pull-request.sh
@@ -2,6 +2,7 @@
 set -e
 
 if [[ -f commit-details/message ]]; then
+	ISSUE_TITLE="$(cat commit-details/message)"
 	curl \
 	  -s \
 		-u ${GITHUB_USERNAME}:${GITHUB_PASSWORD} \
diff --git a/ci/scripts/detect-docker-updates.sh b/ci/scripts/detect-docker-updates.sh
index 371a4e98cf3..b76feba0c67 100755
--- a/ci/scripts/detect-docker-updates.sh
+++ b/ci/scripts/detect-docker-updates.sh
@@ -1,7 +1,9 @@
 #!/bin/bash
 
-existing_tasks=$( curl -s https://api.github.com/repos/${GITHUB_ORGANIZATION}/${GITHUB_REPO}/pulls\?labels\=type:%20task\&state\=open\&creator\=spring-buildmaster )
-existing_upgrade_issues=$( echo "$existing_tasks" | jq -c --arg TITLE "$ISSUE_TITLE" '.[] | select(.title==$TITLE)' )
+latest_version=$(curl -I -s https://github.com/docker/docker-ce/releases/latest | grep "location:" | awk '{n=split($0, parts, "/"); print substr(parts[n],2);}' | awk '{$1=$1;print}' | tr -d '\r' | tr -d '\n' )
+title_prefix="Upgrade CI to Docker"
+
+existing_upgrade_issues=$( curl -s https://api.github.com/repos/spring-projects/spring-boot/issues\?labels\=type:%20task\&state\=open\&creator\=spring-buildmaster | jq -c --arg TITLE_PREFIX "$title_prefix" '.[] | select(.pull_request != null) | select(.title | startswith($TITLE_PREFIX))' )
 
 if [[ ${existing_upgrade_issues} = "" ]]; then
   git clone git-repo git-repo-updated > /dev/null
@@ -11,8 +13,6 @@ else
   exit 0
 fi
 
-latest_version=$(curl -I -s https://github.com/docker/docker-ce/releases/latest | grep "location:" | awk '{n=split($0, parts, "/"); print substr(parts[n],2);}' | awk '{$1=$1;print}' | tr -d '\r' | tr -d '\n' )
-
 if [[ $latest_version =~ (beta|rc) ]]; then
 	echo "Skip pre-release versions"
 	exit 0;
@@ -31,7 +31,7 @@ git config user.name "Spring Buildmaster" > /dev/null
 git config user.email "buildmaster@springframework.org" > /dev/null
 sed -i "s/version=.*/version=\"$latest_version\"/" ci/images/get-docker-url.sh
 git add ci/images/get-docker-url.sh > /dev/null
-commit_message="Upgrade to Docker $latest_version in CI"
+commit_message="$title_prefix $latest_version"
 git commit -m "$commit_message" > /dev/null
 popd
 echo ${commit_message} > commit-details/message
\ No newline at end of file
diff --git a/ci/tasks/create-pull-request.yml b/ci/tasks/create-pull-request.yml
index f726d32d0ca..c7639b67a68 100644
--- a/ci/tasks/create-pull-request.yml
+++ b/ci/tasks/create-pull-request.yml
@@ -10,6 +10,5 @@ params:
   GITHUB_ORGANIZATION:
   GITHUB_PASSWORD:
   GITHUB_USERNAME:
-  ISSUE_TITLE:
 run:
   path: git-repo/ci/scripts/create-pull-request.sh
diff --git a/ci/tasks/detect-docker-updates.yml b/ci/tasks/detect-docker-updates.yml
index 73000e94496..5c0f606f558 100644
--- a/ci/tasks/detect-docker-updates.yml
+++ b/ci/tasks/detect-docker-updates.yml
@@ -9,6 +9,5 @@ outputs:
 params:
   GITHUB_REPO:
   GITHUB_ORGANIZATION:
-  ISSUE_TITLE:
 run:
   path: git-repo/ci/scripts/detect-docker-updates.sh