root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Polish "Prevent stack overflow when writing Path" 

See gh-44507
This commit is contained in:
Andy Wilkinson 2025-04-16 11:24:45 +01:00
parent a69991b261
commit 175c9d3095
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/json/JsonValueWriter.java
View File

@ -115,7 +115,6 @@ class JsonValueWriter {
throw new UncheckedIOException(ex);
}
}
// https://github.com/spring-projects/spring-boot/issues/44502
else if (value instanceof Path p) {
writeString(p.toString());
}

12
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/json/JsonValueWriterTests.java
View File

@ -241,16 +241,14 @@ class JsonValueWriterTests {
.isThrownBy(() -> valueWriter.end(Series.ARRAY)));
}
// https://github.com/spring-projects/spring-boot/issues/44502
@Test
@Test // gh-44502
void writeJavaNioPathWhenSingleElementShouldBeSerializedAsString() {
assertThat(doWrite((valueWriter) -> valueWriter.write(Path.of("overflow")))).isEqualTo(quoted("overflow"));
assertThat(doWrite((valueWriter) -> valueWriter.write(Path.of("a")))).isEqualTo(quoted("a"));
}
@Test
void writeJavaNioPathShouldShouldBeSerializedAsString() {
assertThat(doWrite((valueWriter) -> valueWriter.write(Path.of("stack/overflow/error"))))
.isEqualTo(quoted("stack\\/overflow\\/error"));
@Test // gh-44502
void writeJavaNioPathShouldBeSerializedAsString() {
assertThat(doWrite((valueWriter) -> valueWriter.write(Path.of("a/b/c")))).isEqualTo(quoted("a\\/b\\/c"));
}
private <V> String write(V value) {