Polish “Configure Kotlin compiler to use -java-parameters by default”

Closes gh-12641
This commit is contained in:
Andy Wilkinson 2018-03-28 12:21:22 +01:00
parent 5e2726f896
commit 1f35abacd6
4 changed files with 11 additions and 8 deletions

View File

@ -532,10 +532,12 @@ JSON request body. When exposed via JMX, the parameters are mapped to the parame
the MBean's operations. Parameters are required by default. They can be made optional
by annotating them with `@org.springframework.lang.Nullable`.
NOTE: To allow the input to be mapped to the operation method's parameters, java code
implementing an endpoint should be compiled with `-parameters`, and kotlin code should
be compiled with `-java-parameters`. This will happen automatically if you are using
Spring Boot's Gradle plugin or if you are using Maven and `spring-boot-starter-parent`.
NOTE: To allow the input to be mapped to the operation method's parameters, Java code
implementing an endpoint should be compiled with `-parameters`, and Kotlin code
implementing an endpoint should be compiled with `-java-parameters`. This will happen
automatically if you are using Spring Boot's Gradle plugin or if you are using Maven and
`spring-boot-starter-parent`.
[[production-ready-endpoints-custom-input-conversion]]

View File

@ -24,7 +24,7 @@ plugin:
the `bootJar` task.
6. Configures any `JavaCompile` tasks with no configured encoding to use `UTF-8`.
7. Configures any `JavaCompile` tasks to use the `-parameters` compiler argument.
8. Configures any `KotlinCompile` tasks to use the `-java-parameters` compiler argument.
[[reacting-to-other-plugins-kotlin]]
@ -36,6 +36,7 @@ plugin:
1. Aligns the Kotlin version used in Spring Boot's dependency management with the version
of the plugin. This is achieved by setting the `kotlin.version` property with a value
that matches the version of the Kotlin plugin.
2. Configures any `KotlinCompile` tasks to use the `-java-parameters` compiler argument.

View File

@ -44,9 +44,8 @@ class KotlinPluginAction implements PluginApplicationAction {
}
private void enableJavaParametersOption(Project project) {
project.getTasks().withType(KotlinCompile.class, (compile) -> {
compile.getKotlinOptions().setJavaParameters(true);
});
project.getTasks().withType(KotlinCompile.class,
(compile) -> compile.getKotlinOptions().setJavaParameters(true));
}
@Override

View File

@ -65,4 +65,5 @@ public class KotlinPluginActionIntegrationTests {
.contains("compileKotlin java parameters: false")
.contains("compileTestKotlin java parameters: false");
}
}