root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Remove superflous `if` in MockitoPostProcessor 

The `if` in registerSpies() is not required as it's covered by the
Assert check.

Closes gh-5889
This commit is contained in:
Johnny Lim 2016-05-08 19:42:05 +09:00 committed by Phillip Webb
parent 6cdbdf9ad3
commit 29898c73d3
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/MockitoPostProcessor.java
View File

@ -246,12 +246,10 @@ public class MockitoPostProcessor extends InstantiationAwareBeanPostProcessorAda
private void registerSpies(SpyDefinition definition, Field field, private void registerSpies(SpyDefinition definition, Field field,
String[] existingBeans) { String[] existingBeans) {
if (field != null) {
Assert.state(field == null || existingBeans.length == 1, Assert.state(field == null || existingBeans.length == 1,
"Unable to register spy bean " + definition.getClassToSpy().getName() "Unable to register spy bean " + definition.getClassToSpy().getName()
+ " expected a single existing bean to replace but found " + " expected a single existing bean to replace but found "
+ new TreeSet<String>(Arrays.asList(existingBeans))); + new TreeSet<String>(Arrays.asList(existingBeans)));
}
for (String beanName : existingBeans) { for (String beanName : existingBeans) {
registerSpy(definition, field, beanName); registerSpy(definition, field, beanName);
} }