root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Merge branch '2.0.x'

This commit is contained in:
Andy Wilkinson 2018-11-23 16:59:27 +00:00
parent 1797040e1a 3331fa2d02
commit 35cce76ae8
2 changed files with 41 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/servlet/context/ServletWebServerApplicationContext.java
View File

@ -55,6 +55,7 @@ import org.springframework.web.context.WebApplicationContext;
import org.springframework.web.context.support.GenericWebApplicationContext; import org.springframework.web.context.support.GenericWebApplicationContext;
import org.springframework.web.context.support.ServletContextAwareProcessor; import org.springframework.web.context.support.ServletContextAwareProcessor;
import org.springframework.web.context.support.ServletContextResource; import org.springframework.web.context.support.ServletContextResource;
import org.springframework.web.context.support.ServletContextScope;
import org.springframework.web.context.support.WebApplicationContextUtils; import org.springframework.web.context.support.WebApplicationContextUtils;
/** /**
@ -132,7 +133,7 @@ public class ServletWebServerApplicationContext extends GenericWebApplicationCon
beanFactory.addBeanPostProcessor( beanFactory.addBeanPostProcessor(
new WebApplicationContextServletContextAwareProcessor(this)); new WebApplicationContextServletContextAwareProcessor(this));
beanFactory.ignoreDependencyInterface(ServletContextAware.class); beanFactory.ignoreDependencyInterface(ServletContextAware.class);
registerWebApplicationScopes(null); registerWebApplicationScopes();
} }
@Override @Override
@ -227,7 +228,7 @@ public class ServletWebServerApplicationContext extends GenericWebApplicationCon
private void selfInitialize(ServletContext servletContext) throws ServletException { private void selfInitialize(ServletContext servletContext) throws ServletException {
prepareWebApplicationContext(servletContext); prepareWebApplicationContext(servletContext);
registerWebApplicationScopes(servletContext); registerApplicationScope(servletContext);
WebApplicationContextUtils.registerEnvironmentBeans(getBeanFactory(), WebApplicationContextUtils.registerEnvironmentBeans(getBeanFactory(),
servletContext); servletContext);
for (ServletContextInitializer beans : getServletContextInitializerBeans()) { for (ServletContextInitializer beans : getServletContextInitializerBeans()) {
@ -235,11 +236,17 @@ public class ServletWebServerApplicationContext extends GenericWebApplicationCon
} }
} }
private void registerWebApplicationScopes(ServletContext servletContext) { private void registerApplicationScope(ServletContext servletContext) {
ServletContextScope appScope = new ServletContextScope(servletContext);
getBeanFactory().registerScope(WebApplicationContext.SCOPE_APPLICATION, appScope);
// Register as ServletContext attribute, for ContextCleanupListener to detect it.
servletContext.setAttribute(ServletContextScope.class.getName(), appScope);
}
private void registerWebApplicationScopes() {
ExistingWebApplicationScopes existingScopes = new ExistingWebApplicationScopes( ExistingWebApplicationScopes existingScopes = new ExistingWebApplicationScopes(
getBeanFactory()); getBeanFactory());
WebApplicationContextUtils.registerWebApplicationScopes(getBeanFactory(), WebApplicationContextUtils.registerWebApplicationScopes(getBeanFactory());
servletContext);
existingScopes.restore(); existingScopes.restore();
} }

29
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/context/ServletWebServerApplicationContextTests.java
View File

@ -47,6 +47,7 @@ import org.springframework.beans.factory.config.ConstructorArgumentValues;
import org.springframework.beans.factory.config.Scope; import org.springframework.beans.factory.config.Scope;
import org.springframework.beans.factory.support.AbstractBeanDefinition; import org.springframework.beans.factory.support.AbstractBeanDefinition;
import org.springframework.beans.factory.support.RootBeanDefinition; import org.springframework.beans.factory.support.RootBeanDefinition;
import org.springframework.boot.testsupport.rule.OutputCapture;
import org.springframework.boot.web.context.ServerPortInfoApplicationContextInitializer; import org.springframework.boot.web.context.ServerPortInfoApplicationContextInitializer;
import org.springframework.boot.web.servlet.DelegatingFilterProxyRegistrationBean; import org.springframework.boot.web.servlet.DelegatingFilterProxyRegistrationBean;
import org.springframework.boot.web.servlet.FilterRegistrationBean; import org.springframework.boot.web.servlet.FilterRegistrationBean;
@ -91,6 +92,9 @@ public class ServletWebServerApplicationContextTests {
private ServletWebServerApplicationContext context; private ServletWebServerApplicationContext context;
@Rule
public OutputCapture output = new OutputCapture();
@Captor @Captor
private ArgumentCaptor<Filter> filterCaptor; private ArgumentCaptor<Filter> filterCaptor;
@ -463,6 +467,7 @@ public class ServletWebServerApplicationContextTests {
@Test @Test
public void servletRequestCanBeInjectedEarly() throws Exception { public void servletRequestCanBeInjectedEarly() throws Exception {
// gh-14990 // gh-14990
int initialOutputLength = this.output.toString().length();
addWebServerFactoryBean(); addWebServerFactoryBean();
RootBeanDefinition beanDefinition = new RootBeanDefinition( RootBeanDefinition beanDefinition = new RootBeanDefinition(
WithAutowiredServletRequest.class); WithAutowiredServletRequest.class);
@ -481,6 +486,16 @@ public class ServletWebServerApplicationContextTests {
}); });
this.context.refresh(); this.context.refresh();
String output = this.output.toString().substring(initialOutputLength);
assertThat(output).doesNotContain("Replacing scope");
}
@Test
public void webApplicationScopeIsRegistered() throws Exception {
addWebServerFactoryBean();
this.context.refresh();
assertThat(this.context.getBeanFactory()
.getRegisteredScope(WebApplicationContext.SCOPE_APPLICATION)).isNotNull();
} }
private void addWebServerFactoryBean() { private void addWebServerFactoryBean() {
@ -549,4 +564,18 @@ public class ServletWebServerApplicationContextTests {
} }
protected static class WithAutowiredServletContext {
private final ServletContext context;
public WithAutowiredServletContext(ServletContext context) {
this.context = context;
}
public ServletContext getContext() {
return this.context;
}
}
} }