Respect 'primary' flag when replacing databases
Update TestDatabaseAutoConfiguration to ensure that the the `primary` flag of the `BeanDefinition` is copied. Closes gh-7217
This commit is contained in:
parent
dbf6d3d418
commit
39d5881bf2
|
@ -101,15 +101,20 @@ public class TestDatabaseAutoConfiguration {
|
||||||
ConfigurableListableBeanFactory beanFactory) {
|
ConfigurableListableBeanFactory beanFactory) {
|
||||||
BeanDefinitionHolder holder = getDataSourceBeanDefinition(beanFactory);
|
BeanDefinitionHolder holder = getDataSourceBeanDefinition(beanFactory);
|
||||||
if (holder != null) {
|
if (holder != null) {
|
||||||
logger.info("Replacing '" + holder.getBeanName()
|
String beanName = holder.getBeanName();
|
||||||
+ "' DataSource bean with embedded version");
|
boolean primary = holder.getBeanDefinition().isPrimary();
|
||||||
registry.registerBeanDefinition(holder.getBeanName(),
|
logger.info("Replacing '" + beanName + "' DataSource bean with "
|
||||||
createEmbeddedBeanDefinition());
|
+ (primary ? "primary " : "") + "embedded version");
|
||||||
|
registry.registerBeanDefinition(beanName,
|
||||||
|
createEmbeddedBeanDefinition(primary));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private BeanDefinition createEmbeddedBeanDefinition() {
|
private BeanDefinition createEmbeddedBeanDefinition(boolean primary) {
|
||||||
return new RootBeanDefinition(EmbeddedDataSourceFactoryBean.class);
|
BeanDefinition beanDefinition = new RootBeanDefinition(
|
||||||
|
EmbeddedDataSourceFactoryBean.class);
|
||||||
|
beanDefinition.setPrimary(primary);
|
||||||
|
return beanDefinition;
|
||||||
}
|
}
|
||||||
|
|
||||||
private BeanDefinitionHolder getDataSourceBeanDefinition(
|
private BeanDefinitionHolder getDataSourceBeanDefinition(
|
||||||
|
|
|
@ -0,0 +1,92 @@
|
||||||
|
/*
|
||||||
|
* Copyright 2012-2016 the original author or authors.
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package org.springframework.boot.test.autoconfigure.orm.jpa;
|
||||||
|
|
||||||
|
import javax.sql.DataSource;
|
||||||
|
|
||||||
|
import org.junit.Test;
|
||||||
|
import org.junit.runner.RunWith;
|
||||||
|
|
||||||
|
import org.springframework.beans.factory.annotation.Autowired;
|
||||||
|
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
|
||||||
|
import org.springframework.context.annotation.Bean;
|
||||||
|
import org.springframework.context.annotation.Configuration;
|
||||||
|
import org.springframework.context.annotation.Primary;
|
||||||
|
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseBuilder;
|
||||||
|
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseType;
|
||||||
|
import org.springframework.test.context.junit4.SpringRunner;
|
||||||
|
|
||||||
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Integration tests for {@link AutoConfigureTestDatabase} when there are multiple
|
||||||
|
* datasources.
|
||||||
|
*
|
||||||
|
* @author Greg Potter
|
||||||
|
*/
|
||||||
|
@RunWith(SpringRunner.class)
|
||||||
|
@DataJpaTest
|
||||||
|
@AutoConfigureTestDatabase
|
||||||
|
public class AutoConfigureTestDatabaseWithMultipleDatasourcesIntegrationTests {
|
||||||
|
|
||||||
|
@Autowired
|
||||||
|
private TestEntityManager entities;
|
||||||
|
|
||||||
|
@Autowired
|
||||||
|
private ExampleRepository repository;
|
||||||
|
|
||||||
|
@Autowired
|
||||||
|
private DataSource dataSource;
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testRepository() throws Exception {
|
||||||
|
this.entities.persist(new ExampleEntity("boot", "124"));
|
||||||
|
this.entities.flush();
|
||||||
|
ExampleEntity found = this.repository.findByReference("124");
|
||||||
|
assertThat(found.getName()).isEqualTo("boot");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void replacesDefinedDataSourceWithExplicit() throws Exception {
|
||||||
|
// Look that the datasource is replaced with an H2 DB.
|
||||||
|
String product = this.dataSource.getConnection().getMetaData()
|
||||||
|
.getDatabaseProductName();
|
||||||
|
assertThat(product).startsWith("H2");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Configuration
|
||||||
|
@EnableAutoConfiguration
|
||||||
|
static class Config {
|
||||||
|
|
||||||
|
@Bean
|
||||||
|
@Primary
|
||||||
|
public DataSource dataSource() {
|
||||||
|
EmbeddedDatabaseBuilder builder = new EmbeddedDatabaseBuilder()
|
||||||
|
.setType(EmbeddedDatabaseType.HSQL);
|
||||||
|
return builder.build();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Bean
|
||||||
|
public DataSource secondaryDataSource() {
|
||||||
|
EmbeddedDatabaseBuilder builder = new EmbeddedDatabaseBuilder()
|
||||||
|
.setType(EmbeddedDatabaseType.HSQL);
|
||||||
|
return builder.build();
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
Loading…
Reference in New Issue