diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/web/client/ClientObservationConventionAdapter.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/web/client/ClientObservationConventionAdapter.java index 0653a39a4bc..130b92c4a65 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/web/client/ClientObservationConventionAdapter.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/web/client/ClientObservationConventionAdapter.java @@ -55,8 +55,7 @@ class ClientObservationConventionAdapter implements ClientObservationConvention public KeyValues getLowCardinalityKeyValues(ClientObservationContext context) { KeyValues keyValues = KeyValues.empty(); mutateClientRequest(context); - Iterable tags = this.tagsProvider.tags(context.getCarrier(), context.getResponse(), - context.getError().orElse(null)); + Iterable tags = this.tagsProvider.tags(context.getCarrier(), context.getResponse(), context.getError()); for (Tag tag : tags) { keyValues = keyValues.and(tag.getKey(), tag.getValue()); } diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/observation/ObservationAutoConfigurationTests.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/observation/ObservationAutoConfigurationTests.java index 7eedca9c695..4321f666561 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/observation/ObservationAutoConfigurationTests.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/observation/ObservationAutoConfigurationTests.java @@ -98,7 +98,7 @@ class ObservationAutoConfigurationTests { this.contextRunner.withUserConfiguration(CustomGlobalObservationConvention.class).run((context) -> { ObservationRegistry observationRegistry = context.getBean(ObservationRegistry.class); Context micrometerContext = new Context(); - Observation.start("test-observation", micrometerContext, observationRegistry).stop(); + Observation.start("test-observation", () -> micrometerContext, observationRegistry).stop(); assertThat(micrometerContext.getAllKeyValues()).containsExactly(KeyValue.of("key1", "value1")); }); } @@ -129,7 +129,7 @@ class ObservationAutoConfigurationTests { ObservationRegistry observationRegistry = context.getBean(ObservationRegistry.class); List> handlers = context.getBean(CalledHandlers.class).getCalledHandlers(); CustomContext customContext = new CustomContext(); - Observation.start("test-observation", customContext, observationRegistry); + Observation.start("test-observation", () -> customContext, observationRegistry); assertThat(handlers).hasSize(1); assertThat(handlers.get(0)).isInstanceOf(ObservationHandlerWithCustomContext.class); }); diff --git a/spring-boot-project/spring-boot-dependencies/build.gradle b/spring-boot-project/spring-boot-dependencies/build.gradle index 31b041421dd..9fe79b7c93a 100644 --- a/spring-boot-project/spring-boot-dependencies/build.gradle +++ b/spring-boot-project/spring-boot-dependencies/build.gradle @@ -1019,7 +1019,7 @@ bom { ] } } - library("Micrometer", "1.10.0-M6") { + library("Micrometer", "1.10.0-SNAPSHOT") { group("io.micrometer") { modules = [ "micrometer-registry-stackdriver" {