root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 15 Packages Projects Releases Wiki Activity

Merge pull request #21394 from dreis2211 

* pr/21394:
  Polish "Calculate hashCode only once in ConfigurationPropertyName"
  Calculate hashCode only once in ConfigurationPropertyName

Closes gh-21394
This commit is contained in:
Stephane Nicoll 2020-05-12 10:16:18 +02:00
parent df25603bc9 dd053074f8
commit 46f353461b
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/properties/source/ConfigurationPropertyName.java
View File

@ -444,6 +444,7 @@ public final class ConfigurationPropertyName implements Comparable<Configuration
} }
hashCode = 31 * hashCode + elementHashCode; hashCode = 31 * hashCode + elementHashCode;
} }
this.hashCode = hashCode;
} }
return hashCode; return hashCode;
} }

7
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/properties/source/ConfigurationPropertyNameTests.java
View File

@ -619,4 +619,11 @@ class ConfigurationPropertyNameTests {
assertThat(ConfigurationPropertyName.isValid("foo!bar")).isFalse(); assertThat(ConfigurationPropertyName.isValid("foo!bar")).isFalse();
} }
@Test
void hashCodeIsStored() {
ConfigurationPropertyName name = ConfigurationPropertyName.of("hash.code");
int hashCode = name.hashCode();
assertThat(name).hasFieldOrPropertyWithValue("hashCode", hashCode);
}
} }