root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Lazy initialize JacksonJsonParser ObjectMapper 

Update `JacksonJsonParser` to that the `ObjectMapper` is only
initialized on first use. This performance optimization helps with
startup times if nothing uses the parser.

Fixes gh-8074
This commit is contained in:
Phillip Webb 2017-01-21 07:05:27 -08:00
parent cfd5a73b64
commit 49fc727706
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
spring-boot/src/main/java/org/springframework/boot/json/JacksonJsonParser.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2012-2016 the original author or authors. * Copyright 2012-2017 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -34,12 +34,12 @@ public class JacksonJsonParser implements JsonParser {
private static final TypeReference<?> LIST_TYPE = new ListTypeReference(); private static final TypeReference<?> LIST_TYPE = new ListTypeReference();
private final ObjectMapper objectMapper = new ObjectMapper(); private ObjectMapper objectMapper; // Late binding
@Override @Override
public Map<String, Object> parseMap(String json) { public Map<String, Object> parseMap(String json) {
try { try {
return this.objectMapper.readValue(json, MAP_TYPE); return getObjectMapper().readValue(json, MAP_TYPE);
} }
catch (Exception ex) { catch (Exception ex) {
throw new IllegalArgumentException("Cannot parse JSON", ex); throw new IllegalArgumentException("Cannot parse JSON", ex);
@ -49,13 +49,20 @@ public class JacksonJsonParser implements JsonParser {
@Override @Override
public List<Object> parseList(String json) { public List<Object> parseList(String json) {
try { try {
return this.objectMapper.readValue(json, LIST_TYPE); return getObjectMapper().readValue(json, LIST_TYPE);
} }
catch (Exception ex) { catch (Exception ex) {
throw new IllegalArgumentException("Cannot parse JSON", ex); throw new IllegalArgumentException("Cannot parse JSON", ex);
} }
} }
private ObjectMapper getObjectMapper() {
if (this.objectMapper == null) {
this.objectMapper = new ObjectMapper();
}
return this.objectMapper;
}
private static class MapTypeReference extends TypeReference<Map<String, Object>> { private static class MapTypeReference extends TypeReference<Map<String, Object>> {
}; };