From 4a738e3c49daeb80d19bc58df4ee1040844f154b Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Tue, 5 Mar 2019 11:53:49 +0900 Subject: [PATCH] Polish Closes gh-16094 --- .../spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc | 2 +- .../boot/logging/logback/LogbackLoggingSystemTests.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-boot-project/spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc b/spring-boot-project/spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc index 4edabb55f14..aa5b41bdc18 100644 --- a/spring-boot-project/spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc +++ b/spring-boot-project/spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc @@ -767,7 +767,7 @@ special classloader, then it is considered a "`production application`". If that apply to you (i.e. if you run your application from a container), consider excluding devtools or set the `-Dspring.devtools.restart.enabled=false` system property. -TIP: Flagging the dependency as optional in Maven or using a custom`developmentOnly` +TIP: Flagging the dependency as optional in Maven or using a custom `developmentOnly` configuration in Gradle (as shown above) is a best practice that prevents devtools from being transitively applied to other modules that use your project. diff --git a/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/logback/LogbackLoggingSystemTests.java b/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/logback/LogbackLoggingSystemTests.java index 9e89a5310bc..0fa1d7e7af6 100644 --- a/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/logback/LogbackLoggingSystemTests.java +++ b/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/logback/LogbackLoggingSystemTests.java @@ -471,7 +471,7 @@ public class LogbackLoggingSystemTests extends AbstractLoggingSystemTests { testTotalSizeCapProperty(String.valueOf(10 * 1024 * 1024), "10 MB"); } - private void testTotalSizeCapProperty(String sizeValue, String expectFileSize) { + private void testTotalSizeCapProperty(String sizeValue, String expectedFileSize) { MockEnvironment environment = new MockEnvironment(); environment.setProperty("logging.file.total-size-cap", sizeValue); LoggingInitializationContext loggingInitializationContext = new LoggingInitializationContext( @@ -482,7 +482,7 @@ public class LogbackLoggingSystemTests extends AbstractLoggingSystemTests { this.logger.info("Hello world"); assertThat(getLineWithText(file, "Hello world")).contains("INFO"); assertThat(ReflectionTestUtils.getField(getRollingPolicy(), "totalSizeCap") - .toString()).isEqualTo(expectFileSize); + .toString()).isEqualTo(expectedFileSize); } @Test