Prevent duplicate DynamicPropertyRegistry beans

Remove the Spring Framework registered `DynamicPropertyRegistry` when
using Testcontainers.

See gh-41839
This commit is contained in:
Phillip Webb 2024-08-21 21:04:13 -07:00
parent c3ed545ffd
commit 4d4b189cce
2 changed files with 78 additions and 0 deletions

View File

@ -0,0 +1,56 @@
/*
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.boot.testcontainers.properties;
import org.junit.jupiter.api.Test;
import org.springframework.boot.SpringBootConfiguration;
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.boot.test.context.TestConfiguration;
import org.springframework.boot.testcontainers.properties.TestcontainersPropertySourceAutoConfigurationWithSpringBootTestIntegrationTest.TestConfig;
import org.springframework.context.annotation.Bean;
import org.springframework.test.context.DynamicPropertyRegistry;
/**
* Tests for {@link TestcontainersPropertySourceAutoConfiguration} when combined with
* {@link SpringBootTest @SpringBootTest}.
*
* @author Phillip Webb
*/
@SpringBootTest(classes = TestConfig.class)
class TestcontainersPropertySourceAutoConfigurationWithSpringBootTestIntegrationTest {
@Test
void injectsRegistry() {
}
@TestConfiguration
@ImportAutoConfiguration(TestcontainersPropertySourceAutoConfiguration.class)
@SpringBootConfiguration
static class TestConfig {
@Bean
String example(DynamicPropertyRegistry registry) {
registry.add("test", () -> "test");
return "Hello";
}
}
}

View File

@ -16,6 +16,10 @@
package org.springframework.boot.testcontainers.properties;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.beans.factory.support.DefaultSingletonBeanRegistry;
import org.springframework.boot.autoconfigure.AutoConfiguration;
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import org.springframework.context.ConfigurableApplicationContext;
@ -39,9 +43,27 @@ public class TestcontainersPropertySourceAutoConfiguration {
TestcontainersPropertySourceAutoConfiguration() {
}
@Bean
static RemoveTestDynamicPropertyRegistryBeanPostProcessor removeTestDynamicPropertyRegistryBeanPostProcessor() {
return new RemoveTestDynamicPropertyRegistryBeanPostProcessor();
}
@Bean
static DynamicPropertyRegistry dynamicPropertyRegistry(ConfigurableApplicationContext applicationContext) {
return TestcontainersPropertySource.attach(applicationContext);
}
static class RemoveTestDynamicPropertyRegistryBeanPostProcessor implements BeanFactoryPostProcessor {
@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {
if (beanFactory instanceof DefaultSingletonBeanRegistry singletonBeanRegistry) {
singletonBeanRegistry
.destroySingleton("org.springframework.test.context.support.DynamicPropertiesContextCustomizer"
+ ".dynamicPropertyRegistry");
}
}
}
}