Fix default security options for bootBuildImage task
Fixes gh-39830
This commit is contained in:
parent
8392a7e47c
commit
4e5cd2c2fd
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2012-2023 the original author or authors.
|
* Copyright 2012-2024 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
@ -99,6 +99,7 @@ public abstract class BootBuildImage extends DefaultTask {
|
||||||
this.launchCache = getProject().getObjects().newInstance(CacheSpec.class);
|
this.launchCache = getProject().getObjects().newInstance(CacheSpec.class);
|
||||||
this.docker = getProject().getObjects().newInstance(DockerSpec.class);
|
this.docker = getProject().getObjects().newInstance(DockerSpec.class);
|
||||||
this.pullPolicy = getProject().getObjects().property(PullPolicy.class);
|
this.pullPolicy = getProject().getObjects().property(PullPolicy.class);
|
||||||
|
getSecurityOptions().convention((Iterable<? extends String>) null);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -464,9 +465,11 @@ public abstract class BootBuildImage extends DefaultTask {
|
||||||
}
|
}
|
||||||
|
|
||||||
private BuildRequest customizeSecurityOptions(BuildRequest request) {
|
private BuildRequest customizeSecurityOptions(BuildRequest request) {
|
||||||
List<String> securityOptions = getSecurityOptions().getOrNull();
|
if (getSecurityOptions().isPresent()) {
|
||||||
if (securityOptions != null) {
|
List<String> securityOptions = getSecurityOptions().getOrNull();
|
||||||
return request.withSecurityOptions(securityOptions);
|
if (securityOptions != null) {
|
||||||
|
return request.withSecurityOptions(securityOptions);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
return request;
|
return request;
|
||||||
}
|
}
|
||||||
|
|
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2012-2023 the original author or authors.
|
* Copyright 2012-2024 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
@ -18,6 +18,7 @@ package org.springframework.boot.gradle.tasks.bundling;
|
||||||
|
|
||||||
import java.io.File;
|
import java.io.File;
|
||||||
import java.util.Arrays;
|
import java.util.Arrays;
|
||||||
|
import java.util.Collections;
|
||||||
import java.util.HashMap;
|
import java.util.HashMap;
|
||||||
import java.util.Map;
|
import java.util.Map;
|
||||||
|
|
||||||
|
@ -294,4 +295,23 @@ class BootBuildImageTests {
|
||||||
ImageReference.of("example.com/my-app:0.0.1-SNAPSHOT"), ImageReference.of("example.com/my-app:latest"));
|
ImageReference.of("example.com/my-app:0.0.1-SNAPSHOT"), ImageReference.of("example.com/my-app:latest"));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void whenSecurityOptionsAreNotConfiguredThenRequestHasNoSecurityOptions() {
|
||||||
|
assertThat(this.buildImage.createRequest().getSecurityOptions()).isNull();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void whenSecurityOptionsAreEmptyThenRequestHasEmptySecurityOptions() {
|
||||||
|
this.buildImage.getSecurityOptions().set(Collections.emptyList());
|
||||||
|
assertThat(this.buildImage.createRequest().getSecurityOptions()).isEmpty();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void whenSecurityOptionsAreConfiguredThenRequestHasSecurityOptions() {
|
||||||
|
this.buildImage.getSecurityOptions().add("label=user:USER");
|
||||||
|
this.buildImage.getSecurityOptions().add("label=role:ROLE");
|
||||||
|
assertThat(this.buildImage.createRequest().getSecurityOptions()).containsExactly("label=user:USER",
|
||||||
|
"label=role:ROLE");
|
||||||
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2012-2023 the original author or authors.
|
* Copyright 2012-2024 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
@ -235,6 +235,13 @@ class ImageTests {
|
||||||
assertThat(request.getApplicationDirectory()).isEqualTo("/application");
|
assertThat(request.getApplicationDirectory()).isEqualTo("/application");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void getBuildRequestWhenHasNoSecurityOptionsUsesNoSecurityOptions() {
|
||||||
|
Image image = new Image();
|
||||||
|
BuildRequest request = image.getBuildRequest(createArtifact(), mockApplicationContent());
|
||||||
|
assertThat(request.getSecurityOptions()).isNull();
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
void getBuildRequestWhenHasSecurityOptionsUsesSecurityOptions() {
|
void getBuildRequestWhenHasSecurityOptionsUsesSecurityOptions() {
|
||||||
Image image = new Image();
|
Image image = new Image();
|
||||||
|
|
Loading…
Reference in New Issue