root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Log exception in ErrorPageFilter 

Fixes gh-1130
This commit is contained in:
Dave Syer 2014-06-21 09:32:36 +01:00
parent 772df9bea7
commit 51496b4e4f
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spring-boot/src/main/java/org/springframework/boot/context/web/ErrorPageFilter.java
View File

@ -136,18 +136,18 @@ class ErrorPageFilter extends AbstractConfigurableEmbeddedServletContainer imple
request.setAttribute(ERROR_EXCEPTION, ex);
request.setAttribute(ERROR_EXCEPTION_TYPE, type.getName());
wrapped.sendError(500, ex.getMessage());
forwardToErrorPage(errorPath, request, wrapped);
forwardToErrorPage(errorPath, request, wrapped, ex);
}
private void forwardToErrorPage(String path, HttpServletRequest request,
ServletResponse response) throws ServletException, IOException {
ServletResponse response, Throwable ex) throws ServletException, IOException {
if (!response.isCommitted()) {
String message = "Cannot forward to error page for" + request.getRequestURI()
+ " (response is committed), so this response may have "
+ "the wrong status code";
// User might see the error page without all the data here but the exception
// isn't going to help anyone (and it's already been logged)
logger.error(message);
// User might see the error page without all the data here but throwing the
// exception isn't going to help anyone (we'll log it to be on the safe side)
logger.error(message, ex);
return;
}
response.reset();