root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Only return complete accessor name when accessor has a backing field

This commit is contained in:
Moritz Halbritter 2023-01-18 13:42:56 +01:00
parent 26d658802f
commit 524a4b6c1e
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/TypeElementMembers.java
View File

@ -168,7 +168,7 @@ class TypeElementMembers {
}
private String getAccessorName(String methodName) {
if (this.isRecord) {
if (this.isRecord && this.fields.containsKey(methodName)) {
return methodName;
}
String name;

18
spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationprocessor/ConfigurationMetadataAnnotationProcessorTests.java
View File

@ -74,6 +74,7 @@ import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
* @author Andy Wilkinson
* @author Kris De Volder
* @author Jonas Keßler
* @author Moritz Halbritter
*/
class ConfigurationMetadataAnnotationProcessorTests extends AbstractMetadataGenerationTests {
@ -504,4 +505,21 @@ class ConfigurationMetadataAnnotationProcessorTests extends AbstractMetadataGene
assertThat(metadata).doesNotHave(Metadata.withProperty("multi.some-integer"));
}
@Test
@EnabledForJreRange(min = JRE.JAVA_16)
void recordWithGetter(@TempDir File temp) throws IOException {
File exampleRecord = new File(temp, "ExampleRecord.java");
try (PrintWriter writer = new PrintWriter(new FileWriter(exampleRecord))) {
writer.println(
"@org.springframework.boot.configurationsample.ConfigurationProperties(\"record-with-getter\")");
writer.println("@org.springframework.boot.configurationsample.ConstructorBinding");
writer.println("public record ExampleRecord(String alpha) {");
writer.println(" public String getBravo() { return alpha; }");
writer.println("}");
}
ConfigurationMetadata metadata = compile(exampleRecord);
assertThat(metadata).has(Metadata.withProperty("record-with-getter.alpha"));
assertThat(metadata).doesNotHave(Metadata.withProperty("record-with-getter.bravo"));
}
}