Merge branch '2.1.x'
This commit is contained in:
commit
5a66dc8c6e
|
|
@ -112,6 +112,10 @@ public class WebMvcMetricsFilter extends OncePerRequestFilter {
|
|||
record(timingContext, response, request, ex.getCause());
|
||||
throw ex;
|
||||
}
|
||||
catch (ServletException | IOException | RuntimeException ex) {
|
||||
record(timingContext, response, request, ex);
|
||||
throw ex;
|
||||
}
|
||||
}
|
||||
|
||||
private TimingContext startAndAttachTimingContext(HttpServletRequest request) {
|
||||
|
|
|
|||
|
|
@ -76,6 +76,7 @@ import org.springframework.web.context.WebApplicationContext;
|
|||
import org.springframework.web.filter.OncePerRequestFilter;
|
||||
import org.springframework.web.servlet.ModelAndView;
|
||||
import org.springframework.web.servlet.config.annotation.EnableWebMvc;
|
||||
import org.springframework.web.servlet.mvc.method.annotation.ResponseBodyEmitter;
|
||||
import org.springframework.web.util.NestedServletException;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
|
@ -188,6 +189,16 @@ public class WebMvcMetricsFilterTests {
|
|||
.tags("exception", "RuntimeException").timer().count()).isEqualTo(1L);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void streamingError() throws Exception {
|
||||
MvcResult result = this.mvc.perform(get("/api/c1/streamingError"))
|
||||
.andExpect(request().asyncStarted()).andReturn();
|
||||
assertThatCode(
|
||||
() -> this.mvc.perform(asyncDispatch(result)).andExpect(status().isOk()));
|
||||
assertThat(this.registry.get("http.server.requests")
|
||||
.tags("exception", "IOException").timer().count()).isEqualTo(1L);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void anonymousError() {
|
||||
try {
|
||||
|
|
@ -451,6 +462,14 @@ public class WebMvcMetricsFilterTests {
|
|||
throw new RuntimeException("Boom on " + id + "!");
|
||||
}
|
||||
|
||||
@GetMapping("/streamingError")
|
||||
public ResponseBodyEmitter streamingError() {
|
||||
ResponseBodyEmitter emitter = new ResponseBodyEmitter();
|
||||
emitter.completeWithError(
|
||||
new IOException("error while writing to the response"));
|
||||
return emitter;
|
||||
}
|
||||
|
||||
@Timed
|
||||
@GetMapping("/regex/{id:\\.[a-z]+}")
|
||||
public String successfulRegex(@PathVariable String id) {
|
||||
|
|
|
|||
Loading…
Reference in New Issue