root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 15 Packages Projects Releases Wiki Activity

Fix DefaultCounterService.reset 

Fix DefaultCounterService.reset to call the reset method of the
underlying MetricWriter.

Fixes gh-1391
This commit is contained in:
Phillip Webb 2014-08-18 17:28:23 -07:00
parent 2188e3553c
commit 5c34b07742
2 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/writer/DefaultCounterService.java
View File

@ -47,7 +47,7 @@ public class DefaultCounterService implements CounterService {
@Override
public void reset(String metricName) {
this.writer.increment(new Delta<Long>(wrap(metricName), 0L));
this.writer.reset(wrap(metricName));
}
private String wrap(String metricName) {

28
spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/writer/DefaultCounterServiceTests.java
View File

@ -17,7 +17,10 @@
package org.springframework.boot.actuate.metrics.writer;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Captor;
import org.mockito.runners.MockitoJUnitRunner;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.mock;
@ -26,6 +29,7 @@ import static org.mockito.Mockito.verify;
/**
* Tests for {@link DefaultCounterService}.
*/
@RunWith(MockitoJUnitRunner.class)
public class DefaultCounterServiceTests {
private final MetricWriter repository = mock(MetricWriter.class);
@ -33,22 +37,28 @@ public class DefaultCounterServiceTests {
private final DefaultCounterService service = new DefaultCounterService(
this.repository);
@Captor
private ArgumentCaptor<Delta<Number>> captor;
@Test
public void incrementPrependsCounter() {
this.service.increment("foo");
@SuppressWarnings("rawtypes")
ArgumentCaptor<Delta> captor = ArgumentCaptor.forClass(Delta.class);
verify(this.repository).increment(captor.capture());
assertEquals("counter.foo", captor.getValue().getName());
verify(this.repository).increment(this.captor.capture());
assertEquals("counter.foo", this.captor.getValue().getName());
assertEquals(1L, this.captor.getValue().getValue());
}
@Test
public void decrementPrependsCounter() {
this.service.decrement("foo");
@SuppressWarnings("rawtypes")
ArgumentCaptor<Delta> captor = ArgumentCaptor.forClass(Delta.class);
verify(this.repository).increment(captor.capture());
assertEquals("counter.foo", captor.getValue().getName());
assertEquals(-1L, captor.getValue().getValue());
verify(this.repository).increment(this.captor.capture());
assertEquals("counter.foo", this.captor.getValue().getName());
assertEquals(-1L, this.captor.getValue().getValue());
}
@Test
public void resetResetsCounter() throws Exception {
this.service.reset("foo");
verify(this.repository).reset("counter.foo");
}
}