From 68d65376d21861b7d4f5727c9d779f7d917aae2b Mon Sep 17 00:00:00 2001 From: Phillip Webb Date: Thu, 1 Oct 2020 16:51:52 -0700 Subject: [PATCH] Refine configuration property table column sizes Increase the size of the first column to improve readability. Closes gh-23604 --- .../boot/build/context/properties/ConfigurationTable.java | 2 +- .../boot/build/context/properties/ConfigurationTableTests.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/buildSrc/src/main/java/org/springframework/boot/build/context/properties/ConfigurationTable.java b/buildSrc/src/main/java/org/springframework/boot/build/context/properties/ConfigurationTable.java index 533c0b8365d..38713e7d356 100644 --- a/buildSrc/src/main/java/org/springframework/boot/build/context/properties/ConfigurationTable.java +++ b/buildSrc/src/main/java/org/springframework/boot/build/context/properties/ConfigurationTable.java @@ -46,7 +46,7 @@ class ConfigurationTable { String toAsciidocTable() { AsciidocBuilder builder = new AsciidocBuilder(); - builder.appendln("[cols=\"1,1,2\", options=\"header\"]"); + builder.appendln("[cols=\"2,1,1\", options=\"header\"]"); builder.appendln("|==="); builder.appendln("|Key|Default Value|Description"); builder.appendln(); diff --git a/buildSrc/src/test/java/org/springframework/boot/build/context/properties/ConfigurationTableTests.java b/buildSrc/src/test/java/org/springframework/boot/build/context/properties/ConfigurationTableTests.java index 71099b32754..94f8cce26f1 100644 --- a/buildSrc/src/test/java/org/springframework/boot/build/context/properties/ConfigurationTableTests.java +++ b/buildSrc/src/test/java/org/springframework/boot/build/context/properties/ConfigurationTableTests.java @@ -38,7 +38,7 @@ public class ConfigurationTableTests { "This is another description.", false); table.addEntry(new SingleConfigurationTableEntry(first)); table.addEntry(new SingleConfigurationTableEntry(second)); - assertThat(table.toAsciidocTable()).isEqualTo("[cols=\"1,1,2\", options=\"header\"]" + NEWLINE + "|===" + assertThat(table.toAsciidocTable()).isEqualTo("[cols=\"2,1,1\", options=\"header\"]" + NEWLINE + "|===" + NEWLINE + "|Key|Default Value|Description" + NEWLINE + NEWLINE + "|[[spring.test.other]]<>" + NEWLINE + "|`+other value+`" + NEWLINE + "|+++This is another description.+++" + NEWLINE + NEWLINE